From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751698AbcF3CPP (ORCPT ); Wed, 29 Jun 2016 22:15:15 -0400 Received: from smtp-proxy003.phy.lolipop.jp ([157.7.104.44]:43066 "EHLO smtp-proxy003.phy.lolipop.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751376AbcF3CPN (ORCPT ); Wed, 29 Jun 2016 22:15:13 -0400 Subject: Re: [PATCH] ALSA: riptide: Use DIV_ROUND_UP To: Amitoj Kaur Chawla , perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20160629145628.GA13915@amitoj-Inspiron-3542> Cc: julia.lawall@lip6.fr From: Takashi Sakamoto Message-ID: <5774808C.60206@sakamocchi.jp> Date: Thu, 30 Jun 2016 11:14:36 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160629145628.GA13915@amitoj-Inspiron-3542> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Jun 29 2016 23:56, Amitoj Kaur Chawla wrote: > The kernel.h macro DIV_ROUND_UP performs the computation > (((n) + (d) - 1) /(d)) but is perhaps more readable. > > The Coccinelle script used to make this change is as follows: > @haskernel@ > @@ > > #include > > @depends on haskernel@ > expression n,d; > @@ > > ( > - (n + d - 1) / d > + DIV_ROUND_UP(n,d) > | > - (n + (d - 1)) / d > + DIV_ROUND_UP(n,d) > ) > > Signed-off-by: Amitoj Kaur Chawla > --- > sound/pci/riptide/riptide.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c > index 94639d6..067a912 100644 > --- a/sound/pci/riptide/riptide.c > +++ b/sound/pci/riptide/riptide.c > @@ -1496,7 +1496,7 @@ static int snd_riptide_prepare(struct snd_pcm_substream *substream) > f = PAGE_SIZE; > while ((size + (f >> 1) - 1) <= (f << 7) && (f << 1) > period) > f = f >> 1; > - pages = (size + f - 1) / f; > + pages = DIV_ROUND_UP(size, f); > data->size = size; > data->pages = pages; > snd_printdd > Reviewed-by: Takashi Sakamoto Regards Takashi Sakamoto