From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: Paolo Bonzini <pbonzini@redhat.com>, Bandan Das <bsd@redhat.com>,
kvm@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] mmu: don't set the present bit unconditionally
Date: Thu, 30 Jun 2016 15:18:31 +0800 [thread overview]
Message-ID: <5774C7C7.2080501@linux.intel.com> (raw)
In-Reply-To: <3b4a6bb6-4364-b188-48da-be79c0dc7534@redhat.com>
On 06/29/2016 04:18 PM, Paolo Bonzini wrote:
>
>
> On 29/06/2016 05:17, Xiao Guangrong wrote:
>>>
>>> +++ b/arch/x86/kvm/mmu.c
>>> @@ -2516,13 +2516,17 @@ static int set_spte(struct kvm_vcpu *vcpu, u64
>>> *sptep,
>>> gfn_t gfn, kvm_pfn_t pfn, bool speculative,
>>> bool can_unsync, bool host_writable)
>>> {
>>> - u64 spte;
>>> + u64 spte = 0;
>>> int ret = 0;
>>> + struct kvm_mmu *context = &vcpu->arch.mmu;
>>> + bool execonly = !(context->guest_rsvd_check.bad_mt_xwr &
>>> + (1ull << VMX_EPT_EXECUTABLE_MASK));
>>
>> Could we introduce a new field, say execonly, to "struct kvm_mmu"?
>> That would make the code be more clearer.
>
> Given how execonly is used, let's add shadow_present_mask instead.
Yup, it is better.
next prev parent reply other threads:[~2016-06-30 7:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 4:32 [PATCH 0/5] Add support for EPT execute only for nested hypervisors Bandan Das
2016-06-28 4:32 ` [PATCH 1/5] mmu: mark spte present if the x bit is set Bandan Das
2016-06-28 8:44 ` Paolo Bonzini
2016-06-28 17:33 ` Bandan Das
2016-06-28 20:17 ` Paolo Bonzini
2016-06-28 20:37 ` Bandan Das
2016-06-28 20:49 ` Paolo Bonzini
2016-06-28 21:04 ` Bandan Das
2016-06-29 3:01 ` Xiao Guangrong
2016-07-05 3:06 ` Wanpeng Li
2016-07-05 10:50 ` Paolo Bonzini
2016-07-05 11:29 ` Wanpeng Li
2016-06-28 4:32 ` [PATCH 2/5] mmu: pass execonly value when initializing rsvd bits Bandan Das
2016-06-29 3:07 ` Xiao Guangrong
2016-06-28 4:32 ` [PATCH 3/5] mmu: don't set the present bit unconditionally Bandan Das
2016-06-28 8:57 ` Paolo Bonzini
2016-06-28 17:30 ` Bandan Das
2016-06-28 20:21 ` Paolo Bonzini
2016-07-05 5:50 ` Wanpeng Li
2016-07-05 10:50 ` Paolo Bonzini
2016-06-29 3:17 ` Xiao Guangrong
2016-06-29 8:18 ` Paolo Bonzini
2016-06-30 7:18 ` Xiao Guangrong [this message]
2016-06-28 4:32 ` [PATCH 4/5] mmu: remove is_present_gpte() Bandan Das
2016-06-28 4:32 ` [PATCH 5/5] nvmx: advertise support for ept execute only Bandan Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5774C7C7.2080501@linux.intel.com \
--to=guangrong.xiao@linux.intel.com \
--cc=bsd@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).