From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932107AbcF3NYI (ORCPT ); Thu, 30 Jun 2016 09:24:08 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:55508 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751953AbcF3NYF (ORCPT ); Thu, 30 Jun 2016 09:24:05 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68e-f79266d000001428-73-57751d7297c3 Content-transfer-encoding: 8BIT Message-id: <57751D72.9020509@samsung.com> Date: Thu, 30 Jun 2016 22:24:02 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Arnd Bergmann , MyungJoo Ham Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] extcon: link devres into core module References: <20160629143854.125013-1-arnd@arndb.de> In-reply-to: <20160629143854.125013-1-arnd@arndb.de> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpmkeLIzCtJLcpLzFFi42JZI2JSqFskWxpu8LBf0eLvpGPsFpd3zWGz uN24gs2B2eP3r0mMHn1bVjF6fN4kF8AcxWWTkpqTWZZapG+XwJWxeL5wwXqeimn757A2ME7l 6mLk5JAQMJHY8LCJBcIWk7hwbz1bFyMXh5DACkaJ5o6jrDBF7xfNYodILGWUuHHgDVgHr4Cg xI/J94BsDg5mAXmJI5eyQcLMAuoSk+YtYoaof8AocWTHVnaIei2JphkLwYayCKhKvP8CMYcN KL7/xQ02kDmiAhES3ScqQcIiAl4SM99NZYeYqSDx694msFZhAUuJ7f9nQx3aySjxec0nNpAE J9ChP7vmMIIkJAQWsUvMOrODBWKZgMS3yYfADpUQkJXYdIAZ4jFJiYMrbrBMYBSbheSdWQjv zELyzgJG5lWMoqkFyQXFSelFRnrFibnFpXnpesn5uZsYgXFz+t+zvh2MNw9YH2IU4GBU4uGd wVoSLsSaWFZcmXuI0RToiInMUqLJ+cDozCuJNzQ2M7IwNTE1NjK3NFMS502Q+hksJJCeWJKa nZpakFoUX1Sak1p8iJGJg1OqgTGx5tjJ6IW8tzIsFgcsO/DjSq7InJ1bP1j/L3d4GiPUJX3r Wsq2gtI+zcb1FTEbjrFt8mBq2fvz4rSc7HN+olXFP+Y9CBc9InG5X87X/+2tZ4GR152u8bqI Fp+dPO/2atWOmM1hYRmtZ7vN7V1Mgo4sfKPlHxL70U4k+v9r2bhdbr7HjlVotimxFGckGmox FxUnAgCskjRdlgIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrAIsWRmVeSWpSXmKPExsVy+t9jAd0i2dJwg9nnZCz+TjrGbnF51xw2 i9uNK9gcmD1+/5rE6NG3ZRWjx+dNcgHMUQ2MNhmpiSmpRQqpecn5KZl56bZK3sHxzvGmZgaG uoaWFuZKCnmJuam2Si4+AbpumTlAm5QUyhJzSoFCAYnFxUr6dpgmhIa46VrANEbo+oYEwfUY GaCBhDWMGYvnCxes56mYtn8OawPjVK4uRk4OCQETifeLZrFD2GISF+6tZ+ti5OIQEljKKHHj wBsWkASvgKDEj8n3gGwODmYBeYkjl7JBwswC6hKT5i1ihqh/wChxZMdWdoh6LYmmGQtZQWwW AVWJ918g5rABxfe/uMEGMkdUIEKi+0QlSFhEwEti5rup7BAzFSR+3dsE1iosYCmx/f9sqHs6 GSU+r/nEBpLgBDr6Z9ccxgmMArOQnDcL4bxZSM5bwMi8ilEitSC5oDgpPdcoL7Vcrzgxt7g0 L10vOT93EyM4Np9J72A8vMv9EKMAB6MSD++BfSXhQqyJZcWVuYcYJTiYlUR4TaRLw4V4UxIr q1KL8uOLSnNSiw8xmgL9N5FZSjQ5H5g28kriDY1NzIwsjcwNLYyMzZXEeR//XxcmJJCeWJKa nZpakFoE08fEwSnVwKgfE7n5q8RUbimv5hLF9+Xpsj6ipoz+14uyfY0+8blnPXKe8DPvcslN BnUpxsynV90sG2+s0XvPk6tQpm0bbrZmr0ZY/95TM3tmbyuPeFmuGKckpn/1wb09PSx5WxyV bqrfuPX8Tj2Dauqp5pV7PhWYlc/S0J8WbfRkbadYwHy9IycZb6s8V2Ipzkg01GIuKk4EAKNR RfzjAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On 2016년 06월 29일 23:38, Arnd Bergmann wrote: > Splitting the resource-managed functions into a separate module > means that the extcon core now fails to build because the internal > "extcon_dev_allocate" symbol is not exported: > > ERROR: extcon_dev_allocate [drivers/extcon/devres.ko] undefined! > > My guess is that the intention was not to have two separate > modules (which could be fixed by adding an export, plus the > normal MODULE_AUTHOR/MODULE_LICENSE/... fields), but have two > source files in the same module. > > This fixes the Makefile accordingly, making the name of the > module extcon_core.ko, which is created from building both > extcon.c and devres.c. > > Signed-off-by: Arnd Bergmann > Fixes: b225d00f3ad2 ("extcon: Split out the resource-managed functions from extcon core") > --- > drivers/extcon/Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/extcon/Makefile b/drivers/extcon/Makefile > index 423ebc8714c5..972c813c375b 100644 > --- a/drivers/extcon/Makefile > +++ b/drivers/extcon/Makefile > @@ -2,7 +2,8 @@ > # Makefile for external connector class (extcon) devices > # > > -obj-$(CONFIG_EXTCON) += extcon.o devres.o > +obj-$(CONFIG_EXTCON) += extcon-core.o > +extcon-core-objs += extcon.o devres.o > obj-$(CONFIG_EXTCON_ADC_JACK) += extcon-adc-jack.o > obj-$(CONFIG_EXTCON_ARIZONA) += extcon-arizona.o > obj-$(CONFIG_EXTCON_AXP288) += extcon-axp288.o > Thanks for your fixup. Applied it. Regards, Chanwoo Choi