From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752277AbcGARxm (ORCPT ); Fri, 1 Jul 2016 13:53:42 -0400 Received: from mail-db5eur01on0090.outbound.protection.outlook.com ([104.47.2.90]:30432 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751680AbcGARxl (ORCPT ); Fri, 1 Jul 2016 13:53:41 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: [PATCH v3] kasan/quarantine: fix bugs on qlist_move_cache() To: Dmitry Vyukov , Joonsoo Kim References: <1467381733-18314-1-git-send-email-iamjoonsoo.kim@lge.com> CC: Andrew Morton , Alexander Potapenko , kasan-dev , "linux-mm@kvack.org" , LKML , Joonsoo Kim From: Andrey Ryabinin Message-ID: <57767BCA.8010305@virtuozzo.com> Date: Fri, 1 Jul 2016 17:18:50 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AM3PR07CA0045.eurprd07.prod.outlook.com (10.141.45.173) To VI1PR0801MB1310.eurprd08.prod.outlook.com (10.167.197.148) X-MS-Office365-Filtering-Correlation-Id: d553f357-6245-479a-596e-08d3a1ba80fe X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1310;2:ZGflr7LltC/pTY0Bt5e5IQICzc338FjI5WgTflvuCbyc2NQy1YAbEJQ4S2GdY0UahneJqf6R1FFoa9/4hLUQq64rBdb9/rcXRF1XdrV4axpCGtMOIycpqAtrBVPLIgePUqv4p/cZDlpKCeLbM0spoPnLMxeQu5I1SApCNmYL1aLF6FUrTRhzQleGbR7ereo5;3:BApqoaTIvRnLVTynjVbYRlKagaQXyM0G+mYGMAhwQVk9EdnWWFY8tAj2wRxeSKhCqTjzo1hWYV/yNRymgDmRL/br6p/wobOrpriTdVIdHOKnrYabI1Ougqtw0LBlA/Rx X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0801MB1310; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1310;25:73HJvcz/C+cogHtIHQ66ZTRfBbab/xE3Dqb3TCCrmQfTmJivm2TsjloaJ2KkSp72gS7nSMxTgtxaykHswFprJ0XZAP4Cd+E7hAMIJp9bpBI4uMnWYw1JnddZCpJwlRDudnsBx9ocYW65Czu6oaRN954iKQrjvAwmqkhCXlTbsWCQrkjaLns6UHzvuUF1M0EtLGRbcDC+kILI3R04NVppnZX0HBkvYlaG9piQJ7zLTwXoKLWpB5al0kc2sT3afP8M0B0wIUnWD610l7ZY8WGZkiztkUWkli+Ng2X5Z6MleCShuzyJoBRJQLxHnbp7zcPkYZ4bgHTvq4JbYNE71Vr+I2U5OY2DrGCkwqI4SOWYX7VRsND1qF0jIFRuVQOe53Ed01biAei78tJgXhNml4wbHV4J4h7REf9EE/VUKTP0+L4KpmpahZaL1EX2yiYZY/3O+ZWEyofZKmCRixDLVXNZs7cbRD8A9jSeYJfTb2ZO3GwwOT9fC5UWusMmpK9j5u3jxG557kD+0vIycHsYXZuSukVN6I6mKCb3q1bN+BnIeb1vyj+Q/+JFD5mvktIKV/FPhLdvLyUfiJaQ7oA1PYtI7x8OmMcSnMFnbK0URXPGAuw6TNmBdIIIm3W9Ou0S/D7J8M44a9UmS8PXothPf4mYNTPwoj+WunQ4yglfp5qnuS1hNJv/qF/qyaJbshORrySRcukizJGba7rnKEjrtH8uPw==;31:buxBAX5hc9jSBRBCk0mXdVkScExvx702iTGxsseLZnJjXQx0JcuXds6vxXIfKCTyrsBRSvqeB5WSqVmpR6a5IytMamHXflQ0cNyEdLMlBZoR3fy3X/0+0W0f4XugBvWbZqOmJ4WE2D3rMIIvcgWYyq+/0zuSxs20VvrzPdqUgfBoEQ0LwRQ98LAR237ecXj7sep4zPutLtNKKjWZAZXZ8A== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(211936372134217); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(6041072)(6043046);SRVR:VI1PR0801MB1310;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0801MB1310; X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1310;4:LwjKqoOc45kFr8PBNwJ3tmCzYK0faVazkb/ikIum+YBVzwWluDmC1vI6LjNJox1giHakA68bbllbM2HIEH95fouz6md5V4PqGdX31c5XjBUHDKmDlC14xAFjTGtXgfO0ZsEnaXYTtodVWYaLR/ks2VLgQFUG7Wdb+9d//FOu2Q4dh7BRyacP79ne1atCMQotx4AyuZNk4mFSvtU+WBD932sgibM1HO74DCB5CAxzhOFX2k2IhcVVKTDn874N7QkXRbovkyP/i4VnNoJmi13Lac0yU9NkL97UDZdXkhDsfUxsJf9QBnzghHi60a3ftKKLmjZ2DYv3Dps8bIsmGbw8MBMbFYAfFnSbMJKPi8TI9zGzbL6BKaRXEDEfVamUp1xHRg3dILQjE2teCEdMQzQAFHYBI2TT9PeiMlvuHpdno0g9KZuyKrzNq2wOn+HkHee8touHZRCRy/QN/q+5uEStvHsmLhKuQXBSweKCTfCBqgg= X-Forefront-PRVS: 0990C54589 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(377454003)(377424004)(24454002)(199003)(189002)(33656002)(97736004)(7846002)(5001770100001)(8676002)(189998001)(81166006)(81156014)(42186005)(101416001)(23676002)(36756003)(93886004)(92566002)(64126003)(230700001)(4001350100001)(66066001)(77096005)(47776003)(105586002)(68736007)(86362001)(6116002)(87266999)(7736002)(50466002)(54356999)(106356001)(3846002)(65806001)(19580395003)(19580405001)(99136001)(59896002)(80316001)(4326007)(586003)(65816999)(76176999)(2950100001)(65956001)(50986999)(305945005)(83506001)(2906002);DIR:OUT;SFP:1102;SCL:1;SRVR:VI1PR0801MB1310;H:[10.30.19.223];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtWSTFQUjA4MDFNQjEzMTA7MjM6TFdudWFCSFZ4bVQ4VlBwZFdBQkgvanBQ?= =?utf-8?B?U0cydlJhbUtuamxOWDJOU2FFQWRmeGR0eVBNQ25YSE9VTDJ5UmpvbXQ3aFJk?= =?utf-8?B?WmpDUUZzeDdoRjNPeGVPWWlUVVFEWXRsY2tBWmNpNmVDNGQ2aVRLeEpIT0NC?= =?utf-8?B?bWR3V0w3WHp0YmcvWDgwbjBHejNjMC9FcndBazAyTjAxZndVOHd6TkVGOGpz?= =?utf-8?B?TnpqeVIyemJrU0Q2aUxySXpQZTU1OU9QRmducHRtZHRsaVJRRGRFUW5xSW5Y?= =?utf-8?B?Ung4SmM5d0RpUDVOSE9aM0MxV1Jub0ptV3J2Tk5pcFpIam1qVUkrYTF3VCtU?= =?utf-8?B?VU1hSnl6Y1ZJejZJdFhSUHZ5cU9neG44cDRZbzZ1QjFZUThmcXh0N3BiUFFB?= =?utf-8?B?bkR2TmR5QzQ2QU9RVGMzYXNZQ0JqYTZzazZ2Rkltd0V2WkMwWUdFakQxK2xR?= =?utf-8?B?dTMwVk9IdVJDcGlQRnhkcU5ZSzVmM2plS3ZjL1lJVTVsSWtjV1NXRnd5V0VU?= =?utf-8?B?a1N2THlWVStQRWFTVkE3NGs1VFdFbHlKZ2NGRUdaOFAxQlRFemIwcXQvNU5P?= =?utf-8?B?SnRsNFVTUmI3Tlg2RGlMaXM5aGFxUEpxb25wVkEzd1NadXpPVy9kUlFxajVP?= =?utf-8?B?b1VxbHVZMjlRbkE5SEMvaG9Yc1pNRmg4bVZvTExLb2pLekFIL2V3S2JEUmNT?= =?utf-8?B?UUIrbG9QUDFBR1A4bU1HZnpNV3Q3c1dmTFY0c3NOVDMvUVlKRkZXR2w4cVU3?= =?utf-8?B?UUJoTDNHQWtKSjRRYmVMb0VCL1hWR1poOTBISDFuWVlybGxBTzVneitSSnox?= =?utf-8?B?MWYvUDhRbm5GK3AxeHB4SzRuUy9Sd1p4ay9QMC9wSjRJR2RsRlI0L24xMG5R?= =?utf-8?B?SlFuNkFucFBxUE1HNVVMWWZ4YzhOVENCMi9ZdHluQzF2bzdCTE93U3BJQzha?= =?utf-8?B?cWZkN0pZQ21pNndYVzJNdG1GazM2ZHk2M2dvVERzUDVXQ3Mwc3ZmYWdQOHhN?= =?utf-8?B?N3JPcXhBZmpIM2c0blE1MG1rSElZZG1NdkUrUXRiVCthYzBueU1HV1ZReWNK?= =?utf-8?B?SjhMK3ZrcXNsTEJMOWtQRzdYekozTnBPOWpWc1dxYkhLVzdPYkdJbHhoR2ZG?= =?utf-8?B?akZ1QXJGa1JueFFxSEhZckFpdGJJZGxpalFsa1VtcUo5ak9BM0k5anBJZWRU?= =?utf-8?B?Y3BGZGhjY2tTODJsb3lsNW8zRDkvOHM4UXVNTW0wRGVWTXV6WTVQVEpqcGpi?= =?utf-8?B?M09EMGF4U0RxeDZsL0h6NmJYL1A3UEFia0thLzEwcTNXT004bTZHNlBjNEpS?= =?utf-8?B?bTFYRWpqUDZxcXlLTDFiVG83c1ZiMVo0aDlyeEVRcVBvM1ErcTZPdi9EMGtM?= =?utf-8?B?L3p0OExndGttWW93ZnlIWlpzQ1BZZHhZOHJjMXV5dWluSjU3dzN3bVFYVVBs?= =?utf-8?B?WFBrQlNJNlhwRWxieUlnQndxd2lnaCtGcUtmTXV6WTV6bCtzWWRMRk14WCt1?= =?utf-8?B?L0RjUlR4elhjMXNZdnBZS1FsWE01dTVVL0U5eHAzMHQ4TWhCT2RoSUlEWUlR?= =?utf-8?B?TXZzd1Njblk1ZkRPMDdvbTFDaHl0NjJIUjA4UFE3OTd3L2RIRk5aSmZGVDM1?= =?utf-8?B?Ym15T1FaUE8vSVhTUnlRa2dVSktrTEFhQ3N3MFBlWm43d0NKc0NkNTJFUWw0?= =?utf-8?B?N1JLbGlJYzhIT2dOVi82aUdERDM1c0ZncGNvV1VkamV1R2RRbkJ0WG9wSHZK?= =?utf-8?B?TlI5UEJRcVZXTXBLMUN5NGJTbzk4UlZkcTBpU2ZXaEEraHMyVk9hazNwVVlr?= =?utf-8?B?akg2WTVoeHJTeWtFUmRudzNpN1BxRGNkM3ZlNFpOVlBza01Fdz09?= X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1310;6:ygZZsVrsJeb3NAGyF+iC13uCr/h9Yjl25ibVGypZWmm7n8/Py7MEwwm5zV/kyVZ4zYEGfKQW2fWs20nzsU8c8bkeuV6TFNz1ihBpKmpbnMs0heI9IDk2LDQGtRTL6xeT97BOVhYrU3mlsqHpnWEe5ohAbnSFrRcSckrLr2+OmfYqp/7ebs/+ZshSF41OG3VfwJl5zuG91h7gcgqoU91zFRB7VI+k0RGQY4D3u56bEbGh9+7aHGpKzwT6vlM+5ah1tEFXiGOcB8BdQ/9wCC3YKEZEATU5m1gGZ14fIi/8msEzMP9byEZm7BeRAMJ872j6;5:7yIlDEscw4PuDa0wu3YGp8N3dsgDnlQcEzFQojQCOsZidxmH1MNfLhILCx3VeHUB9vigsX8UJArk9VJmQyP7eg6bJ8TRVbJbu/+BTZK2hf8RVbjbja7eOcnxisZ+zLEC7jXgNQS0a/MDYclFKmgfAw==;24:o+0//jEHdVF8IJHm+UfbQaSsnSZsFl9Kr7lszQf+Phr4+RCCBL0CF8bJjYg7fO9p5nFqzJ9OI8Lg27sV4b8Ea7Qi4fH+p24gFdBMraFYz3g=;7:vfxf/Obv9bHzxaIw4MGAtpIQ+5xH0Ky/G2HgsXOHrDVJgWyN8hiA1yAd4XkH/rZ7ceFXTzXk7gJCwu/4CkOW+z9WKAuYLikk1DPKEmETVLXPW/bBljecn3LreR0TL/Ht/TPe0w4mvWk+6ZuegdzyUS5tgk6CSKm+5fQzyq9GN6xmsRoVoCQvEb8UZrEKANgsCGAU/0vFNqR2qfFoZnFCkCTJLV9Qhzvd+4sJtGze7N2QiBzhWQ69x+gnxGjURtkn SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;VI1PR0801MB1310;20:4dXt30IBXrkLx9djIAN6RCLeiYX91c2FKa3YV3dLQcBCV+6gxPkxf4y1/Yn9mu9fSlnqyrzMLSv9a2aT9tcI+P7XlTz1AUFEXs2sUCtJZmnvJ+3MHMFcsPh+GsDkAttncnhCgrYb+2VV7/7afeNj1NAq3KuPIuC7O3AEmoXiyyQ= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2016 14:17:58.2557 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1310 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/01/2016 05:15 PM, Dmitry Vyukov wrote: > On Fri, Jul 1, 2016 at 4:09 PM, Joonsoo Kim wrote: >> 2016-07-01 23:03 GMT+09:00 Dmitry Vyukov : >>>> + >>>> + if (obj_cache == cache) >>>> + qlist_put(to, qlink, cache->size); >>>> + else >>>> + qlist_put(from, qlink, cache->size); >>> >>> This line is wrong. If obj_cache != cache, object size != cache->size. >>> Quarantine contains objects of different sizes. >> >> You're right. 11 pm is not good time to work. :/ >> If it is fixed, the patch looks correct to you? >> I will fix it and send v4 on next week. > > > I don't see anything else wrong. But I need to see how you fix the size issue. > Performance of this operation is not particularly critical, so the > simpler the better. Is there any other way besides obvious: s/cache->size/obj_cache->size ?