From: Jens Axboe <axboe@fb.com>
To: Josef Bacik <jbacik@fb.com>, <mpa@pengutronix.de>,
<linux-kernel@vger.kernel.org>,
<nbd-general@lists.sourceforge.net>, <kernel-team@fb.com>,
<linux-block@vger.kernel.org>
Subject: Re: [PATCH] nbd: convert to blkmq
Date: Fri, 1 Jul 2016 08:26:22 -0600 [thread overview]
Message-ID: <57767D8E.40808@fb.com> (raw)
In-Reply-To: <1467382507-523615-1-git-send-email-jbacik@fb.com>
On 07/01/2016 08:15 AM, Josef Bacik wrote:
> This moves NBD over to using blkmq, which allows us to get rid of the NBD
> wide queue lock and the async submit kthread. We will start with 1 hw
> queue for now, but I plan to add multiple tcp connection support in the
> future and we'll fix how we set the hwqueue's.
Looks pretty clean. I'd get rid of that horrible nbd_find_request() as
well, though. Store the request tag in the reply.handle, and then just
lookup the request from the tag, if the tag is valid. The resulting
request can then be checked for proper state (started).
nbd->active_cmd needs to die as well.
--
Jens Axboe
parent reply other threads:[~2016-07-01 14:26 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1467382507-523615-1-git-send-email-jbacik@fb.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57767D8E.40808@fb.com \
--to=axboe@fb.com \
--cc=jbacik@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=nbd-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox