* Re: [PATCH] nbd: convert to blkmq
[not found] <1467382507-523615-1-git-send-email-jbacik@fb.com>
@ 2016-07-01 14:26 ` Jens Axboe
0 siblings, 0 replies; only message in thread
From: Jens Axboe @ 2016-07-01 14:26 UTC (permalink / raw)
To: Josef Bacik, mpa, linux-kernel, nbd-general, kernel-team,
linux-block
On 07/01/2016 08:15 AM, Josef Bacik wrote:
> This moves NBD over to using blkmq, which allows us to get rid of the NBD
> wide queue lock and the async submit kthread. We will start with 1 hw
> queue for now, but I plan to add multiple tcp connection support in the
> future and we'll fix how we set the hwqueue's.
Looks pretty clean. I'd get rid of that horrible nbd_find_request() as
well, though. Store the request tag in the reply.handle, and then just
lookup the request from the tag, if the tag is valid. The resulting
request can then be checked for proper state (started).
nbd->active_cmd needs to die as well.
--
Jens Axboe
^ permalink raw reply [flat|nested] only message in thread