Re: [RFC PATCH 0/2] net: ethernet: Add support for gmii2rgmii converter

Florian Fainelli
2016-07-01T15:04:42Z

Le 30/06/2016 23:20, Kedareswara rao Appana a écrit :
> This patch series does the following
> ---> Add support for gmii2rgmii converter.
> ---> Add support for gmii2rgmii converter in the macb driver.
>
> Earlier sent one RFC patch https://patchwork.kernel.org/patch/9186615/
> which includes converter related stuff also in macb driver.
> This patch series fixes this issue.

This still seems very adhoc and not completely explained. Can you
clarify how the gmmi2rgmii converter gets used?

Is the expectation that a MACB Ethernet adapter will be connected to a
RGMII PHY like this:

MACB <=> GMII2RGMII <=> RGMII PHY
MACB MDIO <===========> RGMII_PHY

and still have the ability to control both the PHY device's MDIO
registers and the GMII2RGMII converter and we need to make sure both
have matching settings, or is it something like this:

MACB <=> GMII2RGMII <=> RGMII PHY
MACB MDIO unconnected

and we lose the ability to query the PHY via MDIO?

As Nicolas pointed out, providing a binding documentation update may
help reviewers understand what is being accomplished here.

Thanks!

>
> Kedareswara rao Appana (2):
> net: ethernet: xilinx: Add gmii2rgmii converter support
> net: macb: Add gmii2rgmii phy converter support
>
> drivers/net/ethernet/cadence/macb.c | 21 ++++++-
> drivers/net/ethernet/cadence/macb.h | 3 +
> drivers/net/ethernet/xilinx/Kconfig | 7 ++
> drivers/net/ethernet/xilinx/Makefile | 1 +
> drivers/net/ethernet/xilinx/xilinx_gmii2rgmii.c | 76 +++++++++++++++++++++++
> include/linux/xilinx_gmii2rgmii.h | 24 +++++++
> 6 files changed, 131 insertions(+), 1 deletions(-)
> create mode 100644 drivers/net/ethernet/xilinx/xilinx_gmii2rgmii.c
> create mode 100644 include/linux/xilinx_gmii2rgmii.h
>

--
Florian