From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752171AbcGAPSl (ORCPT ); Fri, 1 Jul 2016 11:18:41 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:47423 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750915AbcGAPSj (ORCPT ); Fri, 1 Jul 2016 11:18:39 -0400 Subject: Re: [PATCH] iio: dac: mcp4725: Remove unneeded conversions to bool To: Peter Meerwald-Stadler References: <20160701143352.17224-1-afd@ti.com> CC: Jonathan Cameron , , From: "Andrew F. Davis" Message-ID: <577689C4.6090803@ti.com> Date: Fri, 1 Jul 2016 10:18:28 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/01/2016 10:03 AM, Peter Meerwald-Stadler wrote: > >> Found with scripts/coccinelle/misc/boolconv.cocci. > > I'd argue that > > pd = (inbuf[0] >> 1) & 0x3; > if (pd) { > data->powerdown = true; > data->powerdown_mode = pd - 1; > } else { > data->powerdown = false; > data->powerdown_mode = 2; /* largest register to gnd */ > } > > is less compact but probably easier to read/understand; > I agree, this is a much better fix. Would you like to submit this version as a patch? Andrew >> Signed-off-by: Andrew F. Davis > > but I'm fine with the proposed patch as well to make cocci happy > > regards, p. > >> --- >> drivers/iio/dac/mcp4725.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/iio/dac/mcp4725.c b/drivers/iio/dac/mcp4725.c >> index cca935c..c3bb3fd 100644 >> --- a/drivers/iio/dac/mcp4725.c >> +++ b/drivers/iio/dac/mcp4725.c >> @@ -361,7 +361,7 @@ static int mcp4725_probe(struct i2c_client *client, >> return err; >> } >> pd = (inbuf[0] >> 1) & 0x3; >> - data->powerdown = pd > 0 ? true : false; >> + data->powerdown = pd > 0; >> data->powerdown_mode = pd ? pd - 1 : 2; /* largest register to gnd */ >> data->dac_value = (inbuf[1] << 4) | (inbuf[2] >> 4); >> >> >