* [PATCH] tracing: Have HIST_TRIGGERS select TRACING
@ 2016-07-03 13:51 Tom Zanussi
2016-07-05 19:48 ` Steven Rostedt
0 siblings, 1 reply; 2+ messages in thread
From: Tom Zanussi @ 2016-07-03 13:51 UTC (permalink / raw)
To: Steven Rostedt; +Cc: linux-kernel@vger.kernel.org >> LKML
The kbuild test robot reported a compile error if HIST_TRIGGERS was
enabled but nothing else that selected TRACING was configured in.
HIST_TRIGGERS should directly select it and not rely on anything else
to do it.
Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
---
kernel/trace/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index fafeaf8..f4b86e8 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -542,6 +542,7 @@ config HIST_TRIGGERS
bool "Histogram triggers"
depends on ARCH_HAVE_NMI_SAFE_CMPXCHG
select TRACING_MAP
+ select TRACING
default n
help
Hist triggers allow one or more arbitrary trace event fields
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tracing: Have HIST_TRIGGERS select TRACING
2016-07-03 13:51 [PATCH] tracing: Have HIST_TRIGGERS select TRACING Tom Zanussi
@ 2016-07-05 19:48 ` Steven Rostedt
0 siblings, 0 replies; 2+ messages in thread
From: Steven Rostedt @ 2016-07-05 19:48 UTC (permalink / raw)
To: Tom Zanussi; +Cc: linux-kernel@vger.kernel.org >> LKML
On Sun, 03 Jul 2016 08:51:34 -0500
Tom Zanussi <tom.zanussi@linux.intel.com> wrote:
> The kbuild test robot reported a compile error if HIST_TRIGGERS was
> enabled but nothing else that selected TRACING was configured in.
>
> HIST_TRIGGERS should directly select it and not rely on anything else
> to do it.
>
I added:
Reported-by: kbuild test robot <fennguang.wu@intel.com>
Fixes: 7ef224d1d0e3a ("tracing: Add 'hist' event trigger command")
This isn't that big of a deal, so I'm just going to put it into my
queue for the next merge window.
-- Steve
> Signed-off-by: Tom Zanussi <tom.zanussi@linux.intel.com>
> ---
> kernel/trace/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
> index fafeaf8..f4b86e8 100644
> --- a/kernel/trace/Kconfig
> +++ b/kernel/trace/Kconfig
> @@ -542,6 +542,7 @@ config HIST_TRIGGERS
> bool "Histogram triggers"
> depends on ARCH_HAVE_NMI_SAFE_CMPXCHG
> select TRACING_MAP
> + select TRACING
> default n
> help
> Hist triggers allow one or more arbitrary trace event fields
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-05 19:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-03 13:51 [PATCH] tracing: Have HIST_TRIGGERS select TRACING Tom Zanussi
2016-07-05 19:48 ` Steven Rostedt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).