From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932233AbcGCUkw (ORCPT ); Sun, 3 Jul 2016 16:40:52 -0400 Received: from mail-pa0-f67.google.com ([209.85.220.67]:35385 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932124AbcGCUku (ORCPT ); Sun, 3 Jul 2016 16:40:50 -0400 Message-ID: <5779784A.9040206@gmail.com> Date: Sun, 03 Jul 2016 21:40:42 +0100 From: Sudip Mukherjee User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Dmitry Torokhov CC: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org Subject: Re: [PATCH] Input: axp20x-pek: use devm_add_action_or_reset References: <1465740750-4881-1-git-send-email-sudipm.mukherjee@gmail.com> In-Reply-To: <1465740750-4881-1-git-send-email-sudipm.mukherjee@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 12 June 2016 03:12 PM, Sudip Mukherjee wrote: > If devm_add_action() fails we are explicitly calling > axp20x_remove_sysfs_group() to free the resources allocated. Lets use > the helper devm_add_action_or_reset() and return directly in case of > error, as we know that the cleanup function has been already called by > the helper if there was any error. > > Signed-off-by: Sudip Mukherjee > --- A gentle ping. Regards Sudip > drivers/input/misc/axp20x-pek.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/input/misc/axp20x-pek.c b/drivers/input/misc/axp20x-pek.c > index 1ac898d..419ca97 100644 > --- a/drivers/input/misc/axp20x-pek.c > +++ b/drivers/input/misc/axp20x-pek.c > @@ -260,10 +260,10 @@ static int axp20x_pek_probe(struct platform_device *pdev) > return error; > } > > - error = devm_add_action(&pdev->dev, > - axp20x_remove_sysfs_group, &pdev->dev); > + error = devm_add_action_or_reset(&pdev->dev, > + axp20x_remove_sysfs_group, > + &pdev->dev); > if (error) { > - axp20x_remove_sysfs_group(&pdev->dev); > dev_err(&pdev->dev, "Failed to add sysfs cleanup action: %d\n", > error); > return error; >