* [PATCH 1/2] drm/amdgpu: remove unneeded conversions to bool
@ 2016-07-01 14:22 Andrew F. Davis
2016-07-01 14:22 ` [PATCH 2/2] drm/amd/powerplay: " Andrew F. Davis
2016-07-04 8:31 ` [PATCH 1/2] drm/amdgpu: " Christian König
0 siblings, 2 replies; 3+ messages in thread
From: Andrew F. Davis @ 2016-07-01 14:22 UTC (permalink / raw)
To: Alex Deucher, Christian König, David Airlie
Cc: dri-devel, linux-kernel, Andrew F . Davis
Found with scripts/coccinelle/misc/boolconv.cocci.
Signed-off-by: Andrew F. Davis <afd@ti.com>
---
drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 8 ++++----
drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 4 ++--
drivers/gpu/drm/amd/amdgpu/vi.c | 14 +++++++-------
4 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
index 1a5cbaf..f3c8c37 100644
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
@@ -5144,13 +5144,13 @@ static int gfx_v8_0_set_powergating_state(void *handle,
case CHIP_POLARIS11:
if (adev->pg_flags & AMD_PG_SUPPORT_GFX_SMG)
polaris11_enable_gfx_static_mg_power_gating(adev,
- state == AMD_PG_STATE_GATE ? true : false);
+ state == AMD_PG_STATE_GATE);
else if (adev->pg_flags & AMD_PG_SUPPORT_GFX_DMG)
polaris11_enable_gfx_dynamic_mg_power_gating(adev,
- state == AMD_PG_STATE_GATE ? true : false);
+ state == AMD_PG_STATE_GATE);
else
polaris11_enable_gfx_quick_mg_power_gating(adev,
- state == AMD_PG_STATE_GATE ? true : false);
+ state == AMD_PG_STATE_GATE);
break;
default:
break;
@@ -5583,7 +5583,7 @@ static int gfx_v8_0_set_clockgating_state(void *handle,
case CHIP_CARRIZO:
case CHIP_STONEY:
gfx_v8_0_update_gfx_clock_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
break;
default:
break;
diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c
index 9945d5b..6c3c730 100644
--- a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c
@@ -1406,9 +1406,9 @@ static int gmc_v8_0_set_clockgating_state(void *handle,
switch (adev->asic_type) {
case CHIP_FIJI:
fiji_update_mc_medium_grain_clock_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
fiji_update_mc_light_sleep(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
break;
default:
break;
diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
index 532ea88..e57cab6 100644
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
@@ -1547,9 +1547,9 @@ static int sdma_v3_0_set_clockgating_state(void *handle,
case CHIP_CARRIZO:
case CHIP_STONEY:
sdma_v3_0_update_sdma_medium_grain_clock_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
sdma_v3_0_update_sdma_medium_grain_light_sleep(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
break;
default:
break;
diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c
index a65c960..d3404ef 100644
--- a/drivers/gpu/drm/amd/amdgpu/vi.c
+++ b/drivers/gpu/drm/amd/amdgpu/vi.c
@@ -1393,22 +1393,22 @@ static int vi_common_set_clockgating_state(void *handle,
switch (adev->asic_type) {
case CHIP_FIJI:
vi_update_bif_medium_grain_light_sleep(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
vi_update_hdp_medium_grain_clock_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
vi_update_hdp_light_sleep(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
vi_update_rom_medium_grain_clock_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
break;
case CHIP_CARRIZO:
case CHIP_STONEY:
vi_update_bif_medium_grain_light_sleep(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
vi_update_hdp_medium_grain_clock_gating(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
vi_update_hdp_light_sleep(adev,
- state == AMD_CG_STATE_GATE ? true : false);
+ state == AMD_CG_STATE_GATE);
break;
default:
break;
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH 2/2] drm/amd/powerplay: remove unneeded conversions to bool
2016-07-01 14:22 [PATCH 1/2] drm/amdgpu: remove unneeded conversions to bool Andrew F. Davis
@ 2016-07-01 14:22 ` Andrew F. Davis
2016-07-04 8:31 ` [PATCH 1/2] drm/amdgpu: " Christian König
1 sibling, 0 replies; 3+ messages in thread
From: Andrew F. Davis @ 2016-07-01 14:22 UTC (permalink / raw)
To: Alex Deucher, Christian König, David Airlie
Cc: dri-devel, linux-kernel, Andrew F . Davis
Found with scripts/coccinelle/misc/boolconv.cocci.
Signed-off-by: Andrew F. Davis <afd@ti.com>
---
drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 2 +-
drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
index e629f8a..e5f2596 100644
--- a/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
+++ b/drivers/gpu/drm/amd/powerplay/amd_powerplay.c
@@ -299,7 +299,7 @@ static int pp_set_powergating_state(void *handle,
/* Enable/disable GFX per cu powergating through SMU */
return hwmgr->hwmgr_func->enable_per_cu_power_gating(hwmgr,
- state == AMD_PG_STATE_GATE ? true : false);
+ state == AMD_PG_STATE_GATE);
}
static int pp_suspend(void *handle)
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c b/drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c
index efb77ed..dd8050d 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/hardwaremanager.c
@@ -147,7 +147,7 @@ int phm_enable_dynamic_state_management(struct pp_hwmgr *hwmgr)
NULL, NULL);
}
- enabled = ret == 0 ? true : false;
+ enabled = ret == 0;
cgs_notify_dpm_enabled(hwmgr->device, enabled);
--
2.9.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] drm/amdgpu: remove unneeded conversions to bool
2016-07-01 14:22 [PATCH 1/2] drm/amdgpu: remove unneeded conversions to bool Andrew F. Davis
2016-07-01 14:22 ` [PATCH 2/2] drm/amd/powerplay: " Andrew F. Davis
@ 2016-07-04 8:31 ` Christian König
1 sibling, 0 replies; 3+ messages in thread
From: Christian König @ 2016-07-04 8:31 UTC (permalink / raw)
To: Andrew F. Davis, Alex Deucher, Christian König, David Airlie
Cc: linux-kernel, dri-devel
Am 01.07.2016 um 16:22 schrieb Andrew F. Davis:
> Found with scripts/coccinelle/misc/boolconv.cocci.
>
> Signed-off-by: Andrew F. Davis <afd@ti.com>
For both patches Reviewed-by: Christian König <christian.koenig@amd.com>.
> ---
> drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c | 8 ++++----
> drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c | 4 ++--
> drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c | 4 ++--
> drivers/gpu/drm/amd/amdgpu/vi.c | 14 +++++++-------
> 4 files changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> index 1a5cbaf..f3c8c37 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
> @@ -5144,13 +5144,13 @@ static int gfx_v8_0_set_powergating_state(void *handle,
> case CHIP_POLARIS11:
> if (adev->pg_flags & AMD_PG_SUPPORT_GFX_SMG)
> polaris11_enable_gfx_static_mg_power_gating(adev,
> - state == AMD_PG_STATE_GATE ? true : false);
> + state == AMD_PG_STATE_GATE);
> else if (adev->pg_flags & AMD_PG_SUPPORT_GFX_DMG)
> polaris11_enable_gfx_dynamic_mg_power_gating(adev,
> - state == AMD_PG_STATE_GATE ? true : false);
> + state == AMD_PG_STATE_GATE);
> else
> polaris11_enable_gfx_quick_mg_power_gating(adev,
> - state == AMD_PG_STATE_GATE ? true : false);
> + state == AMD_PG_STATE_GATE);
> break;
> default:
> break;
> @@ -5583,7 +5583,7 @@ static int gfx_v8_0_set_clockgating_state(void *handle,
> case CHIP_CARRIZO:
> case CHIP_STONEY:
> gfx_v8_0_update_gfx_clock_gating(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> break;
> default:
> break;
> diff --git a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c
> index 9945d5b..6c3c730 100644
> --- a/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/gmc_v8_0.c
> @@ -1406,9 +1406,9 @@ static int gmc_v8_0_set_clockgating_state(void *handle,
> switch (adev->asic_type) {
> case CHIP_FIJI:
> fiji_update_mc_medium_grain_clock_gating(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> fiji_update_mc_light_sleep(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> break;
> default:
> break;
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> index 532ea88..e57cab6 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v3_0.c
> @@ -1547,9 +1547,9 @@ static int sdma_v3_0_set_clockgating_state(void *handle,
> case CHIP_CARRIZO:
> case CHIP_STONEY:
> sdma_v3_0_update_sdma_medium_grain_clock_gating(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> sdma_v3_0_update_sdma_medium_grain_light_sleep(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> break;
> default:
> break;
> diff --git a/drivers/gpu/drm/amd/amdgpu/vi.c b/drivers/gpu/drm/amd/amdgpu/vi.c
> index a65c960..d3404ef 100644
> --- a/drivers/gpu/drm/amd/amdgpu/vi.c
> +++ b/drivers/gpu/drm/amd/amdgpu/vi.c
> @@ -1393,22 +1393,22 @@ static int vi_common_set_clockgating_state(void *handle,
> switch (adev->asic_type) {
> case CHIP_FIJI:
> vi_update_bif_medium_grain_light_sleep(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> vi_update_hdp_medium_grain_clock_gating(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> vi_update_hdp_light_sleep(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> vi_update_rom_medium_grain_clock_gating(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> break;
> case CHIP_CARRIZO:
> case CHIP_STONEY:
> vi_update_bif_medium_grain_light_sleep(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> vi_update_hdp_medium_grain_clock_gating(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> vi_update_hdp_light_sleep(adev,
> - state == AMD_CG_STATE_GATE ? true : false);
> + state == AMD_CG_STATE_GATE);
> break;
> default:
> break;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-07-04 8:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-01 14:22 [PATCH 1/2] drm/amdgpu: remove unneeded conversions to bool Andrew F. Davis
2016-07-01 14:22 ` [PATCH 2/2] drm/amd/powerplay: " Andrew F. Davis
2016-07-04 8:31 ` [PATCH 1/2] drm/amdgpu: " Christian König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox