From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753433AbcGDJki (ORCPT ); Mon, 4 Jul 2016 05:40:38 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:13239 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753340AbcGDJkb (ORCPT ); Mon, 4 Jul 2016 05:40:31 -0400 X-AuditID: cbfec7f5-f792a6d000001302-80-577a2f0ba611 Subject: Re: [PATCH v3 1/2] clk: exynos5433: do not use CLK_IGNORE_UNUSED for SPI clocks To: Andi Shyti References: <1467270911-10971-1-git-send-email-andi.shyti@samsung.com> <1467270911-10971-2-git-send-email-andi.shyti@samsung.com> Cc: Chanwoo Choi , Jaehoon Chung , Tomasz Figa , Michael Turquette , Stephen Boyd , Kukjin Kim , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andi Shyti From: Sylwester Nawrocki Message-id: <577A2EFF.2010306@samsung.com> Date: Mon, 04 Jul 2016 11:40:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <1467270911-10971-2-git-send-email-andi.shyti@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplkeLIzCtJLcpLzFFi42I5/e/4VV1u/apwg/l/1Cy2H3nGarH4x3Mm i+tfnrNa3PjVxmrx+oWhRf/j18wWmx5fY7X42HOP1eLyrjlsFjPO72OyuHjK1eLHmW4Wi1W7 /jA68Hq8v9HK7nG5r5fJ4/qST8weO2fdZffYtKqTzWPzknqPvi2rGD0+b5IL4IjisklJzcks Sy3St0vgyjg68xBjwT2+ihd7L7M1MC7h6WLk5JAQMJE4dLCBHcIWk7hwbz1bFyMXh5DAUkaJ E2vus0M4zxklZmw+y9rFyMEhLBAl8eB4BkiDiIC6xJK9W5khapoZJf4+eMEE4jALHGGW+D5l PhNIFZuAoUTv0T5GEJtXQEti6rPfrCA2i4CqxIojx8DiogIREk/mnoSqEZT4MfkeC4jNKeAu 8ezwaTaQxcwCehL3L2qBhJkF5CU2r3nLPIFRYBaSjlkIVbOQVC1gZF7FKJpamlxQnJSea6RX nJhbXJqXrpecn7uJERI5X3cwLj1mdYhRgINRiYeXIaYyXIg1say4MvcQowQHs5IIr612VbgQ b0piZVVqUX58UWlOavEhRmkOFiVx3pm73ocICaQnlqRmp6YWpBbBZJk4OKUaGCcpHu6JTbvV 9+8L54vne2561nHp7Kl+EXsobMEE5Y2aWrsnTuFiC+05XPDEdWt3/rkzS6M3zJBXe6J0fd3G DlefFXqGN8/8X+MXH+igvPq+T5lDCMPSVUxNVrP3dBQyFG4vkYvQs93hPVc1PVhB1Dygz0U7 pl63t3Xt3P6jE1IOLjTiOST7TomlOCPRUIu5qDgRAJO3A8yYAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/30/2016 09:15 AM, Andi Shyti wrote: > The CLK_IGNORE_UNUSED flag has to be avoided whenever possible. In general I would rather disagree. > Use the CLK_IS_CRITICAL flag instead for critical SPI1 clocks, > which enables the clock line during boot time. > > Suggested-by: Tomasz Figa > Signed-off-by: Andi Shyti > --- > drivers/clk/samsung/clk-exynos5433.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c > index c3a5318..1f7c4951 100644 > --- a/drivers/clk/samsung/clk-exynos5433.c > +++ b/drivers/clk/samsung/clk-exynos5433.c > @@ -1662,7 +1662,7 @@ static struct samsung_gate_clock peric_gate_clks[] __initdata = { > @@ -1677,7 +1677,7 @@ static struct samsung_gate_clock peric_gate_clks[] __initdata = { > GATE(CLK_SCLK_SPI2, "sclk_spi2", "sclk_spi2_peric", ENABLE_SCLK_PERIC, > 5, CLK_SET_RATE_PARENT, 0), > GATE(CLK_SCLK_SPI1, "sclk_spi1", "sclk_spi1_peric", ENABLE_SCLK_PERIC, > - 4, CLK_IGNORE_UNUSED | CLK_SET_RATE_PARENT, 0), > + 4, CLK_IS_CRITICAL | CLK_SET_RATE_PARENT, 0), As Tomasz pointed out, this should be addressed in the driver/dts, we shouldn't be patching board configurations into a per-SoC driver. Other boards may want to keep this clock disabled. What is an exact problem here, are you perhaps testing suspend to RAM? I tested my sound support patches on top of v4.7-rc1 and everything seemed to work well, I didn't notice any issues with the audio codec which was the only slave on the SPI 1 bus. Doesn't it help when you specify CLK_SCLK_SPI1 as the second clock ("spi_busclk0") of the spi_1 bus controller instead of CLK_SCLK_SPI0_PERIC? CLK_SCLK_SPI0_PERIC seem to be parent of CLK_SCLK_SPI1 so the enable state would be propagated.