From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753534AbcGDK5i (ORCPT ); Mon, 4 Jul 2016 06:57:38 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:52683 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753251AbcGDK5d (ORCPT ); Mon, 4 Jul 2016 06:57:33 -0400 Subject: Re: [PATCH] phy: rockhip-usb: use devm_add_action_or_reset() To: Heiko Stuebner , Sudip Mukherjee References: <1467579666-9179-1-git-send-email-sudipm.mukherjee@gmail.com> <2045236.FJVOO9eQKE@phil> CC: , , From: Kishon Vijay Abraham I Message-ID: <577A40FA.5080005@ti.com> Date: Mon, 4 Jul 2016 16:26:58 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: <2045236.FJVOO9eQKE@phil> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday 04 July 2016 03:04 AM, Heiko Stuebner wrote: > Am Sonntag, 3. Juli 2016, 22:01:06 schrieb Sudip Mukherjee: >> If devm_add_action() fails we are explicitly calling the cleanup to free >> the resources allocated. Lets use the helper devm_add_action_or_reset() >> and return directly in case of error, as we know that the cleanup function >> has been already called by the helper if there was any error. >> >> Signed-off-by: Sudip Mukherjee > > a nice new helper this devm_add_action_or_reset. > > Reviewed-by: Heiko Stuebner applied, thanks. -Kishon