From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753434AbcGDQMj (ORCPT ); Mon, 4 Jul 2016 12:12:39 -0400 Received: from merlin.infradead.org ([205.233.59.134]:60187 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751294AbcGDQMe (ORCPT ); Mon, 4 Jul 2016 12:12:34 -0400 Subject: Re: linux-next: Tree for Jun 27 (pinctrl && !CONFIG_OF) To: Linus Walleij References: <20160627163939.20e454d5@canb.auug.org.au> <57716D3D.4070302@infradead.org> Cc: Stephen Rothwell , "linux-next@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , Arnd Bergmann , Linus Torvalds From: Randy Dunlap Message-ID: <577A8AE9.3010807@infradead.org> Date: Mon, 4 Jul 2016 09:12:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/04/16 02:46, Linus Walleij wrote: > On Mon, Jun 27, 2016 at 8:15 PM, Randy Dunlap wrote: > >> On 06/26/16 23:39, Stephen Rothwell wrote: >>> Hi all, >>> >>> Changes since 20160624: >>> >> >> on i386, when CONFIG_OF is not enabled ... >> but OF_GPIO is enabled due to this in drivers/gpio/Kconfig: >> >> config OF_GPIO >> def_bool y >> depends on OF || COMPILE_TEST >> >> (above from commit 1e4a80640338924b9f9fd7a121ac31d08134410a >> from Alexander Stein ) >> >> >> ../drivers/pinctrl/bcm/pinctrl-iproc-gpio.c:381:20: error: 'pinconf_generic_dt_node_to_map_pin' undeclared here (not in a function) >> ../drivers/pinctrl/bcm/pinctrl-cygnus-mux.c:739:20: error: 'pinconf_generic_dt_node_to_map_group' undeclared here (not in a function) >> ../drivers/pinctrl/bcm/pinctrl-nsp-gpio.c:365:20: error: 'pinconf_generic_dt_node_to_map_pin' undeclared here (not in a function) >> >> because that function is only present when CONFIG_OF is enabled. >> >> >> Also, why does that commit (1e4a80640338924b9f9fd7a121ac31d08134410a) >> not have any other S-O-B lines in it? like whoever merged it? > > I merged it I think, Alex made a long series enabling compile > testing and I started to cherry-pick the first commits to let > them trickle in. I guess that when you do a git pull of a series of patches, you sign the pull commit but not each patch in the series? That could explain it. > I was worried about it because some of the patches caused > severe build problems on some archs. > > It's a bit tricky to know what to do here: we want compile > coverage to get proper testing, when we turn it on we get regressions, > so trying to improve things make things break and it becomes a > vicious circle of trouble. I don't know what the biggest pain is ... > > I don't really see the conclusion of this discussion thread, whether > I should revert the patch or not? For fixes or next? I agree with Arnd that this particular commit should be reverted (1e4a80640338924b9f9fd7a121ac31d08134410a). -- ~Randy