From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753989AbcGEAoI (ORCPT ); Mon, 4 Jul 2016 20:44:08 -0400 Received: from regular1.263xmail.com ([211.150.99.138]:41897 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751636AbcGEAoF (ORCPT ); Mon, 4 Jul 2016 20:44:05 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: wxt@rock-chips.com X-FST-TO: heiko@sntech.de X-SENDER-IP: 103.29.142.67 X-LOGIN-NAME: wxt@rock-chips.com X-UNIQUE-TAG: X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Message-ID: <577B02D3.3050608@rock-chips.com> Date: Tue, 05 Jul 2016 08:44:03 +0800 From: Caesar Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.4.0 MIME-Version: 1.0 To: Heiko Stuebner CC: Caesar Wang , huangtao@rock-chips.com, devicetree@vger.kernel.org, Elaine Zhang , dianders@chromium.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, eddie.cai@rock-chips.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3] arm64: dts: rockchip: add the power domain node for rk3399 References: <1467635644-16798-1-git-send-email-wxt@rock-chips.com> <1904131.irFlfKsH8m@phil> In-Reply-To: <1904131.irFlfKsH8m@phil> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2016年07月05日 08:24, Heiko Stuebner 写道: > Am Montag, 4. Juli 2016, 20:34:04 schrieb Caesar Wang: >> From: Elaine Zhang >> >> In order to meet low power requirements, a power management unit (PMU) is >> designed for controlling power resources in RK3399. The RK3399 PMU is >> dedicated for managing the power of the whole chip. >> >> 1. add pd node for RK3399 Soc >> 2. create power domain tree >> 3. add qos node for domain >> >> From the DT/binds and driver can get more detail information: >> The driver: >> drivers/soc/rockchip/pm_domains.c >> The document: >> Documentation/devicetree/bindings/soc/rockchip/power_domain.txt >> >> Note: >> As the TRM lists many voltage domains and power domains, then this patch >> adds some domains for driver. Due to some domains >> (e.g. emmc, usb, core)...We can't turned off it on >> bootup, or says some device driver can't handle the power domain enough. >> Maybe We will add more other domains in the future or later. > I talked with Caesar about that today and for example the gmac domain seems > to cause problems right now when only using the generic power-domain > handling the kernel provides on probe and remove. > > So while this gets investigated, I'm probably ok with only using the stable > power-domains, but will give the us-people a chance to also respond on > wednesday :-) . > > >> Signed-off-by: Elaine Zhang >> Signed-off-by: Caesar Wang >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: linux-rockchip@lists.infradead.org >> Cc: Heiko Stuebner >> >> --- >> >> Changes in v3: >> - As some commnets on https://patchwork.kernel.org/patch/9209205/ >> - according to the alphabetically sort >> - %s/RK3399_PD_VOP/RK3399_PD_VOPL, %s/RK3399_PD_IE/RK3399_PD_IEP >> >> Changes in v2: >> - As Doug/Heiko commnets on https://patchwork.kernel.org/patch/9206415/. >> drop the debugfs-dump and Add the comments for alphabetical order. >> >> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 179 >> +++++++++++++++++++++++++++++++ 1 file changed, 179 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> b/arch/arm64/boot/dts/rockchip/rk3399.dtsi index a6dd623..4559c04 100644 >> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi >> @@ -45,6 +45,7 @@ >> #include >> #include >> #include >> +#include >> #include >> >> / { >> @@ -594,6 +595,184 @@ >> status = "disabled"; >> }; >> >> + qos_hdcp: qos_hdcp@ffa90000 { > I guess I'll just rename that to qos_hdcp: qos@ffa90000 > (similar for the other nodes), as the block itself is the same for all qos > instances. So if that stays the only comment, there is no need to resend, as > I can do the change myself. Yep, that's better. Thanks. -Caesar > >> + compatible = "syscon"; >> + reg = <0x0 0xffa90000 0x0 0x20>; >> + }; > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip -- caesar wang | software engineer | wxt@rock-chip.com