From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932556AbcGEEaL (ORCPT ); Tue, 5 Jul 2016 00:30:11 -0400 Received: from mail-oi0-f65.google.com ([209.85.218.65]:33970 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750774AbcGEEaI (ORCPT ); Tue, 5 Jul 2016 00:30:08 -0400 Subject: Re: [PATCH 2/2] net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings To: David Miller , tremyfr@gmail.com References: <1467560037-21784-1-git-send-email-tremyfr@gmail.com> <1467560037-21784-2-git-send-email-tremyfr@gmail.com> <20160704.160300.953705748553101659.davem@davemloft.net> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Florian Fainelli Message-ID: <577B37CC.80807@gmail.com> Date: Mon, 4 Jul 2016 21:30:04 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160704.160300.953705748553101659.davem@davemloft.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 04/07/2016 16:03, David Miller a écrit : > From: Philippe Reynes > Date: Sun, 3 Jul 2016 17:33:57 +0200 > >> There are two generics functions phy_ethtool_{get|set}_link_ksettings, >> so we can use them instead of defining the same code in the driver. >> >> Signed-off-by: Philippe Reynes > > Applied. > The transformation is not equivalent, we lost the checks on netif_running() in the process, and those are here for a reason, if the interface is down and therefore clock gated, MDIO accesses to the PHY will simply fail outright and cause bus errors. Philippe, have you tested this? -- Florian