From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754545AbcGEHSL (ORCPT ); Tue, 5 Jul 2016 03:18:11 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:44332 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751251AbcGEHSG (ORCPT ); Tue, 5 Jul 2016 03:18:06 -0400 X-AuditID: cbfec7f5-f792a6d000001302-d5-577b5f2a74c2 Subject: Re: [RFC PATCH 1/2] rtc: s3c: Remove unnecessary call to disable already disabled clock To: Alim Akhtar , rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org References: <1467630195-6929-1-git-send-email-alim.akhtar@samsung.com> Cc: alexandre.belloni@free-electrons.com, javier@osg.samsung.com, pankaj.dubey@samsung.com From: Krzysztof Kozlowski Message-id: <577B5F28.1010905@samsung.com> Date: Tue, 05 Jul 2016 09:18:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1467630195-6929-1-git-send-email-alim.akhtar@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrCLMWRmVeSWpSXmKPExsVy+t/xy7pa8dXhBn1vTSw6ri1msngwbxub xZu3a5gsXr8wtLi8aw6bxaKtX9gt9nd2MDqwezzZdJHRY8/Ek2weW/rvsnv0bVnF6PF5k1wA axSXTUpqTmZZapG+XQJXRtvO6YwFV9grvp1LbGCcwtbFyMkhIWAisehIExOELSZx4d56sLiQ wFJGid/fFLsYuYDsZ4wSJxrawIqEBZIkDm+5xdLFyMEhIpAq0fLUEMQUEnCT6J0RDlLBLBAj cWnDGmYQm03AWGLz8iVsICW8AloSN7aGgIRZBFQlzm0/DrZJVCBCYtb2H2DDeQUEJX5MvscC YnMKuEt8+98N1sosoCdx/6IWxHR5ic1r3jJPYBSYhaRjFkLVLCRVCxiZVzGKppYmFxQnpeca 6RUn5haX5qXrJefnbmKEhPXXHYxLj1kdYhTgYFTi4S2YXxUuxJpYVlyZe4hRgoNZSYT3Y0x1 uBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHembvehwgJpCeWpGanphakFsFkmTg4pRoYTwo5e5X8 uaYu8sYm5HmXiNdctfLpa3vtlihdVE1tuM2TU2Xf7f2x8dXSXRc/GEanltRN2jxxVuk7mbmb E8+qHFTPfigjrJqof+5sQ03HhWreHY7OjPq1tlfdDX+IbFi/tCFBLap70RbuwpR73CGBXy9s fLJhwa8T7cbcgU/MD7KoFC/3qfZXYinOSDTUYi4qTgQAJcj0MWcCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/04/2016 01:03 PM, Alim Akhtar wrote: > At the end of s3c_rtc_probe(), s3c_rtc_disable_clk() being called with rtc > clock already disabled, which looks extra and unnecessary call. > Lets clean it up. Does not look right. Till that place, the clocks are enabled. Then s3c_rtc_setaie() is called which expects that clocks are disabled... otherwise counters get mixed. So overall this looks like wrong approach unless I am missing something? Best regards, Krzysztof > > Signed-off-by: Alim Akhtar > --- > drivers/rtc/rtc-s3c.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/rtc/rtc-s3c.c b/drivers/rtc/rtc-s3c.c > index d01ad7e..b083840 100644 > --- a/drivers/rtc/rtc-s3c.c > +++ b/drivers/rtc/rtc-s3c.c > @@ -577,8 +577,6 @@ static int s3c_rtc_probe(struct platform_device *pdev) > > s3c_rtc_setfreq(info, 1); > > - s3c_rtc_disable_clk(info); > - > return 0; > > err_nortc: