From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754506AbcGEJEz (ORCPT ); Tue, 5 Jul 2016 05:04:55 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:51232 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751248AbcGEJEw (ORCPT ); Tue, 5 Jul 2016 05:04:52 -0400 X-AuditID: cbfec7f5-f792a6d000001302-53-577b7830e027 Subject: Re: [PATCH 06/10] clk: samsung make clk-exynos-audss explicitly non-modular To: Paul Gortmaker , linux-kernel@vger.kernel.org References: <20160704211220.5685-1-paul.gortmaker@windriver.com> <20160704211220.5685-7-paul.gortmaker@windriver.com> Cc: Sylwester Nawrocki , Tomasz Figa , Michael Turquette , Stephen Boyd , Kukjin Kim , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org From: Krzysztof Kozlowski Message-id: <577B782E.9090203@samsung.com> Date: Tue, 05 Jul 2016 11:04:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <20160704211220.5685-7-paul.gortmaker@windriver.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHLMWRmVeSWpSXmKPExsVy+t/xa7oGFdXhBpdmyFi8fmFo0f/4NbPF x557rBaXd81hs5hxfh+TxcVTrhbX9h5ntjj8pp3V4seZbhaLVbv+MDpweby/0crucbmvl8lj 56y77B6bVnWyefRtWcXo8XmTnMf6LVuZAtijuGxSUnMyy1KL9O0SuDL2vTnDXLBHtOLu+Z9s DYwThLoYOTkkBEwkXm1bygxhi0lcuLeerYuRi0NIYCmjxIfmG2wgCSGBZ4wSd7/EgtjCAmES FxZ/YAWxRQT8JbZvWMPexcgBVFMucfK1OUiYWaCbSeLk1hgQm03AWGLz8iVgY3gFtCR+L3gD Vs4ioCrRuYwRJCwqECExa/sPJogSQYkfk++xgNicAo4Sv9ub2EDKmQX0JO5f1IKYLi+xec1b 5gmMArOQdMxCqJqFpGoBI/MqRtHU0uSC4qT0XCO94sTc4tK8dL3k/NxNjJBY+LqDcekxq0OM AhyMSjy8BfOrwoVYE8uKK3MPMUpwMCuJ8B4urg4X4k1JrKxKLcqPLyrNSS0+xCjNwaIkzjtz 1/sQIYH0xJLU7NTUgtQimCwTB6dUA2Nfv9LzBrG8z7v9Axf6zZYM/m/hlbbokt0f3l/y833U +ZU9bMR3X3KV9xE3vaho38EhpFxqyvBj/8sAJwb55xzNv2aGfHu8Pe4c97+SV+9Ozfl9NDHi edvKqD32nw9f23hH49SUqw7Xu3o0L+uXK26yE/p6iH9N2o7ZVeLxB48/Wu+/fn77v0IlluKM REMt5qLiRAD8egsugQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/04/2016 11:12 PM, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > arch/arm/mach-exynos/Kconfig:menuconfig ARCH_EXYNOS > arch/arm/mach-exynos/Kconfig: bool "Samsung EXYNOS" if ARCH_MULTI_V7 > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the couple traces of modularity so that when reading the > driver there is no doubt it is builtin-only. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_init was already not used by this code, the init ordering > remains unchanged with this commit. > > We also delete the MODULE_LICENSE tags etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Sylwester Nawrocki > Cc: Tomasz Figa > Cc: Michael Turquette > Cc: Stephen Boyd > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Padmavathi Venna > Cc: linux-samsung-soc@vger.kernel.org > Cc: linux-clk@vger.kernel.org > Signed-off-by: Paul Gortmaker > --- > drivers/clk/samsung/clk-exynos-audss.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/drivers/clk/samsung/clk-exynos-audss.c b/drivers/clk/samsung/clk-exynos-audss.c > index 4e9584d79089..42b62f865198 100644 > --- a/drivers/clk/samsung/clk-exynos-audss.c > +++ b/drivers/clk/samsung/clk-exynos-audss.c > @@ -15,7 +15,7 @@ > #include > #include > #include > -#include > +#include > #include > > #include > @@ -278,14 +278,3 @@ static int __init exynos_audss_clk_init(void) > return platform_driver_register(&exynos_audss_clk_driver); > } > core_initcall(exynos_audss_clk_init); > - > -static void __exit exynos_audss_clk_exit(void) > -{ > - platform_driver_unregister(&exynos_audss_clk_driver); > -} > -module_exit(exynos_audss_clk_exit); > - > -MODULE_AUTHOR("Padmavathi Venna "); > -MODULE_DESCRIPTION("Exynos Audio Subsystem Clock Controller"); > -MODULE_LICENSE("GPL v2"); > -MODULE_ALIAS("platform:exynos-audss-clk"); Why not removing .remove() callback as well? I don't find sysfs unbind hook useful except testing the exit paths... which in that case do not exist anymore (there is no "modprobe -r" for it anyway). Best regards, Krzysztof