From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755189AbcGEOBs (ORCPT ); Tue, 5 Jul 2016 10:01:48 -0400 Received: from mail-sn1nam02on0047.outbound.protection.outlook.com ([104.47.36.47]:7440 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752103AbcGEOAr (ORCPT ); Tue, 5 Jul 2016 10:00:47 -0400 X-Greylist: delayed 3612 seconds by postgrey-1.27 at vger.kernel.org; Tue, 05 Jul 2016 10:00:47 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [PATCH v3 1/4] dma-buf/fence-array: add fence_is_array() To: Gustavo Padovan , References: <1467676628-4121-1-git-send-email-gustavo@padovan.org> <1467676628-4121-2-git-send-email-gustavo@padovan.org> CC: , Daniel Stone , Daniel Vetter , Rob Clark , "Greg Hackmann" , John Harrison , , , , , Sumit Semwal , Maarten Lankhorst , Gustavo Padovan , Chris Wilson From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <577BA77D.2020504@amd.com> Date: Tue, 5 Jul 2016 14:26:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1467676628-4121-2-git-send-email-gustavo@padovan.org> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1251:a381:5482:5f4b:9ba2:6d7c] X-ClientProxiedBy: VI1PR06CA0004.eurprd06.prod.outlook.com (10.162.116.142) To BN3PR1201MB0915.namprd12.prod.outlook.com (10.165.76.15) X-MS-Office365-Filtering-Correlation-Id: 0e31e905-d055-4a92-dd50-08d3a4cfa593 X-Microsoft-Exchange-Diagnostics: 1;BN3PR1201MB0915;2:hNED6jdS2Fd6+XC/GptSb/dROii/EKOwDL5qk+sFfilB675g/5FH5PHfkXvMCzqJOp5q/beU9zwqmwaEQ7ryJ+C7C6F+ihIznzuvfXOmGVwnLBSrwlVMAbiLhs5wbvmrcbwiX0DtATpZddexvIUAEL8VAhQArY37ILt64PId+dS/qVr0vjzJIluh0GygSPEn;3:ebZ73eZFTrs2vY2IiFMne9zLJG5UXc5BxQdhJZGHMbtJQQfozMhPZaXQG8rbvDa1C1oDEQ9SyhtbZkxJBNAXbvctRsbED50yMzHvo90VNaYnvBDvu/qzMlLF8UScOoxb;25:4EjeNjfb4EO+SSw2oSxTBGHU1z2j/MuI0pSPyCTpDvT24LgydjnFQ3OR5OXGeXSw8Wi2WlXv1mOsoMlyL9gABXZ48or9PGCIXht0EJ1wN+TXhkEl+fy5UXJ6Eh2X7erVmncegIIaX/It7glIrvfNChLV/HTep0qQwnmYlWP/XZ1Wjntv0GTbV8VopakWjclSFDwn9saGME92rtjzTwDqrTgKEE3bc4gFpD6h59bc8dIUSkhpphGkFSuhHmtpLSmpawc+ImRSWD6JKTOQyJeNIeEW8uWvqipogZu9H7eNyha1m4cxsPkQLA6ePC691CSxtP+obBs34EAc5s64/XCVrugXlgqum+0tJt4IQffTVds7PIl/hL4eCUaw2X2SswmhrgNg4TKXiwlgZPERRSbymFwmoKoGnsdDL59WCJ4djRE= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR1201MB0915; X-Microsoft-Exchange-Diagnostics: 1;BN3PR1201MB0915;31:yRz18fRkdJQLNQh0LzI8T5RCHrf2NJeId+dKvmtV1+CrmYU9A5zT12GXIDTAjdWCPjO99arz1Ls30Ddp4r1RMw4Q7NNHOnw4QPAEPV60VrepncNIZe5pYDgnsQ0jCrFinUgv5EL3otXUoR6PwnkSTdd4jh79rg9T3peo1JibEKavZWH3FdWKhQdRD4fh6lQF/ku1ACc+n6nQB7UWW3HlzA==;20:oLPPRUr3h7JhBo56y6bHzqMt2Ea4rQxQWArxafQFd9q+OwBgqcx7v5hXuY0rw9ugNpYx8+y2nqDrPmtRQDlN91Sc0HGpWy5hMjOPWiZ3rpjM1e7JlPHLwJExGtYw/zNdD7D+llTH6d0OjDv5aLMLmXUgcubnqbw5kenXCPL8vFq6USueQEzsf0Hh6REI+3nP20bdMMYYui0zkzc4CbKyJ+9dz3IeJQAoLAb3h+QaKalwvRtib13ztUHaUEpKDxFPULcOWFf/p1dU9FScMKjJwHO2+Bp4MiUOoAhX/LJlKKrhIWOLdVzJtsd0ySx6pSPYHyH2sUkGAJ06/qwLeSEAVti4DaxI6xuaeu7BzbpLuuYnufnKPpk3Y9KwhrGy7EfpVaYz/wdWUX73dYChVQn1E2o8Z9TIxwGyiPIFwvi/3Cf/DDK3dUCTpmnRoY3m25ZnWywIt6dZgF0Y0tljLKnoVLxulBC3GHzAGAPr+BFbX5+YrYuKIgmrKmN99Mf3BRZR X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(767451399110); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:BN3PR1201MB0915;BCL:0;PCL:0;RULEID:;SRVR:BN3PR1201MB0915; X-Microsoft-Exchange-Diagnostics: 1;BN3PR1201MB0915;4:AIYlfEecdJN/OoZz0FXfpARnKO1lrY06MKF8x816KKCgP7JE67hwE/ZbgyjbG3c8iR2uh8mq3IGkyCReWG8v95gIu2a11VAKmTVVQ6cvbFH72Kg3lccvWQTzTsQpyGgjuchrnst2yOVnOcg6g6ocdS3gl8M+PlXOpCf32fkngbAkEnD5xTlSn2bwqXiJNbHpq2+L/jitUeYEg3WI3nrEBYqe5IIGWAvRFo95nMN0MeWLNoXIF8ChZvOL8Hoz71r2i9FAxt9IS9ezDcquNvJv9Gob+FWHaSES3OSNXRBCzZbvsv4Vf8G5bAx0+mCbFtxFO2y0MtjWRZuDpcstpNDOuuk5MD0yp4e6fc5KHU/uP6Hgz3tf/imigRjZXGNtc0qizBqASXXoBTTh+fgy8l86WYcwlURZP1bMtTv7T2oLPk8= X-Forefront-PRVS: 0994F5E0C5 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(189002)(199003)(189998001)(65806001)(105586002)(65956001)(50466002)(6116002)(81156014)(586003)(81166006)(47776003)(77096005)(92566002)(305945005)(83506001)(2950100001)(8676002)(106356001)(7736002)(68736007)(7846002)(101416001)(33656002)(64126003)(97736004)(59896002)(2906002)(4326007)(4001350100001)(5001770100001)(36756003)(87266999)(50986999)(23676002)(76176999)(54356999)(65816999)(2870700001)(42186005)(19580405001)(19580395003)(80316001)(1706002)(86362001)(3826002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR1201MB0915;H:[IPv6:2a02:908:1251:a381:5482:5f4b:9ba2:6d7c];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjNQUjEyMDFNQjA5MTU7MjM6eWZkQWN6THRxaTNKU1BwUkNQNzljZzd6?= =?utf-8?B?MW1iOWZNM1J2eFRYZ1JxWmZqeU9nNldiRjdrNVVhNjFiV0dXczVKWXB6Z2JX?= =?utf-8?B?ZytuRllXcm5kdkxuTUYweUF5b2wxNlpqYTk4aitEb3dXc0VONTNPUHlDeVFT?= =?utf-8?B?MytFeVE2REFXc3lQWnN5U2ErNHAxc2VTaENTNmR6VUNpRDhBOE5YSmpCUDM5?= =?utf-8?B?UVE3aSthdzBUZVRsME1GTE12bWwvNFFOMzJ0ZSt1T3F5cmNDc2JIbzVkbENT?= =?utf-8?B?NVhEVzZqLzFPbldDcEE0VmNlNGl6Y3pPWW05NHZnMmZtZ2VtSm50a1Zta1ZB?= =?utf-8?B?NmJiYmxudUMxaHZ0ZUdhdS8yekRFUTF2THNoY01hem9xVzZWVzJ2ZGJaeVE2?= =?utf-8?B?aGhTVEhrRkdSNk5qVjFqZXFuQ0wwQVREZ1c3cTRicjZldHZGOUx0cVN1aTJD?= =?utf-8?B?MjBjNHcyQUd0KzJMbGRKeGJMbmZVcC9NNXdJTkN3OHhtTm5IMWZ4MVhLZWR2?= =?utf-8?B?aDJCUDE2d21YbHFpdnRYZnFIWUN6YmNBY0FBNlFPZ2FLYXFOU1RqY2RIS2Mw?= =?utf-8?B?OXZITGdXblFXaGJiK2Z0cDAvK2pzdGt3SW94c3l4MGdBcDIrZkUzM0EzYjg3?= =?utf-8?B?TCtxRHBKSXZEbC9iNFVXN3V2bUdFd3BieGZrajhNTm5DSGJ5OUd0VVVkZ1JB?= =?utf-8?B?L2FTTlM2UTZ3MmRSUlAzVExlQXpIY050WStMaWFoY0NrTUZZZnA2YjBFVjZD?= =?utf-8?B?dE1FN0hNUkpoNXdpdU01dE5jVTVYVWVVV0Z2TkNjM3JPeklVRG4zcWoweitp?= =?utf-8?B?YS9zUXhOZXdWZzhqcVFSclJ3NFRVSXRtMDBBVFROR2VlREkwRkhidjMzRzFw?= =?utf-8?B?YzVEUE1RRXZMK2Z3M1dZdnpQdGhkaGRzZGUvNi9RbElGUmd3emEwSzkzTTU5?= =?utf-8?B?bDQzZ2s5d2NWNExoVWFuSFhRSGMzV1RkY2h0ZzVKQk02NHZWMkpTT0x6TFJP?= =?utf-8?B?ZmFYVUdMVER2VjI3SW5mNmE1Zmpzbll5QVRSM0F1Q1NldFBxOWpRUHFWLzdK?= =?utf-8?B?V1FhK2Q1b3dUeEJMOVhucGNicXIva2lZMWpBR2NYaHgreXRHZ2hPZngvbWg1?= =?utf-8?B?dlM5bk5BOXhMdFBEN2lhdGtQdDBGZkZQNzRjOTNUUTZiQTVhYzBMU1lJSFRN?= =?utf-8?B?aFlsY0xPeUlqeUloNDUzQU5WeU9Na2RndFQya1QwWVF1Z0VkTHNZNEFTMUd6?= =?utf-8?B?MG9YNEdGSjVwQXBsSEFSOHZyNllrRTljQ2NjUmIvT1cyU3RsMEsrM0tBUElE?= =?utf-8?B?QXFNWGt0R2xJOXF5NFVoQyt2QjlqRzlnN0VOTE5nNG5lck1KbTBNT3pLSlYr?= =?utf-8?B?bVB2VlBhcnp2OVVXOGJaMmhaS1Q3bHhwbXdJdFM2ZmswNVl1WFM3MWp3ZWhr?= =?utf-8?B?c2RiSEVQWDJTTjdGdFJndW05K3V6NTAyd2c0bFhDV0ppaXB1NkdkYkoxY0hD?= =?utf-8?B?N1dlY1ZKZGMrTDFwU084MHR5Q2pDY0JYanBaRUNBTkpLSUFCenlMYktCZ2Ra?= =?utf-8?B?a2JpdlBBcWZURXFvTkhodzZhZDhWalFoeUdVNE1CSkZ6alhrejdHY3FyWE9n?= =?utf-8?B?emdCVkJEK3E5MnY4VFE3SlFuOTZDV0VUM0JBTGM1N0V0U3ZubFVwZWd5N3c9?= =?utf-8?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR1201MB0915;6:4LP5+G0qn63p/RD6lra2TaZofE3jgwj/ozVxphXeG+rR3FIRKK6wjYbdkOxLnpOTqlJo0ibP3BEJ0UMhjE11fRln8IWdn36IMPn7Sq862nTebuOjnwuZBm11CzeKlcf5OcF4X6cS8t8kEXDHoYc3/P7e6qxGffILhYafeZFIhOpYUSh5xiwfGc0HxlkDV+mxOPFiQIwTrwq7IHrubiswQM8yjW/qBwjvp/VrbQovXwU/egADujhzn5lvVO97mtWmuDIZy/FVj0s2GTSbLqf33molY7CX6juvzRZDvjAzmApKQWcbrLDe/Xr+C5fnsziW8SdLv/KiYprXhbcsT/OTZg==;5:5/XeqjkjH+ol10BG9WccuyLaVus3v6B6IE8/YOrRpkW/kcx9bvj2bwLiF8GJ1vLeaPwAmaQ4LonHGJR0hFlNfNz3v0T6mlwVBxEamGzp9P8RsDhU+/o/HVM8f+9/v6/33dO/xUm6HW0T5jwxdzmPJA==;24:hYlSMCXcddpTgT8vXJ/nLPKqpcxb3J9U8fyZER865jLxTB+PwmN9RFQEBjEtfvTdA6kStWpxijooBvXutMJB7VPCMmy2NW5mTwKIFkajs1E=;7:LT5qg7QZK+ygQz8LQ1a5CKAvrLPQuWN0i4AD3ChgSOhQyeL4tIfEl9yo5UNKrk+RrU3OUEiR10sd2lEnUHkX6Y5PZMvwg96aL4NUomGWZF2J/ks+87E6nmxuAmzb70DkJAB0owQRJEtWkInQaa79vgqX/m9FZ4y/VkXniZqnV21vhQuZGeVu52j7O+6LyBBU1HawJo1DXBkGuHxfB/S5B75ljU7n58gMBJDSvG7DAevxpxXMvYdaj86VfIynDCJ1 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN3PR1201MB0915;20:+aQvVj1hzwwmNOtpV0MId9UTPOBkGwGCbF9cGLsiXJWUmZdUi1uMMwYOWebKnix1e9E0OAurOX2e55qi9CtJUB1/H9xmTWe6nEJ4X+ZeCqyuo2Qx/rHorzjRtPqrRCS6oOOLB2UfjzIsIQw1Bc+CYrgzM0Sm4HbKu0ptMjFguwTnw+wXSFPVy/c213H1Zqj9wh2rVSUKcxRorFSXaN3C7Sk2i1Z49OQIC2iWtgeH3vcpUbLL/d6J3W8e+J9mtJoN X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2016 12:26:50.8288 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR1201MB0915 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 05.07.2016 um 01:57 schrieb Gustavo Padovan: > From: Gustavo Padovan > > Add helper to check if fence is array. > > v2: Comments from Chris Wilson > - remove ternary if from ops comparison > - add EXPORT_SYMBOL(fence_array_ops) > > Cc: Chris Wilson > Cc: Christian König > Signed-off-by: Gustavo Padovan > Reviewed-by: Chris Wilson For this patch Reviewed-by: Christian König . I'm not deep enough into the sync file code to fully judge, but the remaining patches look good to me as well. So for patch #2-#4 Acked-by: Christian König . Regards, Christian. > --- > drivers/dma-buf/fence-array.c | 1 + > include/linux/fence-array.h | 10 ++++++++++ > 2 files changed, 11 insertions(+) > > diff --git a/drivers/dma-buf/fence-array.c b/drivers/dma-buf/fence-array.c > index a8731c8..ee50022 100644 > --- a/drivers/dma-buf/fence-array.c > +++ b/drivers/dma-buf/fence-array.c > @@ -99,6 +99,7 @@ const struct fence_ops fence_array_ops = { > .wait = fence_default_wait, > .release = fence_array_release, > }; > +EXPORT_SYMBOL(fence_array_ops); > > /** > * fence_array_create - Create a custom fence array > diff --git a/include/linux/fence-array.h b/include/linux/fence-array.h > index 86baaa4..a44794e 100644 > --- a/include/linux/fence-array.h > +++ b/include/linux/fence-array.h > @@ -52,6 +52,16 @@ struct fence_array { > extern const struct fence_ops fence_array_ops; > > /** > + * fence_is_array - check if a fence is from the array subsclass > + * > + * Return true if it is a fence_array and false otherwise. > + */ > +static inline bool fence_is_array(struct fence *fence) > +{ > + return fence->ops == &fence_array_ops; > +} > + > +/** > * to_fence_array - cast a fence to a fence_array > * @fence: fence to cast to a fence_array > *