From: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org,
Sasha Levin <sasha.levin@oracle.com>,
Yao Dongdong <yaodongdong@huawei.com>
Subject: Re: [PATCH] sched/core: really pretend early bootup to be a normal task
Date: Tue, 5 Jul 2016 15:47:47 +0300 [thread overview]
Message-ID: <577BAC73.1080403@yandex-team.ru> (raw)
In-Reply-To: <20160705124129.GB30921@twins.programming.kicks-ass.net>
On 05.07.2016 15:41, Peter Zijlstra wrote:
> On Tue, Jul 05, 2016 at 02:23:23PM +0300, Konstantin Khlebnikov wrote:
>> Commit 1b537c7d1e58 ("sched/core: Remove check of p->sched_class") placed
>> "current->sched_class = &fair_sched_class" before call of init_idle() which
>> immediately set sched_class back to idle_sched_class.
>>
>> This patch reverts this piece because after commit de9b8f5dcbd9 ("sched:
>> Fix crash trying to dequeue/enqueue the idle thread") init_idle() doesn't
>> call do_set_cpus_allowed() and nobody will dereference ->sched_class.
>
> I don't understand, what is broken?
>
"pretending" hack is broken. As I wrote maybe it is not needed any more.
--
Konstantin
prev parent reply other threads:[~2016-07-05 12:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 11:23 [PATCH] sched/core: really pretend early bootup to be a normal task Konstantin Khlebnikov
2016-07-05 12:41 ` Peter Zijlstra
2016-07-05 12:47 ` Konstantin Khlebnikov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577BAC73.1080403@yandex-team.ru \
--to=khlebnikov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=sasha.levin@oracle.com \
--cc=yaodongdong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox