From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933091AbcGENVe (ORCPT <rfc822;w@1wt.eu>);
	Tue, 5 Jul 2016 09:21:34 -0400
Received: from hqemgate15.nvidia.com ([216.228.121.64]:1457 "EHLO
	hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755166AbcGENVb (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 5 Jul 2016 09:21:31 -0400
X-PGP-Universal: processed;
	by hqpgpgate101.nvidia.com on Tue, 05 Jul 2016 06:21:29 -0700
Subject: Re: [PATCH] i2c: tegra: Correct error path in probe
To: Wolfram Sang <wsa@the-dreams.de>
References: <1465936007-18599-1-git-send-email-jonathanh@nvidia.com>
 <5770F1D4.8000406@nvidia.com> <5770F2CB.2090109@nvidia.com>
CC: Laxman Dewangan <ldewangan@nvidia.com>,
        Stephen Warren <swarren@wwwdotorg.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        "Alexandre Courbot" <gnurou@gmail.com>,
        Shardar Shariff Md <smohammed@nvidia.com>, <linux-i2c@vger.kernel.org>,
        <linux-tegra@vger.kernel.org>, <linux-kernel@vger.kernel.org>
From: Jon Hunter <jonathanh@nvidia.com>
Message-ID: <577BB453.7020903@nvidia.com>
Date: Tue, 5 Jul 2016 14:21:23 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <5770F2CB.2090109@nvidia.com>
X-Originating-IP: [10.21.132.110]
X-ClientProxiedBy: UKMAIL102.nvidia.com (10.26.138.15) To UKMAIL102.nvidia.com
 (10.26.138.15)
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Wolfram,

On 27/06/16 10:32, Laxman Dewangan wrote:
> 
> On Monday 27 June 2016 02:58 PM, Jon Hunter wrote:
>> Hi all,
>>
>> On 14/06/16 21:26, Jon Hunter wrote:
>>> @@ -912,7 +912,7 @@ static int tegra_i2c_probe(struct platform_device
>>> *pdev)
>>>       ret = tegra_i2c_init(i2c_dev);
>>>       if (ret) {
>>>           dev_err(&pdev->dev, "Failed to initialize i2c controller");
>>> -        goto unprepare_div_clk;
>>> +        goto disable_div_clk;
>>>       }
>>>
> 
> Yes, this looks correct.
> 
> Acked-by: Laxman Dewangan <ldewangan@nvidia.com>

Can you pick this one up?

Cheers
Jon

-- 
nvpublic