From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755238AbcGEW0N (ORCPT ); Tue, 5 Jul 2016 18:26:13 -0400 Received: from mail-dm3nam03on0086.outbound.protection.outlook.com ([104.47.41.86]:10898 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751973AbcGEW0L (ORCPT ); Tue, 5 Jul 2016 18:26:11 -0400 X-Greylist: delayed 12853 seconds by postgrey-1.27 at vger.kernel.org; Tue, 05 Jul 2016 18:26:11 EDT Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; Subject: Re: [PART2 RFC v2 00/10] iommu/AMD: Introduce IOMMU AVIC support To: Paolo Bonzini , Joerg Roedel References: <1465855611-10092-1-git-send-email-suravee.suthikulpanit@amd.com> <20160621135043.GJ28248@8bytes.org> CC: , , , , From: Suravee Suthikulpanit Message-ID: <577C01C2.1010706@amd.com> Date: Tue, 5 Jul 2016 13:51:46 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: SN1PR01CA0022.prod.exchangelabs.com (10.165.224.32) To CY1PR12MB0441.namprd12.prod.outlook.com (10.163.91.19) X-MS-Office365-Filtering-Correlation-Id: 89761b67-65f3-4b30-835d-08d3a5056f45 X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0441;2:y9gal+EPJQhjGLS87GOh3TBx2LkIKlRCnh0WXcLo0cP/dAGCXM8J8oxLjYYB7xvswprN+SB6U0gz6sda55r6awRDLcLPRNx6frr2QtIo2o8VHnLv81JMhYxLlNwUszv7nufAewWlb6daf6BfRgBJi/3tkL8B4rphMQY122oQ2nLWOIs6x9f+wMcCb3aQufQx;3:toRIqHNzof+H42AG5dWsbOuxtBfIPalPhcykDtZa8BZcvClV5KMNNH9l5P4ifxihKb+M+r/WilolEzi+duwC1i9mUQ+34blVJcho8VY1x/SGb6AUsCtYfdShc2mvtasI;25:l7mo7ivKyHNne3RhkJSFSONC0kqKHeOTr6bkkssAAssPoeANuz09KwtnmnxfKaEE96fh7Vl1jFDjX/GjQQgEgl/POXQKfyQFEUDKk5GoARSWc4IDQuGc6pAudppNakgqH3SznN4PGc3wub/3wMa50gz3DBsJfURqSvTQNjw5J3Ph35e//SCh9lV2n9OWgl2sbSiqUIplW9pgpW74KwbCHqihnDVb+aPkmp342EY3JXZbCm2WCX72h6/CrR0gIDLG5aBSUX01k3x1zBzAIUnCpNZ4IQF9c8tTsUIITs1Fntt1e6lN7ICL8Q4Q+4+WR+3nxEKN31P/sKWxdL5YBcCoEFaFuEcGgPjErz/kyx1cJz+o87DzYzwOn2fFyD3LqfSuHI6rY8mDK8bzxypWRqD+ljPhM0PQ6axuq4veJfj53DA=;31:Ir8ZjagGx3QGuweU8YadmjGolymog9sVwoodfgWBQ2rD1Whdr90AVBrtqR/zYc/p3bAdCp89hAGYoZLS3uJY2qNkDYiG6CON67XZ5PeB5L73rE8bzRODko6f5JhcXVkfdbGPF3fnBkwrpQMtzHFmSAxfeVLOxmiuLwjmwhwqIzu9sLx403EYt1rQD44ZioivVf2ETJFBJB0ztcDqaYbnPA== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0441; X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0441;20:5/Q9XiXiB89I4iQe7LuUEWNjWo6AeGDgKq8lCF8P1gZkA6Pp0guYPErtT0H/cWM9HM33WKFhOMbfhawqnfHCvqZkj4JlR2nqexUbCLI4/Eg2e0IkRfQWSNjQibdYRFznK68jHuHKOFJLppWkMxgc6PG0D7k5EO6q9S7Z9/1FXa6CBZOj0MZ8IZr35ng2tFSLoWFYyEe+XhNs3kZHVeIW85TgsJ+bmsVwGmYlmfSTEykhDo85cxTwUji8MqEA8hkgf6UU4wH/F0NBbUpanIDCcwMGM4DprfZMAEFl/fzZP2Rjs31htVQw7gwje84D9Ml89CY5qILDcRuVhvwbufULzuXCtOAtaFw8FTtlbyDkOwh/4vXqyiB7y9XVRgS+Hic2Ka1RnenWLSXyhnLKHOd8/LL+lfxPGWRi/XKd3IRlXW2tWXwiHOIc3Yvh82w21fKLJSYCsBH6G+Qcv7fFf494/HBnao0+gnfASBqzQP+zbisSyZv676maT/aUU+45u/Va;4:O2CsudiVPOcWSTOdH+/Uy1qS3sL+JBXuLp+ATwXMvr6+KGXtyaS2f1SqBjV77kxE/l8BNddEvS+KcGOMt3074ie7xygccmqPCmja+kX0AASA6gHtETcu4yUiXoVlCi2Zs2UwoYTRGL5kFMna+0f/O+6Ev3dwISoFSKvUXRjygsZ4dgi0vnpUU7R+OXJP9ioWQYt+tNTCqwJOCLxjD4piT/9v5h5iSynZkCII9PHWEWaJNzgcL73NXqAko779ss32hxo5vs6dE4I0XCgacnyuppU7Tu8sYCTDb5ckpMb3bQMBKlP9hsKR/+I5MnZOTFQUkSrSRH/pxdoYjFvfOefGBoGX/51CqCjjyZpU2lokTFq5mPBF7RiJQJqrPhAKmk1Xsf29DFcxGDsWB+C/fhVgkA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026);SRVR:CY1PR12MB0441;BCL:0;PCL:0;RULEID:;SRVR:CY1PR12MB0441; X-Forefront-PRVS: 0994F5E0C5 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(52314003)(199003)(24454002)(189002)(81166006)(83506001)(8676002)(81156014)(106356001)(105586002)(6116002)(3846002)(76176999)(65816999)(4326007)(54356999)(101416001)(2906002)(33656002)(50986999)(59896002)(586003)(2950100001)(77096005)(92566002)(87266999)(230700001)(36756003)(86362001)(65806001)(66066001)(7846002)(50466002)(5001770100001)(4001350100001)(97736004)(65956001)(189998001)(305945005)(23746002)(47776003)(64126003)(7736002)(68736007)(42186005)(80316001)(53416004)(217873001);DIR:OUT;SFP:1101;SCL:1;SRVR:CY1PR12MB0441;H:wsp100544wss.amd.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;CY1PR12MB0441;23:JEUcwIfaALUehVLNhNBbf38qOH4sxHkGaZhjr?= =?Windows-1252?Q?+yAc/DoWai0+V0DFyv0o69PO/eVIUaVow269PTlJCkEIAz9DANmUoPko?= =?Windows-1252?Q?jjqSoyasJkHsmd08lhqXAoHD5Wn5XrYanH+F95+YavEvOX73Eif2iPkB?= =?Windows-1252?Q?b9Kw6Vp+xdm+tjctXnyDS7Wz7lKrObt9IubiK04CoY4qy60SAIvrBHqM?= =?Windows-1252?Q?er/BaWCRgm6GMDiw8ykmLA0YHFDE3HvW40YojsWe8C+7HCukGpQ9v2Y3?= =?Windows-1252?Q?q8+IhUqE0ir6Mc1xqMzp9/gf/ioR2PL/3BTs5uR9Is8gwJonqfi5YII4?= =?Windows-1252?Q?nX30JvmbBFnGYiNTObEDcucdvx9gfUSuxxNLbSGRc8gj16XE+hvSUK2z?= =?Windows-1252?Q?pIjpN+Gy27UW+OVfJEc/9Om/RVgbABUU1XlSNeOR1/UucPPqKnWcIwMY?= =?Windows-1252?Q?USydPAcKLWJF36oufJYjSX2KaK6Pls5kdI+0KNfeqfIgYxIVwGPOpRkf?= =?Windows-1252?Q?08RxaGTqtzVLwniTjwAbzeCeQ9Cq3P+yLguKsGCGmqUPFUDMF6Y/Hua8?= =?Windows-1252?Q?TiEp719acpt1P45qImOjdA0yjiCNhRcxpuNAVr6OkefOFA/jEQTLlpoC?= =?Windows-1252?Q?5IH44CnQmmhAW+v9KKZpJTn2zJeREvHuwKyfCpz1dj+GXKj00PUkxOCG?= =?Windows-1252?Q?jygHJjyxbLCBWXdh3WQQGT70oJ+Z0fBy+WDd2+itauahjy63hxzS76Go?= =?Windows-1252?Q?ec9wBMizsejEHU2iC41rEbhfnwX6weOtIVHIjWLgHf3roNPPyxs8BjyT?= =?Windows-1252?Q?Wz4+KXReSn3yF4fLbAPiGBUhnlIyLysEJZjjDFcwrU6C7yGxOLHi4IuX?= =?Windows-1252?Q?gK9g/XIB+FyBg91i0e4QXiXMghVlGxj6qbiCr12Xu49SCI5Jniz2aTwm?= =?Windows-1252?Q?mQnW/eai/wexYodz7mC2slRCHgd4HuYaEXchNBiT+vV4VhMByEJOiMsA?= =?Windows-1252?Q?24NNyKQjGsr4P1esCaIc6UG+2sj8B99Keyu64Ztki4InOZPFsR3Of50Q?= =?Windows-1252?Q?1S/JojCROk4w8C9nVCZkc1wuj4YMAPj3MKZiIDfYrumPOFZIlw6tAUFx?= =?Windows-1252?Q?RWt6D7vTdL01SqeKozTT/ui79J5skfE6GUI8QmncNvxRWg3wBDnGgZpa?= =?Windows-1252?Q?vAjE2Gj09Gi77NDNfklpfK6mQ+zAa9BJtt6NXDBeXGEDRxqVbxW36Zlb?= =?Windows-1252?Q?Np5AVfso0RO7WKOs9MvJsxJN1az1xOSs0lL4tqdMxkSgJCcgZzAPngmp?= =?Windows-1252?Q?yX91FVeDBXeizhFV17br33M5riLxU6gc4XTb/dbfmAi3Yq3ZSHaNl+ke?= =?Windows-1252?Q?eJS+lWqDy0z?= X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0441;6:EA1kCyux9busIGOVimWtNy0wnrNk0/OAbW4qwbaLlMP87bwz0VRm2fvOJUwamv3TizKCbLT5V2enWfKAoWXdWZE5MJN/q50wzHOv+PCDeiyCgBDeH4wrsmjSgarcW/U5PqeFNSBpU869zotqmMPss30YjnmB7R2ESR0s71v3MweNbzEV0w9P3rT382LxDGgXFiZdGqHX2dPEhTWEBHfWNr3nZQ1t2BylLXuH1ueGSQlGVA+57qJi5xeHr5aP/7dabScmFR2OvLJTCC3ua2j67aPZdXfp/B4PvOlVxtEl4bHbaKZi6dRAD/CSZQic4szY3y7M4hq0sk6et2PPXoPQ2w==;5:gmwM9Pzldq25U64sC51JrFN9aG5hb8E2ljY0dGy6LjzAIy5H5eVcAQjk4hThOEBAxZx76WGCJjVQkPvTp7nW+6tp5WEUMPEDaQyCb9zFxZIv4zuGuF2qS7VrjARkA7eJ6KAeyBEjGhh9F6U3Ua4U3g==;24:5pv0sMxmaGgomFjJq/r44nT8UrZon+z32Bi7Rv36bIZG/m942S9aw3e27jRxnw89Yk1i7MYV2DHrzcK4Y/oHOsIy3EGBifMpn33pfA9seJo=;7:34O2U6+Zs4VVjVeUz6UGWkTwuHQe3UcG33Z9iIUx1SLv6k/zMO8RmuOiYCGtF0CYRcaX/B8OguBG/3X06PVIlejw0S++wFSjZb3VxghFnmsZQ9vweQm23moeKwKMI7ujapISej07P9Gypbe3gZW4aH7Ejm+/3KZATL/Xz0WOfFxr131OhuMJaxhMmaPjquLOU4LMa6q7iDOZIVpZxV0/G7DfpdhYL7rcMgwlL/waW0oTOAnx2w7VNxqGB3phgcaq SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;CY1PR12MB0441;20:sqncZG9OVkZ4CfMUuQhvt18HQfmBBQ2+7wuIrC3B0cs59a2TmX/6AGV10+wNq85Gebp6SMc3GfTAGIG3+b/z/R3Nix4FW/C3uJS3tYBBvHlYo2FcO0fGWVYcoxP5eeH2NZX2SaWRnDuLcXGeTqKcJ287bBwusA/0OO32coBP150n4asOAdZZUn6x5J6EcceTgjcMyxkKkxkYSxiTJavm9NRncRo9ErqqII3v5lfvm9E03dxDsSWJXOSueVus8wYY X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2016 18:51:53.7637 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR12MB0441 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paolo, On 6/21/16 10:15, Paolo Bonzini wrote: > > > On 21/06/2016 15:50, Joerg Roedel wrote: >> The code has a few style issues (thing I'd implemented differently), but >> it looks functional. Anyway, before merging this the last 3 patches need >> to be acked by the KVM maintainers. >> >> Paolo? > > I think patches 9 and 10 should be squashed because the code after patch > 9 is only partly functional. > > Likewise, I think this: > > > + > + if (AMD_IOMMU_GUEST_IR_VAPIC(amd_iommu_guest_ir)) > + amd_iommu_irq_ops.capability |= (1 << IRQ_POSTING_CAP); > > from patch 1 should be moved to patch 6. I think you might have meant patch 7 instead of 6 since that is when we enable vAPIC mode in the IOMMU. Thanks, Suravee