From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755555AbcGEVPv (ORCPT ); Tue, 5 Jul 2016 17:15:51 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:36522 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751880AbcGEVPs (ORCPT ); Tue, 5 Jul 2016 17:15:48 -0400 Subject: Re: [PATCH 2/2] net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings To: Philippe Reynes References: <1467560037-21784-1-git-send-email-tremyfr@gmail.com> <1467560037-21784-2-git-send-email-tremyfr@gmail.com> <20160704.160300.953705748553101659.davem@davemloft.net> <577B37CC.80807@gmail.com> <577C2189.8090604@gmail.com> Cc: David Miller , netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Florian Fainelli Message-ID: <577C2380.4000007@gmail.com> Date: Tue, 5 Jul 2016 14:15:44 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <577C2189.8090604@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/05/2016 02:07 PM, Philippe Reynes wrote: > Hi Florian, > > On 05/07/16 06:30, Florian Fainelli wrote: >> Le 04/07/2016 16:03, David Miller a écrit : >>> From: Philippe Reynes >>> Date: Sun, 3 Jul 2016 17:33:57 +0200 >>> >>>> There are two generics functions phy_ethtool_{get|set}_link_ksettings, >>>> so we can use them instead of defining the same code in the driver. >>>> >>>> Signed-off-by: Philippe Reynes >>> >>> Applied. >>> >> >> The transformation is not equivalent, we lost the checks on >> netif_running() in the process, and those are here for a reason, if the >> interface is down and therefore clock gated, MDIO accesses to the PHY >> will simply fail outright and cause bus errors. > > Oh, I see, I've missed this. Sorry for this mistake. > We should revert this path. Well, maybe better than that, actually put the check in the generic functions, because if the link is down, aka netif_running() returns false, link parameters cannot be reliably queried and they are invalid. -- Florian