public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Stephen Boyd <stephen.boyd@linaro.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] extcon: Move extcon_get_edev_by_phandle() errors to dbg level
Date: Wed, 06 Jul 2016 09:06:26 +0900	[thread overview]
Message-ID: <577C4B82.7030107@samsung.com> (raw)
In-Reply-To: <20160705185705.32353-1-stephen.boyd@linaro.org>

Hi Stephen,

On 2016년 07월 06일 03:57, Stephen Boyd wrote:
> Sometimes drivers may call this API and expect it to fail because
> the extcon they're looking for is optional. Let's move these
> prints to debug level so it doesn't look like there's a problem
> when there isn't one.
> 
> Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
> ---
>  drivers/extcon/extcon.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index 161acb826334..984f50d5297c 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -1096,13 +1096,13 @@ struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index)
>  		return ERR_PTR(-EINVAL);
>  
>  	if (!dev->of_node) {
> -		dev_err(dev, "device does not have a device node entry\n");
> +		dev_dbg(dev, "device does not have a device node entry\n");
>  		return ERR_PTR(-EINVAL);
>  	}
>  
>  	node = of_parse_phandle(dev->of_node, "extcon", index);
>  	if (!node) {
> -		dev_err(dev, "failed to get phandle in %s node\n",
> +		dev_dbg(dev, "failed to get phandle in %s node\n",
>  			dev->of_node->full_name);
>  		return ERR_PTR(-ENODEV);
>  	}
> 

Applied it.

Thanks,
Chanwoo Choi

      reply	other threads:[~2016-07-06  0:06 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20160705185711epcas1p3cf1e93b383eda62cd71da5f892649cd7@epcas1p3.samsung.com>
2016-07-05 18:57 ` [PATCH] extcon: Move extcon_get_edev_by_phandle() errors to dbg level Stephen Boyd
2016-07-06  0:06   ` Chanwoo Choi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=577C4B82.7030107@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stephen.boyd@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox