[PATCH] extcon: Move extcon_get_edev_by_phandle() errors to dbg level

[PATCH] extcon: Move extcon_get_edev_by_phandle() errors to dbg level

[Stephen Boyd]

Sometimes drivers may call this API and expect it to fail because
the extcon they're looking for is optional. Let's move these
prints to debug level so it doesn't look like there's a problem
when there isn't one.

Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
---
 drivers/extcon/extcon.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
index 161acb826334..984f50d5297c 100644
--- a/drivers/extcon/extcon.c
+++ b/drivers/extcon/extcon.c
@@ -1096,13 +1096,13 @@ struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index)
 		return ERR_PTR(-EINVAL);
 
 	if (!dev->of_node) {
-		dev_err(dev, "device does not have a device node entry\n");
+		dev_dbg(dev, "device does not have a device node entry\n");
 		return ERR_PTR(-EINVAL);
 	}
 
 	node = of_parse_phandle(dev->of_node, "extcon", index);
 	if (!node) {
-		dev_err(dev, "failed to get phandle in %s node\n",
+		dev_dbg(dev, "failed to get phandle in %s node\n",
 			dev->of_node->full_name);
 		return ERR_PTR(-ENODEV);
 	}
-- 
2.9.0.rc2.8.ga28705d

Re: [PATCH] extcon: Move extcon_get_edev_by_phandle() errors to dbg level

[Chanwoo Choi]

Hi Stephen,

On 2016년 07월 06일 03:57, Stephen Boyd wrote:
> Sometimes drivers may call this API and expect it to fail because
> the extcon they're looking for is optional. Let's move these
> prints to debug level so it doesn't look like there's a problem
> when there isn't one.
> 
> Signed-off-by: Stephen Boyd <stephen.boyd@linaro.org>
> ---
>  drivers/extcon/extcon.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c
> index 161acb826334..984f50d5297c 100644
> --- a/drivers/extcon/extcon.c
> +++ b/drivers/extcon/extcon.c
> @@ -1096,13 +1096,13 @@ struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index)
>  		return ERR_PTR(-EINVAL);
>  
>  	if (!dev->of_node) {
> -		dev_err(dev, "device does not have a device node entry\n");
> +		dev_dbg(dev, "device does not have a device node entry\n");
>  		return ERR_PTR(-EINVAL);
>  	}
>  
>  	node = of_parse_phandle(dev->of_node, "extcon", index);
>  	if (!node) {
> -		dev_err(dev, "failed to get phandle in %s node\n",
> +		dev_dbg(dev, "failed to get phandle in %s node\n",
>  			dev->of_node->full_name);
>  		return ERR_PTR(-ENODEV);
>  	}
> 

Applied it.

Thanks,
Chanwoo Choi