From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752016AbcGFAGb (ORCPT ); Tue, 5 Jul 2016 20:06:31 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:52134 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751878AbcGFAG2 (ORCPT ); Tue, 5 Jul 2016 20:06:28 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68e-f79266d000001428-4f-577c4b826673 Content-transfer-encoding: 8BIT Message-id: <577C4B82.7030107@samsung.com> Date: Wed, 06 Jul 2016 09:06:26 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Stephen Boyd Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] extcon: Move extcon_get_edev_by_phandle() errors to dbg level References: <20160705185705.32353-1-stephen.boyd@linaro.org> In-reply-to: <20160705185705.32353-1-stephen.boyd@linaro.org> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJLMWRmVeSWpSXmKPExsWyRsSkULfJuybcYOJ2PYvLu+awWcy9eoDJ gcnjzrU9bB6fN8kFMEVx2aSk5mSWpRbp2yVwZfw4v5Gt4A9nxat9mxkbGH+xdzFyckgImEhs 7pvHDGGLSVy4t56ti5GLQ0hgBaPE9HstbDBFlxYsB2sQEpjFKNF+wwfE5hUQlPgx+R5LFyMH B7OAvMSRS9kgYWYBdYlJ8xYxQ8x5wCjR820NG0S9lsSlI1MYQWwWAVWJjvkQM9mA4vtf3GAD mSMqECHRfaISJCwCFJ5y5w8LxEwFiV/3NrGC2MICIRIXXjxigpg/iVHiwsX9YHM4BWwlWrtf gT0gITCdXWLa9mssEMsEJL5NPgR2qISArMSmA1APS0ocXHGDZQKj2Cwk78xCeGcWkncWMDKv YhRNLUguKE5KLzLSK07MLS7NS9dLzs/dxAiMkdP/nvXtYLx5wPoQowAHoxIP74Tn1eFCrIll xZW5hxhNgY6YyCwlmpwPjMS8knhDYzMjC1MTU2Mjc0szJXHeBKmfwUIC6YklqdmpqQWpRfFF pTmpxYcYmTg4pRoY5bUvLkq6ubh7yp/j15dkTV9376r05YnTFrvsvze1RmpLrDhnuEFaJVvt QtdbwjdMN53d5OV8/H6f+eRZu8R/SV2ffNRh5bkL4lKp8Y6is+9kxj9pmLhtg9n6hn3O55W3 xF099WDNtRezTeILQxLVTepYmlINX/z5+mQhZ8EsKZ8cnoPux559u6bEUpyRaKjFXFScCAC0 kUV0jAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGIsWRmVeSWpSXmKPExsVy+t9jQd0m75pwgzf9WhaXd81hs5h79QCT A5PHnWt72Dw+b5ILYIpqYLTJSE1MSS1SSM1Lzk/JzEu3VfIOjneONzUzMNQ1tLQwV1LIS8xN tVVy8QnQdcvMAZqvpFCWmFMKFApILC5W0rfDNCE0xE3XAqYxQtc3JAiux8gADSSsYcz4cX4j W8EfzopX+zYzNjD+Yu9i5OSQEDCRuLRgOZQtJnHh3no2EFtIYBajRPsNHxCbV0BQ4sfkeyxd jBwczALyEkcuZYOEmQXUJSbNW8TcxcgFVP6AUaLn2xo2iHotiUtHpjCC2CwCqhId8yHmswHF 97+4wQYyR1QgQqL7RCVIWAQoPOXOHxaImQoSv+5tYgWxhQVCJC68eMQEMX8So8SFi/vB5nAK 2Eq0dr9im8AIdCTCebMQzpuF5LwFjMyrGCVSC5ILipPScw3zUsv1ihNzi0vz0vWS83M3MYLj 8JnUDsaDu9wPMQpwMCrx8E54Xh0uxJpYVlyZe4hRgoNZSYR3sXtNuBBvSmJlVWpRfnxRaU5q 8SFGU6D/JjJLiSbnA1NEXkm8obGJmZGlkbmhhZGxuZI47+P/68KEBNITS1KzU1MLUotg+pg4 OKUaGKX3rQn+MLM9tvD3z/UT7qX9fXh+JSePScJ+72KrSyvCLllZ5h4o90npjIkUr3wQ4jcx jiPIu/SsCPsBH/cngUsfthZubv/euUxuzpY3733fXPzuZHfp5QVOrw385w1jymwez7Av2XIz tWpp3oYPt/epKq/r3MLxx/kCv+b8y1vy2C5nf5nNekuJpTgj0VCLuag4EQCPXBSt2QIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stephen, On 2016년 07월 06일 03:57, Stephen Boyd wrote: > Sometimes drivers may call this API and expect it to fail because > the extcon they're looking for is optional. Let's move these > prints to debug level so it doesn't look like there's a problem > when there isn't one. > > Signed-off-by: Stephen Boyd > --- > drivers/extcon/extcon.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c > index 161acb826334..984f50d5297c 100644 > --- a/drivers/extcon/extcon.c > +++ b/drivers/extcon/extcon.c > @@ -1096,13 +1096,13 @@ struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index) > return ERR_PTR(-EINVAL); > > if (!dev->of_node) { > - dev_err(dev, "device does not have a device node entry\n"); > + dev_dbg(dev, "device does not have a device node entry\n"); > return ERR_PTR(-EINVAL); > } > > node = of_parse_phandle(dev->of_node, "extcon", index); > if (!node) { > - dev_err(dev, "failed to get phandle in %s node\n", > + dev_dbg(dev, "failed to get phandle in %s node\n", > dev->of_node->full_name); > return ERR_PTR(-ENODEV); > } > Applied it. Thanks, Chanwoo Choi