From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751490AbcGFAM3 (ORCPT ); Tue, 5 Jul 2016 20:12:29 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:40178 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750840AbcGFAM0 (ORCPT ); Tue, 5 Jul 2016 20:12:26 -0400 MIME-version: 1.0 Content-type: text/plain; charset=UTF-8 X-AuditID: cbfee68f-f79476d000001429-d8-577c4ce24971 Content-transfer-encoding: 8BIT Message-id: <577C4CE2.2090103@samsung.com> Date: Wed, 06 Jul 2016 09:12:18 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 To: Seung-Woo Kim , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, k.kozlowski@samsung.com, kgene@kernel.org Subject: Re: [PATCH] memory: samsung: exynos-srom: fix wrong count of registers References: <1467718817-19239-1-git-send-email-sw0312.kim@samsung.com> In-reply-to: <1467718817-19239-1-git-send-email-sw0312.kim@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnkeLIzCtJLcpLzFFi42JZI2JSoPvIpybcYOoGZYvXLwwt+h+/ZrbY 9Pgaq8XlXXPYLGac38dkMWPySzYHNo9NqzrZPDYvqffo27KK0ePzJrkAligum5TUnMyy1CJ9 uwSujK4r31kKVnBUfP/i1sD4ja2LkYNDQsBEon1vQRcjJ5ApJnHh3nqgMBeHkMAKRoknD/cx QiRMJM4uf84EkZjFKPFzTR8bSIJXQFDix+R7LCCDmAXkJY5cygYJMwuoS0yat4gZov4Bo8SZ j4eYIOq1JCZd+MQIUs8ioCqx+gwvSJgNKLz/xQ2we0QFIiS6T1SCtIoIHGCUOLqsFWyVsIC/ xJynTWBjhATmMEp0PtUBsTkF3CV6nvwGO1pCYBu7xLmuaywgCRYBAYlvkw+xQDwpK7HpADPE L5ISB1fcYJnAKDoLyQezED6YheSDBYzMqxhFUwuSC4qT0ouM9YoTc4tL89L1kvNzNzEC4+f0 v2f9OxjvHrA+xCjAwajEw3tCoiZciDWxrLgy9xCjKdARE5mlRJPzgVGaVxJvaGxmZGFqYmps ZG5ppiTOu1DqZ7CQQHpiSWp2ampBalF8UWlOavEhRiYOTqkGRrMDJ8PDHXqT+DUXTvl473Zh ycwWrUjTw0cjuLds4Vl14ETBlGpZ53PSER+uuyxTKl9z/82GU7fcLyVdPP5BuG295OzgnA8J 3+w/bdoYKDuX37rwZeCqi/OfT+F7WcKfkXIr+fyPV9e/Gklemr3vUOW7tkeXVpbdCxW93h9q pLXop9lC8R9PP7UosRRnJBpqMRcVJwIAFvD4cZoCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrKIsWRmVeSWpSXmKPExsVy+t9jQd1HPjXhBuuOyVm8fmFo0f/4NbPF psfXWC0u75rDZjHj/D4mixmTX7I5sHlsWtXJ5rF5Sb1H35ZVjB6fN8kFsEQ1MNpkpCampBYp pOYl56dk5qXbKnkHxzvHm5oZGOoaWlqYKynkJeam2iq5+AToumXmAO1WUihLzCkFCgUkFhcr 6dthmhAa4qZrAdMYoesbEgTXY2SABhLWMGZ0XfnOUrCCo+L7F7cGxm9sXYycHBICJhJnlz9n grDFJC7cWw8U5+IQEpjFKPFzTR9YEa+AoMSPyfdYuhg5OJgF5CWOXMoGCTMLqEtMmreIGaL+ AaPEmY+HmCDqtSQmXfjECFLPIqAqsfoML0iYDSi8/8UNNpCwqECERPeJSpBWEYEDjBJHl7WC rRIW8JeY87QJbIyQwBxGic6nOiA2p4C7RM+T32wTGPlnIbloFsJFs5BctICReRWjRGpBckFx UnquYV5quV5xYm5xaV66XnJ+7iZGcJQ+k9rBeHCX+yFGAQ5GJR7eCc+rw4VYE8uKK3MPMUpw MCuJ8C52rwkX4k1JrKxKLcqPLyrNSS0+xGgK9NJEZinR5HxgAskriTc0NjEzsjQyN7QwMjZX Eud9/H9dmJBAemJJanZqakFqEUwfEwenVAMjp93GbbqJU6wuTWLu8s38fPCDVdrG7FrXPW9y d/gGBRxLvL04XkajV9/8ZPiX9Y/ebbnc3fu931fowIqf82Od1LVfvtmf9zNN0fHEq2cyf7os b5if3elRxssj6RyrE79xrrnyPqFjt+OsHWJqL0omH9thwa4bv3H5hwWfM6SPTXl0rFF59sT/ SizFGYmGWsxFxYkAOdFr4ugCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016년 07월 05일 20:40, Seung-Woo Kim wrote: > This patch fixes wrong count of array for srom registers from probe > function. > > Signed-off-by: Seung-Woo Kim > --- > drivers/memory/samsung/exynos-srom.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/memory/samsung/exynos-srom.c b/drivers/memory/samsung/exynos-srom.c > index 96756fb..c66d2bd 100644 > --- a/drivers/memory/samsung/exynos-srom.c > +++ b/drivers/memory/samsung/exynos-srom.c > @@ -134,7 +134,7 @@ static int exynos_srom_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, srom); > > srom->reg_offset = exynos_srom_alloc_reg_dump(exynos_srom_offsets, > - sizeof(exynos_srom_offsets)); > + ARRAY_SIZE(exynos_srom_offsets)); > if (!srom->reg_offset) { > iounmap(srom->reg_base); > return -ENOMEM; > On the exynos-srom.c, use the ARRAY_SIZE to get the number of array entry. Looks good to me. Reviewed-by: Chanwoo Choi Thanks, Chanwoo Choi