From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753048AbcGFHyi (ORCPT ); Wed, 6 Jul 2016 03:54:38 -0400 Received: from mail-db5eur01on0109.outbound.protection.outlook.com ([104.47.2.109]:25376 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750779AbcGFHyg (ORCPT ); Wed, 6 Jul 2016 03:54:36 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=aryabinin@virtuozzo.com; Subject: Re: [PATCH v5] kasan/quarantine: fix bugs on qlist_move_cache() To: , Andrew Morton References: <1467766348-22419-1-git-send-email-iamjoonsoo.kim@lge.com> CC: Alexander Potapenko , Dmitry Vyukov , , Kuthonuzo Luruo , , , Joonsoo Kim From: Andrey Ryabinin Message-ID: <577CB5FD.8050709@virtuozzo.com> Date: Wed, 6 Jul 2016 10:40:45 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1467766348-22419-1-git-send-email-iamjoonsoo.kim@lge.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: AM4PR0501CA0005.eurprd05.prod.outlook.com (10.167.83.143) To HE1PR0801MB1308.eurprd08.prod.outlook.com (10.167.247.150) X-MS-Office365-Filtering-Correlation-Id: 28f8e913-c49f-410e-dd45-08d3a570b2da X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1308;2:99WVptIE/6cFSPhIEEj857uxpdJQDbGYaS+Ig46Ec3DoNxFgqO1+nok7sNxmMZZcr769WGqNxdq6M1pc8Yqnn47yi6gAhttTqdldO7Jpg7sBlyCUEzgyVC41YZfV9OE7yBU2vEICyknrpppQQCFRC5NzBF1wNJ7EPuxM85wrcbuAHx0mpLUjwHIqPt1UK7n1;3:/HWPyVGinQbfhqNTLZ/oPBQxUXVmv2+crY14rkxnHfJwF+1BR4hS2E8keifX9iOPoaqchA9bQ4iZHr4rmt0mN8KzPcDeyPyF2hsYWDZyadx4UGVkh8IO1PIy832b4Lg0 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0801MB1308; X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1308;25:lE9a5ObOttrZYTdFkkXEKtOj0JeVBkDIsnxWitFaeQ0z0hgprTAUz3z1wzN+McuyIHJxzy2BMe0lS9vfaRNd97KdtW/iKpjR65FEhIdbLCP8a++3+/OrV9kI8Ich3ODlZ0hyOAQVnxNFZjjAlY7XoFVsxyg/YzKRv/K/ukMlKWPkei2X8ZX0OirfrgrOe8tFdURh6DAujZBJDyZS1a+niP/07oYciNGnhuAJ97vUo8LyVjnrPHVN9e4eU5cBNkkUmWKWOuLjqtq3y5QWkSYeEfmWfbU9aY6ueK5aqmvdj3bftSACj+tqjRg4zFCz1Psjq5zyuzIhkCMryclualy98arIncfNT3fVbJUi28yPRyHXt7PsiZ1f0KbRHrekOEoj0cuThSJQj0AqJG/XVax4rY+azWkOJ7Mcw948Noo5Yv80YqG5YpFEwO9udirY061p4lOWHg6dwazXAlM78w/S1GHdoqv0dw7kWCPKUioIh+M4OJ38FgE9vxKA0ntFVQmVh9zIGrvhdVKGnrOqONVVcSZYmOLDWE4Tb8E8BUyEYbFRoh1RJBdqs+UwDoQYXyiXbomhMLER3CNIAIq2iGTdHRH6E+VESqF+D2278xdGgqTDh5Qe4npYOFL+IMexEyAveBIAy+j6moqWAAvvp+LxuGs5Ff1fqbZAGCBg3HZN+YHZ6pKGUzbeVO4V9S+YXKDxu4JIekAQd/2FptH4KwEp0N15kObO6EE2/98RP3Q65uZOccqTQnchplUpljM+/hXK X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1308;31:yT27mstZgkS7mJkDfFGwohdzsewmwszY5XM/MiZeysp124S5zPrfSRDKi2OE7uyRT55k3dHACy4rT5Z7WoYgCd+U+NeYMHeNz1pVjUW6FJF5EQRi6JMPLvde8ESLempVPPmzfoFaZeA6y7lrLIM3urdctJkOutwNWgo0EwGyt/uKT23moq4mhhr3uDZJBf5fq0FxHh6z/iHTYLsce30QdQ==;4:7vbbPiIzxmWC8ORkuCPQA1JSDdBC7GgpOZSjVvY8o7jELPKzBZPCAze0jID62zhXWEy3fmq6JgcSc05baNQ42V36X6iYFyYnRr9g5WU3bYy228ls75xfqf/tVYlYLXEPedkB+t2HMw1M7WEr62TiVgJxCk1ws+xSQFUD2o/rIxleGgOOSGXLFaBqVYs0UHzb507xTWHAODiX3uZlKnBUwsl7v0BpaP9veTWrMfaoDr8rUI5nW8l4cFF/oO3/FRLxVyP1xdBtThnSXg/Xy+VLt65Um4BWpN5ABMYhxnn6PLyKG8VrJxNznhO1mHGrUCXXfV3bYt5fd4hRpN5/YouqFiehVqBOS+ok2BvHnk7ymAwNx8gewv8I4Kom5aaZU1FhYN/c0UPfQDRU1z6K5sXhuEaWGxAzFCSqPCxWWdV3ScDtqkSXuQ5EJ8Mw76E8OWl8IjdCKN4Xk4azqQK2lBwSmPj4Y7uFhFLkIh8V44dLmRY= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(211936372134217); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6041072)(6043046);SRVR:HE1PR0801MB1308;BCL:0;PCL:0;RULEID:;SRVR:HE1PR0801MB1308; X-Forefront-PRVS: 0995196AA2 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(189002)(377454003)(24454002)(199003)(76176999)(54356999)(87266999)(50986999)(65816999)(4326007)(86362001)(83506001)(4001350100001)(5001770100001)(97736004)(230700001)(2906002)(189998001)(42186005)(23746002)(106356001)(19580405001)(5890100001)(77096005)(47776003)(7736002)(59896002)(64126003)(105586002)(101416001)(36756003)(50466002)(92566002)(33656002)(7846002)(19580395003)(305945005)(80316001)(66066001)(81156014)(68736007)(8676002)(81166006)(6116002)(586003)(2950100001)(65806001)(65956001)(3846002);DIR:OUT;SFP:1102;SCL:1;SRVR:HE1PR0801MB1308;H:[10.30.19.223];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;HE1PR0801MB1308;23:rxZmERLTaVsF3ZZSJ6KBxqpbzL7R/mShIzn?= =?Windows-1252?Q?bzyLUcDal6ThoCP6VdmCXGCgsdi47ZAyy5b9Gv+uo1h41wmKkJOjCumE?= =?Windows-1252?Q?nUBfxVCCbvTW1WlHvaZ5Z5i0Y0lpm1ThXW4tOYnFb5yu5w09cWy2S9gM?= =?Windows-1252?Q?QYy6A5ZWG+PwRduorEvv6CM4rq6IibDQnCDGMDUaFBimYly19yGoLaEy?= =?Windows-1252?Q?QVNxxh359vRW3qU0wxUJx4EB8npJaM4Xmgj8OmH8K/F7oju8ZEIVyTqS?= =?Windows-1252?Q?s/aJHW1I4Q35ajP9Rg+CAx05nBWoWArD5B/TCw0pzEK8OutQntxWeF81?= =?Windows-1252?Q?1TWrOR/2ZPEX4Dr8Prl6StWJfQ8keE8g6Fzanjw8Fodx54kUpWsIqI7Q?= =?Windows-1252?Q?GvdivFJVIQo7wQf6dlrGPge1T6EguSIaEYkO3El/t/5Y+gF21tWFE8DU?= =?Windows-1252?Q?4MwWcv0Z2krHnn9ZzjNTzLeSD7+sG/E8pNBAIZRCLWNixrW3thUghLmv?= =?Windows-1252?Q?XoNwCapGpyQaJ0Pk043qWkygMGXWnQejBLZ082qUASdPSzvdy5ewIIMM?= =?Windows-1252?Q?dD/SyczeSqplt4Cdk9zfEuBmwZXLmqulXguq+mLpg7aac/siCUtthmwo?= =?Windows-1252?Q?Jjx7tBF7h9kFKxVk0Y0FCfOiAi2Kag4bBJafnU93HWvO4z0R+M3JM/di?= =?Windows-1252?Q?FyjO8gcwzXt0CGadXvZNS8qHspN0BYwy+1cZQLT616hac8f9FmW91Jsu?= =?Windows-1252?Q?X20b+ySK9wPrVvUcJHQzTgbgOqPj6c7h7q8tZdYRAPiB3oWUaqtgyhwz?= =?Windows-1252?Q?5oQu5yycH3S9wJOOq4IPKnQmQ8EudiElkqIY8UEalbQcoYcVcQr2wGhC?= =?Windows-1252?Q?sY7485/oA2yIA4O+vUVORgLgOVHnKgPrwgrx0To1/oFVGboTj9f+uROs?= =?Windows-1252?Q?xaKXBMPgAc+blmxSMEe96NOJ7SpLxDXLJSCTFLaklnZ/hWprrcz4VbxR?= =?Windows-1252?Q?JPE63Xh//v14m5c2+dlikcPCadZF19dDyzzZ5x2j4b/hVybeORI1cAb7?= =?Windows-1252?Q?+FblCbZy1HjRMx5/n46F6UNZW7d8MGOdfcIfQ7RXem/4SqkbHVIir5Ax?= =?Windows-1252?Q?1THDEY03B1yrohe+Y874DeCQR/WQJEXvuSQJV7NhM45p9gr1oY0NQjHH?= =?Windows-1252?Q?70e5zdkBLXiaWtLKiw0Nv5eLJDtL3xBBv53jwmkgASJ++xTu5Okc0+xp?= =?Windows-1252?Q?DbUrSoVB/DPvz8UNoGXg6a5fSoexnVYaByux4aumrAM1aU+SlF+sSjiP?= =?Windows-1252?Q?u7beC8PWNK9wm8CgzfNYRUBl699skubTHRLsevQFza6ZiY6/+QNC4rPH?= =?Windows-1252?Q?ikia7TWTlIWJaodyXuDb0RnC2pTE1ZjU12Ww6OlhyeeYxrwUXfZSbsjq?= =?Windows-1252?Q?lZ25y9Yxd16JLvSaID2sS?= X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1308;6:3S6i7AhV4c6BK63qGdrmZIARLvIMmzvufWZ0mNDji9M6aMIt+c+plP1bA60CG2KlFyuiIv+buiQ3+HZv4fQcXL1Bckyly0VWZs/MgbVnSCclqHFcQq6lWPDkP4RSfqA9orM2IWJUITAyTrN/2G92xxBQClLFOOcKOdeEu+8BMC1okSKvSoqFIAIhq+8Ik35g8EsaoKddSAiLuON8S411PBj1c9e+MQ9gwyZxaZ4UxcBxv90tIAWrttxqXYg1HnwrIgjyM/ahUkQJzjTZg4iAGDXNHGD8+nlkO3pD1HWwaHNpdAVxd/Tu61IZaMNYh5kX;5:/VWuiqYxgozHv7/kaf9l2zqv7HTb1LZjU8M1NF7I3m6uAia/UQCdLKIdB7kSX4+GwE6cnR5NibxYIleKfveTpgxnRxdIEdU0SVGsQn5Pkluq+Ksp0EDNQg0kyosCrayYiRBqFYOnLPw/VKKVE0mrmQ==;24:Gsf7n0ntG8f58P0zAFLk0woqRdppuFkd5WVXBFnCzARKMWDV6wdoFp8/EJaglMYw4o9ZTScfhT5fKKCn7DFnJQYGLosQgsSjoRGR67ybu+o=;7:prmn3G4m2j9/SLqfArikJOmV28/Lp3qtLvH+HbjIIdxODosp7v/7M3pwK/oolaENU/ZYugkF5i5m7xYiR7UfbVEMLG3X2MiqLjFX42BKd8cJWyj4jvhYlAJ6ZabXwX/tjpdDkrA5cKULIo7XjzxWs5MH9W7nGgbVdhrqcUWFYexsAjYIppCYh0V3Z2zdhL+SyppZhhSj3k1Pf6pzKk3rP4WF8EjaLf23jQH4Rw53KWJwHkL2upDVCZ44Uy019s4H SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;HE1PR0801MB1308;20:uux3Iu9aWZkAfX9JD9Ae9ZG4dGIMu2VTLjma9zni1+lrO/A4dx1hQyLXAg1NnFcWSJlYzp9L72lRAaTdCQqf5rtE/NAZZtWOWmiaSjP6PIX1iOu8ZV2ARuJWc6KyEBvJllLwsOTGk3WqEcxjqqmBDc909JHrT/xWDOEtHyQIhNI= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Jul 2016 07:39:43.5662 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0801MB1308 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/06/2016 03:52 AM, js1304@gmail.com wrote: > From: Joonsoo Kim > > There are two bugs on qlist_move_cache(). One is that qlist's tail > isn't set properly. curr->next can be NULL since it is singly linked > list and NULL value on tail is invalid if there is one item on qlist. > Another one is that if cache is matched, qlist_put() is called and > it will set curr->next to NULL. It would cause to stop the loop > prematurely. > > These problems come from complicated implementation so I'd like to > re-implement it completely. Implementation in this patch is really > simple. Iterate all qlist_nodes and put them to appropriate list. > > Unfortunately, I got this bug sometime ago and lose oops message. > But, the bug looks trivial and no need to attach oops. > > v5: rename some variable for better readability > v4: fix cache size bug s/cache->size/obj_cache->size/ > v3: fix build warning > > Reviewed-by: Dmitry Vyukov > Signed-off-by: Joonsoo Kim Fixes: 55834c59098d ("mm: kasan: initial memory quarantine implementation") Acked-by: Andrey Ryabinin