From: arvind Yadav <arvind.yadav.cs@gmail.com>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: dmitry.torokhov@gmail.com, ldewangan@nvidia.com,
linus.walleij@linaro.org, van.freenix@gmail.com,
bjorn.andersson@sonymobile.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] GPIO_KEYS: If devm_add_action() fails, we are explicitly calling the cleanup to freethe resources allocated. Use the helper devm_add_action_or_reset() and return directly in case of error, since the cleanup function has been already called by the helper if there was any error.
Date: Wed, 6 Jul 2016 16:52:19 +0530 [thread overview]
Message-ID: <577CE9EB.9060202@gmail.com> (raw)
In-Reply-To: <20160705170111.GO1190@tuxbot>
Sorry for subject. Thanks for reviewing my patch. I will take care and
follow the standard now.
regards,
Arvind
On Tuesday 05 July 2016 10:31 PM, Bjorn Andersson wrote:
> On Tue 05 Jul 09:18 PDT 2016, Arvind Yadav wrote:
>
> Your subject line should be a short and descriptive summary, followed by
> an empty line and then potentially a longer description motivating your
> patch. Please read section #14 of Documentation/SubmittingPatches.
>
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
>> ---
>> drivers/input/keyboard/gpio_keys.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/input/keyboard/gpio_keys.c b/drivers/input/keyboard/gpio_keys.c
>> index 2909365..a2fa3bb 100644
>> --- a/drivers/input/keyboard/gpio_keys.c
>> +++ b/drivers/input/keyboard/gpio_keys.c
>> @@ -542,7 +542,8 @@ static int gpio_keys_setup_key(struct platform_device *pdev,
>> * Install custom action to cancel release timer and
>> * workqueue item.
>> */
>> - error = devm_add_action(&pdev->dev, gpio_keys_quiesce_key, bdata);
>> + error = devm_add_action_or_reset(&pdev->dev, gpio_keys_quiesce_key,
>> + bdata);
> The code leading up to this initializes the timer and work struct, but
> they are not triggered unless their respective isr is exectued. This
> would not happen until after the request_irq at the end of the function.
>
> As such there doesn't appear to be a reason for cancelling any work or
> timers.
>
>> if (error) {
>> dev_err(&pdev->dev,
>> "failed to register quiesce action, error: %d\n",
> Regards,
> Bjorn
next prev parent reply other threads:[~2016-07-06 11:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 16:18 [PATCH] GPIO_KEYS: If devm_add_action() fails, we are explicitly calling the cleanup to freethe resources allocated. Use the helper devm_add_action_or_reset() and return directly in case of error, since the cleanup function has been already called by the helper if there was any error Arvind Yadav
2016-07-05 17:01 ` Bjorn Andersson
2016-07-06 11:22 ` arvind Yadav [this message]
2016-07-06 17:59 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577CE9EB.9060202@gmail.com \
--to=arvind.yadav.cs@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=dmitry.torokhov@gmail.com \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=van.freenix@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).