From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754539AbcGFNRX (ORCPT ); Wed, 6 Jul 2016 09:17:23 -0400 Received: from foss.arm.com ([217.140.101.70]:58100 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752644AbcGFNRV (ORCPT ); Wed, 6 Jul 2016 09:17:21 -0400 Subject: Re: [PATCH 2/2] firmware: scpi: add CONFIG_OF dependency To: Arnd Bergmann References: <20160706125019.1602213-1-arnd@arndb.de> <20160706125019.1602213-2-arnd@arndb.de> Cc: Sudeep Holla , Mark Rutland , Eric Anholt , linux-kernel@vger.kernel.org From: Sudeep Holla Organization: ARM Message-ID: <577D04DE.2070506@arm.com> Date: Wed, 6 Jul 2016 14:17:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160706125019.1602213-2-arnd@arndb.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, On 06/07/16 13:49, Arnd Bergmann wrote: > We get a harmless warning if the ARM_SCPI_POWER_DOMAIN driver is enabled > without CONFIG_OF during compile testing: > > warning: (ARM_SCPI_POWER_DOMAIN) selects PM_GENERIC_DOMAINS_OF which has unmet direct dependencies (PM_GENERIC_DOMAINS && OF) > > There is no need to select PM_GENERIC_DOMAINS_OF if OF is set, so we can > replace the 'select' with a dependency. > Thanks for spotting this and fixing. Do you plan to take this directly ? If so, Acked-by: Sudeep Holla -- Regards, Sudeep