* [PATCH 1/2] soc: raspberrypi-power: add CONFIG_OF dependency
@ 2016-07-06 12:49 Arnd Bergmann
2016-07-06 12:49 ` [PATCH 2/2] firmware: scpi: " Arnd Bergmann
2016-07-06 17:54 ` [PATCH 1/2] soc: raspberrypi-power: " Eric Anholt
0 siblings, 2 replies; 6+ messages in thread
From: Arnd Bergmann @ 2016-07-06 12:49 UTC (permalink / raw)
To: Alexander Aring
Cc: Arnd Bergmann, Eric Anholt, Florian Fainelli, Scott Branden,
linux-kernel
We get a harmless warning if the RASPBERRYPI_POWER driver is enabled without
CONFIG_OF during compile testing:
warning: RASPBERRYPI_POWER selects PM_GENERIC_DOMAINS_OF which has unmet direct dependencies (PM_GENERIC_DOMAINS && OF)
There is no need to select PM_GENERIC_DOMAINS_OF if OF is set, so we can
replace the 'select' with a dependency.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/soc/bcm/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/soc/bcm/Kconfig b/drivers/soc/bcm/Kconfig
index 97156aeed286..a39b0d58ddd0 100644
--- a/drivers/soc/bcm/Kconfig
+++ b/drivers/soc/bcm/Kconfig
@@ -2,10 +2,9 @@ menu "Broadcom SoC drivers"
config RASPBERRYPI_POWER
bool "Raspberry Pi power domain driver"
- depends on ARCH_BCM2835 || COMPILE_TEST
+ depends on ARCH_BCM2835 || (COMPILE_TEST && OF)
depends on RASPBERRYPI_FIRMWARE=y
select PM_GENERIC_DOMAINS if PM
- select PM_GENERIC_DOMAINS_OF if PM
help
This enables support for the RPi power domains which can be enabled
or disabled via the RPi firmware.
--
2.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH 2/2] firmware: scpi: add CONFIG_OF dependency
2016-07-06 12:49 [PATCH 1/2] soc: raspberrypi-power: add CONFIG_OF dependency Arnd Bergmann
@ 2016-07-06 12:49 ` Arnd Bergmann
2016-07-06 13:17 ` Sudeep Holla
2016-07-06 17:54 ` [PATCH 1/2] soc: raspberrypi-power: " Eric Anholt
1 sibling, 1 reply; 6+ messages in thread
From: Arnd Bergmann @ 2016-07-06 12:49 UTC (permalink / raw)
To: Sudeep Holla; +Cc: Arnd Bergmann, Mark Rutland, Eric Anholt, linux-kernel
We get a harmless warning if the ARM_SCPI_POWER_DOMAIN driver is enabled
without CONFIG_OF during compile testing:
warning: (ARM_SCPI_POWER_DOMAIN) selects PM_GENERIC_DOMAINS_OF which has unmet direct dependencies (PM_GENERIC_DOMAINS && OF)
There is no need to select PM_GENERIC_DOMAINS_OF if OF is set, so we can
replace the 'select' with a dependency.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 8bec4337ad40 ("firmware: scpi: add device power domain support using genpd")
---
drivers/firmware/Kconfig | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
index 541d3fb7ae43..0e22f241403b 100644
--- a/drivers/firmware/Kconfig
+++ b/drivers/firmware/Kconfig
@@ -29,10 +29,9 @@ config ARM_SCPI_PROTOCOL
config ARM_SCPI_POWER_DOMAIN
tristate "SCPI power domain driver"
- depends on ARM_SCPI_PROTOCOL || COMPILE_TEST
+ depends on ARM_SCPI_PROTOCOL || (COMPILE_TEST && OF)
default y
select PM_GENERIC_DOMAINS if PM
- select PM_GENERIC_DOMAINS_OF if PM
help
This enables support for the SCPI power domains which can be
enabled or disabled via the SCP firmware
--
2.9.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] firmware: scpi: add CONFIG_OF dependency
2016-07-06 12:49 ` [PATCH 2/2] firmware: scpi: " Arnd Bergmann
@ 2016-07-06 13:17 ` Sudeep Holla
2016-07-07 12:59 ` Arnd Bergmann
0 siblings, 1 reply; 6+ messages in thread
From: Sudeep Holla @ 2016-07-06 13:17 UTC (permalink / raw)
To: Arnd Bergmann; +Cc: Sudeep Holla, Mark Rutland, Eric Anholt, linux-kernel
Hi Arnd,
On 06/07/16 13:49, Arnd Bergmann wrote:
> We get a harmless warning if the ARM_SCPI_POWER_DOMAIN driver is enabled
> without CONFIG_OF during compile testing:
>
> warning: (ARM_SCPI_POWER_DOMAIN) selects PM_GENERIC_DOMAINS_OF which has unmet direct dependencies (PM_GENERIC_DOMAINS && OF)
>
> There is no need to select PM_GENERIC_DOMAINS_OF if OF is set, so we can
> replace the 'select' with a dependency.
>
Thanks for spotting this and fixing. Do you plan to take this directly ?
If so,
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] firmware: scpi: add CONFIG_OF dependency
2016-07-06 13:17 ` Sudeep Holla
@ 2016-07-07 12:59 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2016-07-07 12:59 UTC (permalink / raw)
To: Sudeep Holla; +Cc: Mark Rutland, Eric Anholt, linux-kernel
On Wednesday, July 6, 2016 2:17:18 PM CEST Sudeep Holla wrote:
> On 06/07/16 13:49, Arnd Bergmann wrote:
> > We get a harmless warning if the ARM_SCPI_POWER_DOMAIN driver is enabled
> > without CONFIG_OF during compile testing:
> >
> > warning: (ARM_SCPI_POWER_DOMAIN) selects PM_GENERIC_DOMAINS_OF which has unmet direct dependencies (PM_GENERIC_DOMAINS && OF)
> >
> > There is no need to select PM_GENERIC_DOMAINS_OF if OF is set, so we can
> > replace the 'select' with a dependency.
> >
>
> Thanks for spotting this and fixing. Do you plan to take this directly ?
> If so,
>
> Acked-by: Sudeep Holla <sudeep.holla@arm.com>
>
Applied to next/drivers, thanks for the Ack
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] soc: raspberrypi-power: add CONFIG_OF dependency
2016-07-06 12:49 [PATCH 1/2] soc: raspberrypi-power: add CONFIG_OF dependency Arnd Bergmann
2016-07-06 12:49 ` [PATCH 2/2] firmware: scpi: " Arnd Bergmann
@ 2016-07-06 17:54 ` Eric Anholt
2016-07-07 12:59 ` Arnd Bergmann
1 sibling, 1 reply; 6+ messages in thread
From: Eric Anholt @ 2016-07-06 17:54 UTC (permalink / raw)
To: Arnd Bergmann, Alexander Aring
Cc: Arnd Bergmann, Florian Fainelli, Scott Branden, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 534 bytes --]
Arnd Bergmann <arnd@arndb.de> writes:
> We get a harmless warning if the RASPBERRYPI_POWER driver is enabled without
> CONFIG_OF during compile testing:
>
> warning: RASPBERRYPI_POWER selects PM_GENERIC_DOMAINS_OF which has unmet direct dependencies (PM_GENERIC_DOMAINS && OF)
>
> There is no need to select PM_GENERIC_DOMAINS_OF if OF is set, so we can
> replace the 'select' with a dependency.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Eric Anholt <eric@anholt.net>
I'm guessing you'll take this patch directly.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 818 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] soc: raspberrypi-power: add CONFIG_OF dependency
2016-07-06 17:54 ` [PATCH 1/2] soc: raspberrypi-power: " Eric Anholt
@ 2016-07-07 12:59 ` Arnd Bergmann
0 siblings, 0 replies; 6+ messages in thread
From: Arnd Bergmann @ 2016-07-07 12:59 UTC (permalink / raw)
To: Eric Anholt
Cc: Alexander Aring, Florian Fainelli, Scott Branden, linux-kernel
On Wednesday, July 6, 2016 10:54:19 AM CEST Eric Anholt wrote:
> Arnd Bergmann <arnd@arndb.de> writes:
>
> > We get a harmless warning if the RASPBERRYPI_POWER driver is enabled without
> > CONFIG_OF during compile testing:
> >
> > warning: RASPBERRYPI_POWER selects PM_GENERIC_DOMAINS_OF which has unmet direct dependencies (PM_GENERIC_DOMAINS && OF)
> >
> > There is no need to select PM_GENERIC_DOMAINS_OF if OF is set, so we can
> > replace the 'select' with a dependency.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Acked-by: Eric Anholt <eric@anholt.net>
>
> I'm guessing you'll take this patch directly.
>
Applied into next/drivers, thanks for the Ack
Arnd
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-07-07 12:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-06 12:49 [PATCH 1/2] soc: raspberrypi-power: add CONFIG_OF dependency Arnd Bergmann
2016-07-06 12:49 ` [PATCH 2/2] firmware: scpi: " Arnd Bergmann
2016-07-06 13:17 ` Sudeep Holla
2016-07-07 12:59 ` Arnd Bergmann
2016-07-06 17:54 ` [PATCH 1/2] soc: raspberrypi-power: " Eric Anholt
2016-07-07 12:59 ` Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).