From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755483AbcGFRtJ (ORCPT ); Wed, 6 Jul 2016 13:49:09 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:34585 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755399AbcGFRtG (ORCPT ); Wed, 6 Jul 2016 13:49:06 -0400 Subject: Re: [PATCH] arm64: dts: berlin4ct: Add L2 cache topology To: Jisheng Zhang , robh+dt@kernel.org, mark.rutland@arm.com, catalin.marinas@arm.com, will.deacon@arm.com References: <1466066418-1141-1-git-send-email-jszhang@marvell.com> Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org From: Sebastian Hesselbarth Message-ID: <577D448D.8030701@gmail.com> Date: Wed, 6 Jul 2016 19:49:01 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 In-Reply-To: <1466066418-1141-1-git-send-email-jszhang@marvell.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16.06.2016 10:40, Jisheng Zhang wrote: > This patch adds the L2 cache topology for berlin4ct which has 1MB L2 > cache. > > Signed-off-by: Jisheng Zhang > --- > arch/arm64/boot/dts/marvell/berlin4ct.dtsi | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm64/boot/dts/marvell/berlin4ct.dtsi b/arch/arm64/boot/dts/marvell/berlin4ct.dtsi > index 099ad93..c9e3a98 100644 > --- a/arch/arm64/boot/dts/marvell/berlin4ct.dtsi > +++ b/arch/arm64/boot/dts/marvell/berlin4ct.dtsi [...] > @@ -92,9 +95,14 @@ > device_type = "cpu"; > reg = <0x3>; > enable-method = "psci"; > + next-level-cache = <&L2_0>; > cpu-idle-states = <&CPU_SLEEP_0>; > }; > > + L2_0: l2-cache0 { Jisheng, The node name should just have a generic name that reflects the purpose of the unit it represents, i.e. s/l2-cache0/cache/ nits: - What is that "0" for? Please remove if there is no good reason. - Does the node label need to be upper-case? Please make it lower case. Sebastian > + compatible = "cache"; > + }; > + > idle-states { > entry-method = "psci"; > CPU_SLEEP_0: cpu-sleep-0 { >