From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756048AbcGGBmo (ORCPT <rfc822;w@1wt.eu>);
	Wed, 6 Jul 2016 21:42:44 -0400
Received: from szxga03-in.huawei.com ([119.145.14.66]:33020 "EHLO
	szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752720AbcGGBmn (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 6 Jul 2016 21:42:43 -0400
Subject: Re: [PATCH] ipv6: Fix soft lockup for ipv6 network notifier.
To: Eric Dumazet <eric.dumazet@gmail.com>
References: <57761E04.8030202@huawei.com>
 <1467359847.11238.34.camel@edumazet-glaptop3.roam.corp.google.com>
 <5776258F.6080008@huawei.com>
 <1467361396.11238.35.camel@edumazet-glaptop3.roam.corp.google.com>
 <577CBE0E.1050809@huawei.com>
 <1467794644.1273.17.camel@edumazet-glaptop3.roam.corp.google.com>
CC: <luto@kernel.org>, <mingo@kernel.org>, <linux-kernel@vger.kernel.org>,
        Eric Dumazet <edumazet@google.com>,
        "David S. Miller" <davem@davemloft.net>,
        Netdev <netdev@vger.kernel.org>, Cong Wang <cwang@twopensource.com>
From: Ding Tianhong <dingtianhong@huawei.com>
Message-ID: <577DB383.30202@huawei.com>
Date: Thu, 7 Jul 2016 09:42:27 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101
 Thunderbird/38.5.1
MIME-Version: 1.0
In-Reply-To: <1467794644.1273.17.camel@edumazet-glaptop3.roam.corp.google.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
X-Originating-IP: [10.177.22.246]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A090201.577DB38A.0110,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-05-26 15:14:31,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: f609852f733554f6e6dffb1ee9387724
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2016/7/6 16:44, Eric Dumazet wrote:
> On Wed, 2016-07-06 at 16:15 +0800, Ding Tianhong wrote:
>> Hi Eric：
>>
>> I had found out that the patch aaf92f(netfilter: conntrack: resched in
>> nf_ct_iterate_cleanup) solve the problem, 
>> this patch add cond_sched() in the nf_ct_iterate_cleanup() which will
>> be called in the net notifier chain every time,
>> and I revert this patch at kernel 4.7-rc4 , it will panic for soft
>> lockup, so I am not sure whether our patch is need,
>> it looks like if I disable the CONFIG for netfilter that would
>> register the nf_ct_iterate_cleanup as notifier, the problem still be
>> exist.
> 
> Well, I do not have conntrack on my kernels, and I can not reproduce the
> issue.
> 
> So I am guessing other patches also solved a scalability issue, between
> 4.1 and 4.7
> 
> I am aware of something that David did for IPv4, but this might help as
> well for IPv6.
> 
> commit fbd40ea0180a2d328c5adc61414dc8bab9335ce2
> ipv4: Don't do expensive useless work during inetdev destroy.
>     

Hi Eric：

I check this patch:
[root@localhost linux]# git name-rev fbd40ea0180a2d328c5adc61414dc8bab9335ce2
fbd40ea0180a2d328c5adc61414dc8bab9335ce2 tags/v4.6-rc1~91^2~63

So the kernel4.7-RC4 already has this patch, but it have no effort if I revert the commit  aaf92f(netfilter: conntrack: resched in
nf_ct_iterate_cleanup), So I don't think David's patch could fix this problem.

Thanks
Ding

> 
> 
> 
>