From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756723AbcGGH6F (ORCPT ); Thu, 7 Jul 2016 03:58:05 -0400 Received: from mail-sn1nam02on0047.outbound.protection.outlook.com ([104.47.36.47]:2320 "EHLO NAM02-SN1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750817AbcGGH6A (ORCPT ); Thu, 7 Jul 2016 03:58:00 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Christian.Koenig@amd.com; Subject: Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue To: =?UTF-8?Q?Michel_D=c3=a4nzer?= , Tejun Heo References: <20160702110350.GA3601@Karyakshetra> <20160702134614.GB17431@htj.duckdns.org> <9e69b1fd-eb93-1fee-15af-c905ee3a202f@daenzer.net> <20160705210644.GB25394@htj.duckdns.org> <936c5bae-b8e6-bf64-8be2-d27608814fac@daenzer.net> <20160706134532.GF3262@mtj.duckdns.org> <85449fbd-45ba-7eea-8520-d0c19b8af001@daenzer.net> CC: Bhaktipriya Shridhar , Alex Deucher , , From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <577E081E.8030701@amd.com> Date: Thu, 7 Jul 2016 09:43:26 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <85449fbd-45ba-7eea-8520-d0c19b8af001@daenzer.net> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [2a02:908:1251:a381:d0c2:39bf:a29a:ef91] X-ClientProxiedBy: VI1PR07CA0117.eurprd07.prod.outlook.com (10.165.229.171) To BN3PR1201MB0914.namprd12.prod.outlook.com (10.165.76.14) X-MS-Office365-Filtering-Correlation-Id: 2d8a3cbc-538c-4250-30eb-08d3a63a6ab9 X-Microsoft-Exchange-Diagnostics: 1;BN3PR1201MB0914;2:ZxX8gqpCR4lVbDrM4tbNiY4/v3OVW41Zzk0i8lbVVdEk3FLX31TE7iGztayFPEwrMUYJ1ulCNH3XWm4Q9ApeDekJ+M596DeDeDK23epm53ulI+3KwYn6iqKdeQGFwKPMsATTL6Duami0MBFeIqne399Gqq/PQ8Q1otWfPovAwhlZADcXDVz7Hxs8ckKyaAvF;3:3WPkWIkjQz1gAyjXuUXhSUT8ekQNrer8Tvp8fw3dAiqq12pB3KgdhWKrUOhDPRZEHE5yQrh+fvJSdyJQINnHsCR3A59CaGAtGYusWJr3TDI53pqvk5sZar32Q3HkCOoV;25:0+cIN38BNthZlckE013Gr9Biwb6La/uMGsiNNIpuIN8Kuwj/q8rTwPxscK7tSG+bVNvLnY3igC+OmbrMmU2DAqXfJv0GFcN+U2WtCJ3mqLXtyya6QuMLYNOYemSkyFwSIg7m3DO+rG93Hg8d1hhkjvcsmWBp5DYKnXaLd0+/wCR4F5Mg2TkShl5eCMN24XWZkbARJVL99woUXPqq3h6faeb9b4pxNQ46192FCVz1A4kjZ9i5ok6KQsynHojbbeC5d9elfMV2ubnnrFheji/CyVYGRTd5M/mJeQ9FZ5Krw6yFaWsatw1XqCcV001Gc2UZTuqZ2jhYzeoCuV0cM1fNBmdqhYr00N2eWUcWmZeAHX8DsoLx3tb5bRhXk4dO8f+e+o0RoONro9uTFMHqTYVTWB9NXY7XL3W6vdhyKuF98V0= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR1201MB0914; X-Microsoft-Exchange-Diagnostics: 1;BN3PR1201MB0914;31:/KSXherXIRIga3Q00PS5/IifgLiX4FyGVo9zS7IlkmALIB1cCb7erlfj715kCZjx6hT02+r+I+jBDFHiEKKGtg5UvbTnUoVk3NzazJ7gnk1f5p8+VzYn+BLjVRN0r1+EXZQn+0Zf8Llib3mbMFgPl75YwKGp1XkUPNWzHR180IgreO+oDYQaE0UMdmA1PcfRsnFSzwmoMs/mkD0rpp3BEw==;20:/5g31jDWWofxLJkNQUyFeWr3KYOSRp1jZq3tgbPTHbfRoVUwcESpyviYtrzxOdRF1iiXyg7ZRnaKr2sxInBI1Ev7ayhFcBy2zzsKHmf2ev6sptFDMk7lnKur8Zr96SUbgdnn4/bEIx9BnD7b1CaoKuQZH7BY8bCoE/G2XvBTwA/mOMqyVDguocbie7D0rvivzGXmw7k7Lrfa82Hrt1CsyXfNuvpXDhsNtdXg/MQdRj6LgM9YGPdBBAfGovMQb3ZdLalr6FhcAm6YPiubo1uI7hh1I2egnH2SnPTjQpoLoEYTTOjHpgYmeocuyBCp90BjBBnIDxyww3UIxiz96fqkaCeHxY2dcqpojEp3VU2wjG8MdhyVq+Xd64ncIOKcDg+XZIP2CbF8TYp34ta7b+yWjjA8A+Dlol6Jew8Hxs5rqGo2R6XmaoeYjph4OPSaAfgwVbq3SFW5q7b4H07byED0G8XwduTuEVvSux+nC14vqVWudjxfHQj8dDgyHn3+noI+ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:BN3PR1201MB0914;BCL:0;PCL:0;RULEID:;SRVR:BN3PR1201MB0914; X-Microsoft-Exchange-Diagnostics: 1;BN3PR1201MB0914;4:gKwxsA+rC6tQe4t7QFh9UfJyHpo7d+/Kg0ruqtYgWYTnEMFsjIw2eDeGRihX69rhuZb2siFBa3oNZk11puyz4M0JzJjsV72wnerirx6/fAb/KzQvIhygfk5LMvD9ODbFp0NlDgUloRAZkPrvKwhuJusaZ4sE+0PDUtrJH/yYeT34s+/or5qk8KDlwWsIanJQQqzC4q3ClZksPLalxf/gPODcq0AsUki5lWKodW+A91RgyXqQA8PicgbKIGF3obTwtiTl7VcPOmUu4nkB9mQkU6GvlF9gqN7O6yIvEcLRtTqY6eSTKvL4+Rn4wYnvLGnq0eEyz7LxNOkAfxXRWWd+NVeTD9M6/y1mtXocwi63/u5LNNsouu+NmRbgNfxLECAg X-Forefront-PRVS: 0996D1900D X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(24454002)(199003)(189002)(33656002)(106356001)(42186005)(23676002)(8676002)(189998001)(2950100001)(2870700001)(50466002)(97736004)(5001770100001)(4326007)(47776003)(81156014)(7846002)(4001350100001)(59896002)(65956001)(105586002)(81166006)(65806001)(93886004)(36756003)(68736007)(305945005)(1706002)(64126003)(101416001)(7736002)(50986999)(54356999)(76176999)(86362001)(65816999)(77096005)(87266999)(6116002)(80316001)(2906002)(19580405001)(92566002)(586003)(83506001)(3076002)(3826002);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR1201MB0914;H:[IPv6:2a02:908:1251:a381:d0c2:39bf:a29a:ef91];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtCTjNQUjEyMDFNQjA5MTQ7MjM6R0FmTW90T2lKTDV1eEx2bUw5bHNldS9w?= =?utf-8?B?cDV2M3NsZ2dadHJuYkM3bGNDSFZlR2JmYWJWV2JUVFV0TDJYaWEzaWs3OHNT?= =?utf-8?B?cVdFRWRsaVJFeHh5VmV6Q1ZvVFZuZnVVblRDTzV6MGExd2REQ0VSTjNPMVhI?= =?utf-8?B?SzM2Z0RtN1ZHVE5hYjZXQkliUTFhODJrdk9mOVpDYXR0Q1IyZ2ZRVDZKVHJs?= =?utf-8?B?RXhRWm5MQ01uTWdQZi9Eczd2bkRsWXlIOVQ4clIxNWhISE1vNW9BZjlPWWJG?= =?utf-8?B?ZFBBeEtocTRwUTJoWXlYZGdOOENnN3JobmZ3bHBrRmNOSkRta2NUVW1YWXlG?= =?utf-8?B?VVhTemw0YzlUMTU4bWU1ckhjWjVFVSt2NUpvL3VCZ3I2RVZXZ0FHKzZaZEYr?= =?utf-8?B?UHFiNk1rY0s2TGczU241djJVcEIvSHQzMUlaa0pCN2QzVkhQMWd2NVBKaHgr?= =?utf-8?B?OWgzNEN4bXhTVGxPeFc2Tm4yWXlCSjlLUEdBN2tCVUg5VmFxNFlaWTQwTkYx?= =?utf-8?B?OUpLMi9pRys5T2syZStlaFhaSys1REJUYnhacEduR1VaQzU0VjF5WklZclNu?= =?utf-8?B?M3dtT3Z5U3cyVmtVZUR5SzJtT3RLMXpvQU9BbUgxN1dKUGFiV0l4Q3hPN0Vx?= =?utf-8?B?Z1A0cXFUdlFydGVaTUlsN0NmRnQ1enpXZzk2NUtUWGN4QzVrYStLWmp2Wjhi?= =?utf-8?B?ZnBKRGdXS1FzaCtOQTRjamVwT3NUU0JWTitaV3YySC9qdi9sZDgzbFpCeWth?= =?utf-8?B?QkZ4SHJqYytBVmEzbFVlUzlGd01nbjgxNFREbzNET245bGtEVTFSYVltVnpL?= =?utf-8?B?OVJIV3B6SmtOVEVPZ3A0QlpSMkY0Y1lDT0s5SEhmM0VrdnZXZjI3dHBwV3JK?= =?utf-8?B?SHBwZTBwaDk3b0U0bGROZVZ6QThKdURzTlVXSStiK2g4eGRpaXB3R1Q3MVEz?= =?utf-8?B?cWxqRmhBakZsWjdYek1iaDRWTGpOanNBNS9OYkI4UEhzd1pKOFhaaWh3Vit4?= =?utf-8?B?ckNGWHhyMkRyS0Nqb1RjQ0xZOWpwZ1VkelowRHgybWxuOEc2ZkY5bnZ5OTAv?= =?utf-8?B?aHowTGs3cHpURkdxT1NhL05jQjg1Z2ptZjZMaGQ4dHRXMVhtUkRpSFdxdmtJ?= =?utf-8?B?Wjd4REJrNXNSZW4yQW5EU0JLcUp4V2doUHNmVzBnOTRUdis0Z0h1bkJ2SnE0?= =?utf-8?B?WU8zTWg5UjNEblVkTXkxdldFTlhzNUplU1FHYk40Mkd3R3c0djJzK1V6N2tL?= =?utf-8?B?RzlXRFhZM2ZyMU4rVUpJSHZya1BpNEcwbjd1Q3AxNU9SeUVsY0NtSWczK2xX?= =?utf-8?B?TFBBR1VqNno1dEt4ZHhlK250VG5GV0FuR1ExUFVQWUhSdnZqNW1vRFhUVHpU?= =?utf-8?B?WE4wdXdUNENnRThvcE1iL29LWTMzblJxSGVqczJGWG84dEFiYkJqYmF5Nyt1?= =?utf-8?B?M29ObGJrM2E5dGM2TUxjekJFZ0dCbVlqSS9id3R3MWZsRXlVL2d6Um9jeHZv?= =?utf-8?B?YVhHYzFDYzRIRStmUm1RbkJHWUo4UW5sd1VRQjZET1dHaGRFMFFkdTNzOE5x?= =?utf-8?B?VHZ5c2xFMEdxaEI5cGI4R0pxMHdoVG9TS1ZpSGRnNk1rMkNTSGIxWlhsVElq?= =?utf-8?B?ZFdpOEUxb2FtdEpPRHpucVd3TXU2cTJYbTMvZmdwOXUwZFdtV1ljNU41K0d5?= =?utf-8?Q?/ljmh10Gm3jEj/+5Um8ubo6iDqjkBqo4mTxbxqdyy?= X-Microsoft-Exchange-Diagnostics: 1;BN3PR1201MB0914;6:2NOxkuccYut9uXIt6MheWH1ZNqhm7CvO3TALBc8sAw0JjkUblreDEkDpzSGtOUwkhM44AozeSWZiJ0QfwJISlA83lgAq4AtQtsdjd1kP8cImHimwyN2RFhlOmxtwuL3j6+2AROXezECOsWbJc2DATR2Ul7lSM7pGQT8IpOy4afY0q3Ed5WvzWyyRSdPtwOtddJXUEoJeIToEfn3PNSt4cIYSnGxkX2nXS9w+HydQLfRNophzYIlIv9ERHj8pOPX3xvY0TdNth0sy7LA1RrroLADyQb9bR4l3CZkvNUVEiY9+exirhlvikmdFGqNEzsWR6eLJKtWJSb9NI8KCZzK+Uw==;5:P1IINL8jr7kkc3jXy718z26OorwSTr3SjH83cYl/02/TaOZuG0Ew5zwX0WInLCiwDdae3wQrhxRzTySgVtT5hp2XT78DtFGCOW7aF9UUCngB8Bc0R2C7Cu6galcYX4wmHZj6J+kLDEGAxajT0duEWg==;24:zsBkcIleGLPtqOfYBb4FXQMh2W1H0vUd05IiZU9Vo+8F9zfk2VVcSmnT9N4Q54H7IxTKETK3ikmZDh5n0FxZOCirY2NXFkSjxh1GRiigqNM=;7:htNJJzCrbUlRsy5kaNOubxUUy5aan1fzWl1/uVwreUIfekFicRe17kqSc9Zs6/7BnAxcv3osdc7pM5Kjr8unekXhQK9mmmQ2U3q1EauqzwYgUm8T2aH3+wmK+8eAbNmXe7xC7mAyFOpZghObhavFHNx2sk7UgTZ+LNJsQ3kzRQ9DjUEaJyhhQMKI/f6HPCMllL3pp1v56csci05gE4MZ+EgPFFDc+Y1KhsRD3pN6ueJOl/0uzCIqQHcIwOa3ijyu SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BN3PR1201MB0914;20:usDpNrZgekhwylSn871mbQC34iO4iS4CnWNBlX/i0aFuMckQMzmEuxrxT2EkKbMcubL/OiLWFHFcslC7aj2uV+M07hNdRNLjSTksusWPMdaVF+VVeCPmtzN3sSI57pczVWpKVipEHyoaELWqHSvWhI1WjfpMeP8lEP85Hwts2X6NFMbmrjHb/JOaFpDfiPKqIsQkLEsh9+1teiYh2E/S3sibf21Zch+Rhw87oQ1GlOQjRMf1V6jQ1iB+9Lsreun8 X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jul 2016 07:43:40.7407 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR1201MB0914 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 07.07.2016 um 05:32 schrieb Michel Dänzer: > On 06.07.2016 22:45, Tejun Heo wrote: >> On Wed, Jul 06, 2016 at 12:12:52PM +0900, Michel Dänzer wrote: >> >>> Not being very familiar with the workqueue APIs, I'll describe how it's >>> supposed to work from a driver POV, which will hopefully help you guys >>> decide on the most appropriate alloc_workqueue parameters. >>> >>> There is one flip work queue for each hardware CRTC. At most one >>> radeon_flip_work_func item can be queued for any of them at any time. >>> When a radeon_flip_work_func item is queued, it should be executed ASAP >>> (so WQ_HIGHPRI might be appropriate?). >> Hmmm... the only time WQ_HIGHPRI should be used is when it'd otherwise >> require a kthread w/ nice value at -20. Would that be the case here? >> What are the consequences of the work item getting delayed? > A page flip may be delayed to a later display refresh cycle. > > >> Also, what kind of delays matter here? Is it millisec range or micro? > It can be the latter in theory, but normally rather the former. Well to be precise with a typical 1920x1080@60 resolution you have about 2.16ms time under ideal conditions for the flip. So using the high priority queue still sounds like a good idea to me. Regards, Christian.