From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752166AbcGGJvz (ORCPT ); Thu, 7 Jul 2016 05:51:55 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:34168 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751977AbcGGJvx (ORCPT ); Thu, 7 Jul 2016 05:51:53 -0400 Subject: Re: [PATCH] vme: make core vme support explicitly non-modular To: Paul Gortmaker , linux-kernel@vger.kernel.org References: <20160703180556.28562-1-paul.gortmaker@windriver.com> Cc: Martyn Welch , Manohar Vanga , Greg Kroah-Hartman , devel@driverdev.osuosl.org From: Martyn Welch Message-ID: <577E262F.2030200@gmail.com> Date: Thu, 7 Jul 2016 10:51:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Icedove/38.7.0 MIME-Version: 1.0 In-Reply-To: <20160703180556.28562-1-paul.gortmaker@windriver.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/07/16 19:05, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > drivers/vme/Kconfig:menuconfig VME_BUS > drivers/vme/Kconfig: bool "VME bridge support" > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > We replace module.h and moduleparam.h (unused) with init.h and also > export.h ; the latter since this file does export some syms. > > Since this is a struct bus_type and not a platform_driver, we don't > have any ".suppress_bind_attrs" to be concerned about when we > drop the ".remove" code from this file. > > Since module_init was not in use by this code, the init ordering > remains unchanged with this commit. > > Cc: Martyn Welch > Cc: Manohar Vanga > Cc: Greg Kroah-Hartman > Cc: devel@driverdev.osuosl.org > Signed-off-by: Paul Gortmaker Acked-by: Martyn Welch > --- > drivers/vme/vme.c | 27 ++------------------------- > 1 file changed, 2 insertions(+), 25 deletions(-) > > diff --git a/drivers/vme/vme.c b/drivers/vme/vme.c > index 37ac0a58e59a..557149f0f88a 100644 > --- a/drivers/vme/vme.c > +++ b/drivers/vme/vme.c > @@ -13,8 +13,8 @@ > * option) any later version. > */ > > -#include > -#include > +#include > +#include > #include > #include > #include > @@ -39,7 +39,6 @@ static unsigned int vme_bus_numbers; > static LIST_HEAD(vme_bus_list); > static DEFINE_MUTEX(vme_buses_lock); > > -static void __exit vme_exit(void); > static int __init vme_init(void); > > static struct vme_dev *dev_to_vme_dev(struct device *dev) > @@ -1622,25 +1621,10 @@ static int vme_bus_probe(struct device *dev) > return retval; > } > > -static int vme_bus_remove(struct device *dev) > -{ > - int retval = -ENODEV; > - struct vme_driver *driver; > - struct vme_dev *vdev = dev_to_vme_dev(dev); > - > - driver = dev->platform_data; > - > - if (driver->remove != NULL) > - retval = driver->remove(vdev); > - > - return retval; > -} > - > struct bus_type vme_bus_type = { > .name = "vme", > .match = vme_bus_match, > .probe = vme_bus_probe, > - .remove = vme_bus_remove, > }; > EXPORT_SYMBOL(vme_bus_type); > > @@ -1648,11 +1632,4 @@ static int __init vme_init(void) > { > return bus_register(&vme_bus_type); > } > - > -static void __exit vme_exit(void) > -{ > - bus_unregister(&vme_bus_type); > -} > - > subsys_initcall(vme_init); > -module_exit(vme_exit);