From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752551AbcGGK0M (ORCPT <rfc822;w@1wt.eu>);
	Thu, 7 Jul 2016 06:26:12 -0400
Received: from smtp.citrix.com ([66.165.176.89]:37476 "EHLO SMTP.CITRIX.COM"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751494AbcGGK0L (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Thu, 7 Jul 2016 06:26:11 -0400
X-IronPort-AV: E=Sophos;i="5.28,324,1464652800"; 
   d="scan'208";a="364805166"
Subject: Re: [Xen-devel] [PATCH] xen-blkback: prefer xenbus_write() over
 xenbus_printf() where possible
To: Jan Beulich <JBeulich@suse.com>, Roger Pau Monne <roger.pau@citrix.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
References: <577E299402000078000FBF24@prv-mh.provo.novell.com>
CC: <xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org>
From: David Vrabel <david.vrabel@citrix.com>
Message-ID: <577E2E3A.60803@citrix.com>
Date: Thu, 7 Jul 2016 11:26:02 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Icedove/38.5.0
MIME-Version: 1.0
In-Reply-To: <577E299402000078000FBF24@prv-mh.provo.novell.com>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
X-DLP: MIA2
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/07/16 09:06, Jan Beulich wrote:
> ... as being the simpler variant.
[...]
> --- 4.7-rc6-prefer-xenbus_write.orig/drivers/block/xen-blkback/xenbus.c
> +++ 4.7-rc6-prefer-xenbus_write/drivers/block/xen-blkback/xenbus.c
> @@ -617,9 +617,9 @@ static int xen_blkbk_probe(struct xenbus
>  		goto fail;
>  	}
>  
> -	err = xenbus_printf(XBT_NIL, dev->nodename,
> -			    "feature-max-indirect-segments", "%u",
> -			    MAX_INDIRECT_SEGMENTS);
> +	err = xenbus_write(XBT_NIL, dev->nodename,
> +			   "feature-max-indirect-segments",
> +			   __stringify(MAX_INDIRECT_SEGMENTS));

Yuk :(

Now someone has to check both __stringify() and MAX_INDIRECT_SEGMENTS to
work out what this actually looks like.

David