From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756041AbcGGK1V (ORCPT <rfc822;w@1wt.eu>);
	Thu, 7 Jul 2016 06:27:21 -0400
Received: from mailout1.w1.samsung.com ([210.118.77.11]:37162 "EHLO
	mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751580AbcGGK07 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 7 Jul 2016 06:26:59 -0400
X-AuditID: cbfec7f4-f796c6d000001486-33-577e2e70ae07
Subject: Re: [PATCH v3 2/2] clk: samsung: exynos7: Add clocks for atlas block
To: Abhilash Kesavan <a.kesavan@samsung.com>
References: <1467750561-13957-1-git-send-email-a.kesavan@samsung.com>
 <1467750561-13957-3-git-send-email-a.kesavan@samsung.com>
Cc: tomasz.figa@gmail.com, kgene.kim@samsung.com, k.kozlowski@samsung.com,
        b.zolnierkie@samsung.com, mturquette@baylibre.com,
        sboyd@codeaurora.org, linux-samsung-soc@vger.kernel.org,
        linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
From: Sylwester Nawrocki <s.nawrocki@samsung.com>
Message-id: <577E2E6E.3040809@samsung.com>
Date: Thu, 07 Jul 2016 12:26:54 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.6.0
MIME-version: 1.0
In-reply-to: <1467750561-13957-3-git-send-email-a.kesavan@samsung.com>
Content-type: text/plain; charset=windows-1252
Content-transfer-encoding: 7bit
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrALMWRmVeSWpSXmKPExsVy+t/xa7oFenXhBr86lS0er1nMZLFxxnpW
	i9cvDC16F1xls9j0+Bqrxceee6wWl3fNYbOYcX4fk8XFU64WP850s1is2vWH0YHb4/2NVnaP
	y329TB47Z91l99i8pN6jb8sqRo/Pm+QC2KK4bFJSczLLUov07RK4Mr53vGYpOMNecXaZbgNj
	D1sXIyeHhICJxOIpS6FsMYkL99YD2VwcQgJLGSUeHzvKApIQEnjOKDHvpjKILSzgK7HySDNY
	g4iAjsTjOT2MEA2NjBLzz7aAdTMLzGKSOPXpISNIFZuAoUTv0T4wm1dAS+Lno9lgNouAqsSh
	Hx/BJokKREg8mXsSqkZQ4sfke2CbOQXcJI62PGHtYuQAGqoncf+iFkiYWUBeYvOat8wTGAVm
	IemYhVA1C0nVAkbmVYyiqaXJBcVJ6bmGesWJucWleel6yfm5mxgh8fBlB+PiY1aHGAU4GJV4
	eBfk1IYLsSaWFVfmHmKU4GBWEuHdq1MXLsSbklhZlVqUH19UmpNafIhRmoNFSZx37q73IUIC
	6YklqdmpqQWpRTBZJg5OqQbGpluqM17YPfLYPHXlXf2wqUy9yikzFjQESIXdWf/f6FBWQ2XO
	28Dtdzzlbgpm1pRGV7RMEJ3j/Msg4ZuEpKPp68lBFUd/SSaJbpA1FPHUcOMJXLb+TOv9j+bJ
	cW+ntjOffCe4VsLk5QfXX67frFpfbru7fN72Z1/TLf9Fqj9ZfMJftqp3klCiEktxRqKhFnNR
	cSIAGYGs44MCAAA=
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 07/05/2016 10:29 PM, Abhilash Kesavan wrote:

> +static const struct samsung_pll_rate_table pll1450x_24mhz_tbl[] = {
> +	/* rate, m, p, s */
> +	PLL_35XX_RATE(2496000000, 208, 2, 0),

Please add U postfix to these constants to address compiler warning
as reported by kbuild-all@01.org:

>> drivers/clk/samsung/clk-exynos7.c:43:2: warning: this decimal constant is
unsigned only in ISO C90
     PLL_35XX_RATE(2496000000, 208, 2, 0),
     ^~~~~~~~~~~~~


> +static void __init exynos7_clk_atlas_init(struct device_node *np)
> +{
> +	void __iomem *reg_base;
> +	struct samsung_clk_provider *ctx;
> +
> +	reg_base = of_iomap(np, 0);
> +	if (!reg_base) {
> +		panic("%s: failed to map registers\n", __func__);
> +		return;
> +	}
> +
> +	ctx = samsung_clk_init(np, reg_base, ATLAS_NR_CLK);
> +	if (!ctx) {
> +		panic("%s: unable to allocate ctx\n", __func__);

You can remove this panic() call, there is already one inside
samsung_clk_init().