From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751853AbcGGNMs (ORCPT ); Thu, 7 Jul 2016 09:12:48 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:9582 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751162AbcGGNMf (ORCPT ); Thu, 7 Jul 2016 09:12:35 -0400 X-AuditID: cbfec7f4-f796c6d000001486-68-577e554007de Subject: Re: [PATCH 06/10] clk: samsung make clk-exynos-audss explicitly non-modular To: Paul Gortmaker References: <20160704211220.5685-1-paul.gortmaker@windriver.com> <20160704211220.5685-7-paul.gortmaker@windriver.com> Cc: linux-kernel@vger.kernel.org, Tomasz Figa , Michael Turquette , Stephen Boyd , Kukjin Kim , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org From: Sylwester Nawrocki Message-id: <577E553E.5020801@samsung.com> Date: Thu, 07 Jul 2016 15:12:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-version: 1.0 In-reply-to: <20160704211220.5685-7-paul.gortmaker@windriver.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrNLMWRmVeSWpSXmKPExsVy+t/xy7oOoXXhBm/38Vq8fmFo0f/4NbPF x557rBaXd81hs5hxfh+TxcVTrhbX9h5ntvhxppvFYtWuP4wOnB7vb7Sye1zu62Xy2DnrLrvH plWdbB59W1YxenzeJOexfstWpgD2KC6blNSczLLUIn27BK6MU1deMxUc4q6Y+uM0SwPjes4u Rk4OCQETieVt81ggbDGJC/fWs4HYQgJLGSXeLynvYuQCsp8zSrz9MB0sISwQJnFh8QdWEFtE wFBi2ZsNQDYHUFG5xMnX5iD1zAKrmSQ+LJ3PDFLDBlTTe7SPEcTmFdCS6Lm2HCzOIqAqcWXx MnYQW1QgQuLJ3JNQNYISPybfAzuIU8BR4nd7ExvIfGYBPYn7F7VAwswC8hKb17xlnsAoMAtJ xyyEqllIqhYwMq9iFE0tTS4oTkrPNdQrTswtLs1L10vOz93ECImCLzsYFx+zOsQowMGoxMO7 IKc2XIg1say4MvcQowQHs5IIb4h/XbgQb0piZVVqUX58UWlOavEhRmkOFiVx3rm73ocICaQn lqRmp6YWpBbBZJk4OKUaGLV+GLj4fb+1gdfq1zeFxTXxQT0vf3B9WfS/e2doWJqt0kzWPOPf fQweMjtuRE8ojG1O+y/xb0X+sUkfusu+CFosOVTquSEjW/wI0y6567bVaeeZdnnYf0zOa1d6 VrSn4/4HF46nO5tm+z46VhmyhytEVu2cW43QpkuiCpHWzQFfPs62i/h0TomlOCPRUIu5qDgR AMIm4Dx+AgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/04/2016 11:12 PM, Paul Gortmaker wrote: > The Kconfig currently controlling compilation of this code is: > > arch/arm/mach-exynos/Kconfig:menuconfig ARCH_EXYNOS > arch/arm/mach-exynos/Kconfig: bool "Samsung EXYNOS" if ARCH_MULTI_V7 > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the couple traces of modularity so that when reading the > driver there is no doubt it is builtin-only. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_init was already not used by this code, the init ordering > remains unchanged with this commit. > > We also delete the MODULE_LICENSE tags etc. since all that information > is already contained at the top of the file in the comments. > > Signed-off-by: Paul Gortmaker > --- > #include > @@ -278,14 +278,3 @@ static int __init exynos_audss_clk_init(void) > return platform_driver_register(&exynos_audss_clk_driver); > } > core_initcall(exynos_audss_clk_init); Thanks for the patch. I will try to get rid of the above initcall instead of removing module support. Any clock dependencies should now be handled properly with deferred probing. And the module support will be useful since the audss clock controller is present only on selected Exynos SoC variants.