From: Jens Axboe <axboe@kernel.dk>
To: Arnd Bergmann <arnd@arndb.de>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>
Cc: Jens Axboe <axboe@fb.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme-loop: add configfs dependency
Date: Thu, 7 Jul 2016 08:35:17 -0600 [thread overview]
Message-ID: <577E68A5.8080709@kernel.dk> (raw)
In-Reply-To: <20160707090144.3061799-1-arnd@arndb.de>
On 07/07/2016 03:01 AM, Arnd Bergmann wrote:
> CONFIG_NVME_TARGET has a correct CONFIG_CONFIGFS_FS dependency, but the
> newly added NVME_TARGET_LOOP is missing this, resulting in a link
> failure:
>
> drivers/nvme/built-in.o: In function `nvmet_init_configfs':
> loop.c:(.init.text+0x2a0): undefined reference to `config_group_init'
> loop.c:(.init.text+0x2c0): undefined reference to `config_group_init_type_name'
> loop.c:(.init.text+0x318): undefined reference to `configfs_register_subsystem'
> drivers/nvme/built-in.o: In function `nvmet_exit_configfs':
> loop.c:(.exit.text+0x9c): undefined reference to `configfs_unregister_subsystem'
>
> This adds the same dependency here.
Thanks Arnd, applied.
--
Jens Axboe
next prev parent reply other threads:[~2016-07-07 14:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 9:01 [PATCH] nvme-loop: add configfs dependency Arnd Bergmann
2016-07-07 14:35 ` Jens Axboe [this message]
2016-07-10 12:14 ` Christoph Hellwig
2016-07-11 16:12 ` J Freyensee
2016-07-11 20:29 ` Arnd Bergmann
2016-07-12 15:36 ` Jens Axboe
2016-07-12 15:38 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577E68A5.8080709@kernel.dk \
--to=axboe@kernel.dk \
--cc=arnd@arndb.de \
--cc=axboe@fb.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).