From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751975AbcGGOfX (ORCPT ); Thu, 7 Jul 2016 10:35:23 -0400 Received: from mail-it0-f44.google.com ([209.85.214.44]:38865 "EHLO mail-it0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750899AbcGGOfU (ORCPT ); Thu, 7 Jul 2016 10:35:20 -0400 Subject: Re: [PATCH] nvme-loop: add configfs dependency To: Arnd Bergmann , Christoph Hellwig , Sagi Grimberg References: <20160707090144.3061799-1-arnd@arndb.de> Cc: Jens Axboe , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org From: Jens Axboe Message-ID: <577E68A5.8080709@kernel.dk> Date: Thu, 7 Jul 2016 08:35:17 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <20160707090144.3061799-1-arnd@arndb.de> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/07/2016 03:01 AM, Arnd Bergmann wrote: > CONFIG_NVME_TARGET has a correct CONFIG_CONFIGFS_FS dependency, but the > newly added NVME_TARGET_LOOP is missing this, resulting in a link > failure: > > drivers/nvme/built-in.o: In function `nvmet_init_configfs': > loop.c:(.init.text+0x2a0): undefined reference to `config_group_init' > loop.c:(.init.text+0x2c0): undefined reference to `config_group_init_type_name' > loop.c:(.init.text+0x318): undefined reference to `configfs_register_subsystem' > drivers/nvme/built-in.o: In function `nvmet_exit_configfs': > loop.c:(.exit.text+0x9c): undefined reference to `configfs_unregister_subsystem' > > This adds the same dependency here. Thanks Arnd, applied. -- Jens Axboe