From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755067AbcGHMvf (ORCPT ); Fri, 8 Jul 2016 08:51:35 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:21455 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754755AbcGHMv1 (ORCPT ); Fri, 8 Jul 2016 08:51:27 -0400 X-AuditID: cbfec7f5-f792a6d000001302-9e-577fa1cc473f Subject: Re: [PATCH 2/4] bindings: spi-samsung: add exynos5433 spi compatible To: Andi Shyti , Mark Brown References: <1467980304-14093-1-git-send-email-andi.shyti@samsung.com> <1467980304-14093-3-git-send-email-andi.shyti@samsung.com> Cc: Sylwester Nawrocki , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti From: Krzysztof Kozlowski Message-id: <577FA1CB.30805@samsung.com> Date: Fri, 08 Jul 2016 14:51:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1467980304-14093-3-git-send-email-andi.shyti@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrBLMWRmVeSWpSXmKPExsVy+t/xa7pnFtaHGxy+IGex/cgzVovFP54z WUx9+ITN4vULQ4v+x6+ZLTY9vsZqcXnXHDaLGef3MVk0frzJbnH4TTurA5fH9SWfmD02repk 89i8pN6jb8sqRo/Pm+QCWKO4bFJSczLLUov07RK4MronTGUraOSpuDP1DEsD4zvOLkZODgkB E4kvk/awQthiEhfurWfrYuTiEBJYyiix+/4tZgjnGaPEmoNn2ECqhAV8JY48aAGzRQQ8JFZs a2UHsYUEmhkl3r3zAmlgFvjKKNG56yPYWDYBY4nNy5eANfAKaEhMOrudCcRmEVCV+DPtD5gt KhAhMWv7DyaIGkGJH5PvsYDYnALuEq9mXwZawAE0VE/i/kUtkDCzgLzE5jVvmScwCsxC0jEL oWoWkqoFjMyrGEVTS5MLipPSc430ihNzi0vz0vWS83M3MULC/+sOxqXHrA4xCnAwKvHw3hCp DxdiTSwrrsw9xCjBwawkwrthAVCINyWxsiq1KD++qDQntfgQozQHi5I478xd70OEBNITS1Kz U1MLUotgskwcnFINjO5xF0797J4WtTy24+yRD7qvW5ZcZtKTXe9xOzv7IOvdE1ev/lvy4qvm a3XHWV0ivQu8c4t+xC8J5tPcfJrngvEZpglrP/z8VSpTrcbN0NsguZL11avQtXafWQXzqhif TXiZkRig0vDmUmuOvsfhZRmPj+yrmf8mbGGzv1vZliPdYiE127/vqVdiKc5INNRiLipOBACs zxL3ewIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/08/2016 02:18 PM, Andi Shyti wrote: > The samsung,exynos5433-spi has some peculiarities that bring the > need of creating a new compatible in the binding. That is not accurate. This for both: exynos5433 and exynos7. > > One of those is the 3-clocks controller management where the spi > is fed with three clocks: "spi", "busclkN" and "ioclk". > > Signed-off-by: Andi Shyti > --- > Documentation/devicetree/bindings/spi/spi-samsung.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/spi/spi-samsung.txt b/Documentation/devicetree/bindings/spi/spi-samsung.txt > index 6dbdeb3..d4294c7 100644 > --- a/Documentation/devicetree/bindings/spi/spi-samsung.txt > +++ b/Documentation/devicetree/bindings/spi/spi-samsung.txt > @@ -10,6 +10,7 @@ Required SoC Specific Properties: > - samsung,s3c6410-spi: for s3c6410 platforms > - samsung,s5pv210-spi: for s5pv210 and s5pc110 platforms > - samsung,exynos7-spi: for exynos7 platforms > + - samsung,exynos5433-spi: for exynos5433 compatible controllers As I wrote offline, proper order (alpha-numerical), so 5 before 7. > > - reg: physical base address of the controller and length of memory mapped > region. > Thanks for the patch, nice work. I see that you ignored parts of my offline comments so I guess you leave that work to others (describe required clock properties, deprecate exynos7-spi). I'll send the follow up then. Best regards, Krzysztof