From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755266AbcGHMwz (ORCPT ); Fri, 8 Jul 2016 08:52:55 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:51156 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755144AbcGHMwr (ORCPT ); Fri, 8 Jul 2016 08:52:47 -0400 X-AuditID: cbfec7f5-f792a6d000001302-c9-577fa21c9c2b Subject: Re: [PATCH 4/4] spi: s3c64xx: restore removed comments To: Andi Shyti , Mark Brown References: <1467980304-14093-1-git-send-email-andi.shyti@samsung.com> <1467980304-14093-5-git-send-email-andi.shyti@samsung.com> Cc: Sylwester Nawrocki , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti From: Krzysztof Kozlowski Message-id: <577FA21A.8020900@samsung.com> Date: Fri, 08 Jul 2016 14:52:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1467980304-14093-5-git-send-email-andi.shyti@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJLMWRmVeSWpSXmKPExsVy+t/xa7oyi+rDDVbd4LbYfuQZq8XiH8+Z LKY+fMJm8fqFoUX/49fMFpseX2O1uLxrDpvFjPP7mCwaP95ktzj8pp3Vgcvj+pJPzB6bVnWy eWxeUu/Rt2UVo8fnTXIBrFFcNimpOZllqUX6dglcGZ//v2YtaOCouPdxIXMD4062LkZODgkB E4mVZ9ZC2WISF+6tB7K5OIQEljJKPP18kgXCecYoserFOVaQKmEBe4nd+46zgNgiAh4SK7a1 skMUNTNKTLyyHKydWeAro0Tnro9gHWwCxhKbly8B28EroCWx/edRZhCbRUBV4s/HI0wgtqhA hMSs7T+YIGoEJX5Mvge2gVPAXeJ0222gDRxAQ/Uk7l/UAgkzC8hLbF7zlnkCo8AsJB2zEKpm IalawMi8ilE0tTS5oDgpPddIrzgxt7g0L10vOT93EyMkAr7uYFx6zOoQowAHoxIP7w2R+nAh 1sSy4srcQ4wSHMxKIrwbFgCFeFMSK6tSi/Lji0pzUosPMUpzsCiJ887c9T5ESCA9sSQ1OzW1 ILUIJsvEwSnVwFioIbxhTbCB1MO0yfkpz++F/2y2v6X/VFvggUBlzgvpjYGTFtZMdbSoVlrw UeFKsRT/2m8lVnMuzdY6I73vTb5z//o1IuX+zq95TnR9fdHxR+yk98n81YkOtk+u+5y66Xj9 mqVg59ZDgbpsE1puClwvuvXqieWXCS/lpV5dmcvPqnkk1sdu3XUlluKMREMt5qLiRABuXfeg fAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/08/2016 02:18 PM, Andi Shyti wrote: > Patch a9e93e8 has erroneously removed some comments which are > important to understand why the bus frequency is multiplied by > two during the spi transfer. > > Signed-off-by: Andi Shyti > --- > drivers/spi/spi-s3c64xx.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > index 1874bc5..d1fe100 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -639,6 +639,8 @@ static void s3c64xx_spi_config(struct s3c64xx_spi_driver_data *sdd) > writel(val, regs + S3C64XX_SPI_MODE_CFG); > > if (sdd->port_conf->clk_from_cmu) { > + /* Configure Clock */ > + /* There is half-multiplier before the SPI */ Not a kernel coding style comment. :) Either proper one or just skip the "configure clock" as it is meaningless. BR, Krzysztof > clk_set_rate(sdd->src_clk, sdd->cur_speed * 2); > } else { > /* Configure Clock */ >