From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755360AbcGHNBC (ORCPT ); Fri, 8 Jul 2016 09:01:02 -0400 Received: from mailout3.w1.samsung.com ([210.118.77.13]:61599 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754868AbcGHNAw (ORCPT ); Fri, 8 Jul 2016 09:00:52 -0400 X-AuditID: cbfec7f4-f796c6d000001486-2b-577fa4008f5e Subject: Re: [PATCH 2/4] bindings: spi-samsung: add exynos5433 spi compatible To: Andi Shyti References: <1467980304-14093-1-git-send-email-andi.shyti@samsung.com> <1467980304-14093-3-git-send-email-andi.shyti@samsung.com> <577FA1CB.30805@samsung.com> <20160708125648.GK23620@samsunx.samsung> Cc: Mark Brown , Sylwester Nawrocki , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti From: Krzysztof Kozlowski Message-id: <577FA3FF.90208@samsung.com> Date: Fri, 08 Jul 2016 15:00:47 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <20160708125648.GK23620@samsunx.samsung> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrGLMWRmVeSWpSXmKPExsVy+t/xq7oMS+rDDU59VbbYfuQZq8XiH8+Z LKY+fMJm8fqFoUX/49fMFpseX2O1uLxrDpvFjPP7mCwaP95ktzj8pp3Vgcvj+pJPzB6bVnWy eWxeUu/Rt2UVo8fnTXIBrFFcNimpOZllqUX6dglcGe++nmAtaGKtWHDzBWsD4zfmLkYODgkB E4mJd026GDmBTDGJC/fWs3UxcnEICSxllHh8+RyU84xRYv7ynYwgVcICvhJHHrSwgdgiAuoS S/ZuZQaxhQTmM0l8atIBaWAWmAFkv/gIVsQmYCyxefkSNpBtvAIaEmuvh4CEWQRUJbbubWIF sUUFIiRmbf/BBGLzCghK/Jh8jwXE5hQwlTjZdgOslVlAT+L+RS2QMLOAvMTmNW+ZJzAKzELS MQuhahaSqgWMzKsYRVNLkwuKk9JzDfWKE3OLS/PS9ZLzczcxQkL/yw7GxcesDjEKcDAq8fAa iNeHC7EmlhVX5h5ilOBgVhLh3bAAKMSbklhZlVqUH19UmpNafIhRmoNFSZx37q73IUIC6Ykl qdmpqQWpRTBZJg5OqQbGxT0c2+LaC/doSzhcNO3d8/E39+SXH97vf1xmtlPmVu3K43ZRN15k fLtoczXo3K0bTYLbV2VNzDNVMTph+maRx2O59SdudHpNmJt/suXT05b3BUtWWi2YNelc7Y+W h0bC4l6OHcxNfB9fnPpmu6PAaHfVWoMLd4903o163NWSm3174h3rNYeV3ymxFGckGmoxFxUn AgDGDSJseQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/08/2016 02:56 PM, Andi Shyti wrote: >>> >>> - reg: physical base address of the controller and length of memory mapped >>> region. >>> >> >> Thanks for the patch, nice work. I see that you ignored parts of my >> offline comments so I guess you leave that work to others (describe >> required clock properties, deprecate exynos7-spi). I'll send the follow >> up then. > > I was actually doing the follow up, I think it's a different > concept and therefore goes on a different patch. Ah.... but the exynos5433-spi compatible is related to three clocks - you even mention it in commit message. BR, Krzysztof