From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755436AbcGHNNE (ORCPT ); Fri, 8 Jul 2016 09:13:04 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:52379 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755375AbcGHNMx (ORCPT ); Fri, 8 Jul 2016 09:12:53 -0400 X-AuditID: cbfec7f4-f796c6d000001486-b9-577fa6d27814 Subject: Re: [PATCH 1/4] spi: s3c64xx: rename goto labels to meaningful names To: Andi Shyti , Mark Brown References: <1467980304-14093-1-git-send-email-andi.shyti@samsung.com> <1467980304-14093-2-git-send-email-andi.shyti@samsung.com> <577FA677.7090708@samsung.com> Cc: Sylwester Nawrocki , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Shyti From: Krzysztof Kozlowski Message-id: <577FA6D0.2070403@samsung.com> Date: Fri, 08 Jul 2016 15:12:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <577FA677.7090708@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrJLMWRmVeSWpSXmKPExsVy+t/xy7qXltWHG+w8z2Wx/cgzVovFP54z WUx9+ITN4vULQ4v+x6+ZLTY9vsZqcXnXHDaLGef3MVk0frzJbnH4TTurA5fH9SWfmD02repk 89i8pN6jb8sqRo/Pm+QCWKO4bFJSczLLUov07RK4Mtb+XsJcsJGl4v2ES8wNjKuZuxg5OSQE TCTuLtrACmGLSVy4t56ti5GLQ0hgKaPE3rYuVgjnGaPE47aDTCBVwgK+EhdXvgWzRQQ8JFZs a2WHKFrCKPH5+GSwdmaBr4wSnbs+gs1lEzCW2Lx8CRuIzSugJbFv4UqwOIuAqsTk1r9gd4gK REjM2v6DCaJGUOLH5HssIDangLbE7QNzgHo5gIbqSdy/qAUSZhaQl9i85i3zBEaBWUg6ZiFU zUJStYCReRWjaGppckFxUnquoV5xYm5xaV66XnJ+7iZGSAR82cG4+JjVIUYBDkYlHl4D8fpw IdbEsuLK3EOMEhzMSiK8yUuBQrwpiZVVqUX58UWlOanFhxilOViUxHnn7nofIiSQnliSmp2a WpBaBJNl4uCUamDMU4wIXjvDe129/aITPKsNFyxo/5astEmy+Uu+RVXkoldnZ/oduN1VmdYz dVq0lZlM19+rOwQlZqoq7rsq/mHnB5HnUV68nP28Z44/Sbo87Yr4U9PNU+/0eh6yeWAv5aCh Ud8uFLTr5iXLx61Wvx3dJ/6dtPHhpWP3diXJxT58pXfRcrt7sWGUEktxRqKhFnNRcSIAvntQ o3wCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/08/2016 03:11 PM, Krzysztof Kozlowski wrote: > On 07/08/2016 02:18 PM, Andi Shyti wrote: >> In goto labels of the style of > > s/In/The/ > >> >> err4: >> err3: >> err2: >> err1: >> >> is complex to insert in between new errors without renaming all > > s/is/are/ (or just rewrite it... "The style of such goto labels... is") > >> the goto statments. Replace the errX naming style to meaningful > > s/statments/satements/ Yeah, nice job (to me)... error in error correction. Of course "statements"... BR, Krzysztof