From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755431AbcGHNY6 (ORCPT ); Fri, 8 Jul 2016 09:24:58 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:23398 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754903AbcGHNYt (ORCPT ); Fri, 8 Jul 2016 09:24:49 -0400 X-AuditID: cbfec7f4-f796c6d000001486-b3-577fa99e5076 Subject: Re: [PATCH v5] clk: exynos5433: remove CLK_IGNORE_UNUSED flag from SPI clocks To: Andi Shyti , Chanwoo Choi , Sylwester Nawrocki References: <1467982058-14339-1-git-send-email-andi.shyti@samsung.com> Cc: Jaehoon Chung , Tomasz Figa , Michael Turquette , Stephen Boyd , Kukjin Kim , linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Andi Shyti From: Krzysztof Kozlowski Message-id: <577FA99C.9020600@samsung.com> Date: Fri, 08 Jul 2016 15:24:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-version: 1.0 In-reply-to: <1467982058-14339-1-git-send-email-andi.shyti@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupkkeLIzCtJLcpLzFFi42I5/e/4Nd15K+vDDR4cU7TYfuQZq8XiH8+Z LK5/ec5qceNXG6vF6xeGFv2PXzNbbHp8jdXiY889VovLu+awWcw4v4/J4uIpV4vDb9pZLX6c 6WaxWLXrD6MDn8f7G63sHpf7epk8ri/5xOyxc9Zddo9NqzrZPDYvqffo27KK0ePzJrkAjigu m5TUnMyy1CJ9uwSujC0P7rEXbOOueL1+AWsDYz9nFyMnh4SAicS5E9PZIWwxiQv31rN1MXJx CAksZZTo3viDDSQhJPCMUWL1eWYQW1ggQuLb5+dgDSICNRKXTz5jhahxk/jQsZEFpJlZ4C2T xI4bnYwgCTYBY4nNy5eADeIV0JL4u3QKWJxFQFXiw78XYLYo0NBZ238wQdQISvyYfI8FxOYU cJe4/+8IkM0BNFRP4v5FLZAws4C8xOY1b5knMArMQtIxC6FqFpKqBYzMqxhFU0uTC4qT0nMN 9YoTc4tL89L1kvNzNzFCIujLDsbFx6wOMQpwMCrx8BqI14cLsSaWFVfmHmKU4GBWEuFNXgoU 4k1JrKxKLcqPLyrNSS0+xCjNwaIkzjt31/sQIYH0xJLU7NTUgtQimCwTB6dUA2PWo8uylsqz DiTV21hfyalf51Z35nHjQZl4v2uhexsKcpYuq4lbuvNTSOHsmJ5TQROjPj5/YOa03HPP+p4m D7e1B15zqC/de62Q+WzxBdMH395a7o1Y2F9fGZD5yicwZ9fLwwfSZ6wUDblmEmxwLH3v6i+r e/wjUg6vb86yEZV9lJvR89PM86YSS3FGoqEWc1FxIgD8pJoBnAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/08/2016 02:47 PM, Andi Shyti wrote: > Commit b82ec4e and a9e93e8 have added support in the spi device > driver for the three clock lines required by the SPI controller > and handles the dependency between the three (by not disabling > any after resume). > > This way none of the SPI clocks require any criticality: remove, > then the CLK_IGNORE_UNUSED flag for the SPI related clocks. > > Signed-off-by: Andi Shyti > --- > > Hi, > > With this, I hope to have reached the end of this patch series :) > > After some discussions with Tomasz first and Sylwester later, we > agreed to move all the clock management to the spi driver, here > are the patches that do that: > > http://marc.info/?l=linux-kernel&m=146787645626318&w=2 > http://marc.info/?l=linux-kernel&m=146798033221943&w=2 > > With the above modifications to the spi driver we don't need any > of the SPI related clocks to be marked either as critical or as > ignore unused. > > Thanks, > Andi > > drivers/clk/samsung/clk-exynos5433.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > Patch is okay: Reviewed-by: Krzysztof Kozlowski but I think this should not go in separately. This should be part of SPI-related changes which add proper ioclk consumer to the SPI driver. Without these changes, as you said to me, synchronous abort will happen. Best regards, Krzysztof