From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755490AbcGHPmv (ORCPT ); Fri, 8 Jul 2016 11:42:51 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:57497 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754881AbcGHPmn (ORCPT ); Fri, 8 Jul 2016 11:42:43 -0400 X-IronPort-AV: E=Sophos;i="5.28,330,1464652800"; d="scan'208";a="372054969" Subject: Re: [Xen-devel] [PATCH v2 0/4] xen: prefer xenbus_scanf() over xenbus_gather() To: Konrad Rzeszutek Wilk , Jan Beulich References: <577FB70002000078000FC9FA@prv-mh.provo.novell.com> <20160708141737.GG22329@char.us.oracle.com> CC: , Juergen Gross , , From: David Vrabel Message-ID: <577FC9A0.9080407@citrix.com> Date: Fri, 8 Jul 2016 16:41:20 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Icedove/38.5.0 MIME-Version: 1.0 In-Reply-To: <20160708141737.GG22329@char.us.oracle.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/07/16 15:17, Konrad Rzeszutek Wilk wrote: > On Fri, Jul 08, 2016 at 06:21:52AM -0600, Jan Beulich wrote: >> For single items being collected this should be preferred as being more >> typesafe (as the compiler can check format string and to-be-written-to >> variable match) and more efficient (requiring one less parameter to be >> passed). >> >> 1: xenbus: prefer xenbus_scanf() over xenbus_gather() >> 2: xen-blkback: prefer xenbus_scanf() over xenbus_gather() >> 3: xen-blkfront: prefer xenbus_scanf() over xenbus_gather() >> 4: xen-netback: prefer xenbus_scanf() over xenbus_gather() >> >> Signed-off-by: Jan Beulich >> --- >> v2: Avoid commit messages to continue from subjects. Group into a series. > > To confuse this, Roger and I are the block sub-maintainers, which > when we are happy, I send to Jens, while the rest go through Boris,David, and Juergen. > > Anyhow, I've already committed and tested for regressions these: > 79ef83a xen-blkback: constify instance of "struct attribute_group" > 5e4d659 xen-blkfront: prefer xenbus_scanf() over xenbus_gather() > e9d1ebe xen-blkback: prefer xenbus_scanf() over xenbus_gather() > 5b3b1db xen-blkback: really don't leak mode property If they're tree wide largely mechanical changes to Xen-related APIs I prefer that they go via the Xen tree all together. This saves the submitter chasing the individual subsystem maintainers. David