From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756049AbcGHSJQ (ORCPT ); Fri, 8 Jul 2016 14:09:16 -0400 Received: from mail-pa0-f67.google.com ([209.85.220.67]:35451 "EHLO mail-pa0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755453AbcGHSJL (ORCPT ); Fri, 8 Jul 2016 14:09:11 -0400 Subject: Re: [PATCH v2 0/6] net: ethernet: bgmac: Add platform device support To: Jon Mason , davem@davemloft.net References: <1467932938-21819-1-git-send-email-jon.mason@broadcom.com> Cc: zajec5@gmail.com, hauke@hauke-m.de, Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org From: Florian Fainelli Message-ID: <577FEC41.4050101@gmail.com> Date: Fri, 8 Jul 2016 11:09:05 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1467932938-21819-1-git-send-email-jon.mason@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/07/2016 04:08 PM, Jon Mason wrote: > David Miller, Please consider including patches 1-5 in net-next > > Florian Fainelli, Please consider including patches 6 & 7 in > devicetree/next David should pick all 6 patches, including the binding documentation, as this comes with the driver, I will take the DT patch (patch 7) through Broadcom's arm-soc. For this entire series, on BCM953012ER and BCM958625HR: Reviewed-by: Florian Fainelli Tested-by: Florian Fainelli > > Changes in v2: > * Made device tree binding changes suggested by Sergei Shtylyov, > Ray Jui, Rob Herring, Florian Fainelli, and Arnd Bergmann > * Removed devm_* error paths in the bgmac_platform.c suggested by > Florian Fainelli > * Added Arnd Bergmann's Acked-by to the first 5 (there were changes > outlined in the bullets above, but I believe them to be minor enough > for him to not revoke his acks) > > > This patch series adds support for other, non-bcma iProc SoC's to the > bgmac driver. This series only adds NSP support, but we are interested > in adding support for the Cygnus and NS2 families (with more possible > down the road). > > To support non-bcma enabled SoCs, we need to add the standard device > tree "platform device" support. Unfortunately, this driver is very > tighly coupled with the bcma bus and much unwinding is needed. I tried > to break this up into a number of patches to make it more obvious what > was being done to add platform device support. I was able to verify > that the bcma code still works using a 53012K board (NS SoC), and that > the platform code works using a 58625K board (NSP SoC). > > Thanks, > Jon > > > Jon Mason (6): > net: ethernet: bgmac: change bgmac_* prints to dev_* prints > net: ethernet: bgmac: add dma_dev pointer > net: ethernet: bgmac: move BCMA MDIO Phy code into a separate file > net: ethernet: bgmac: convert to feature flags > net: ethernet: bgmac: Add platform device support > dt-bindings: net: bgmac: add bindings documentation for bgmac > > .../devicetree/bindings/net/brcm,amac.txt | 24 + > .../devicetree/bindings/net/brcm,bgmac-nsp.txt | 24 + > drivers/net/ethernet/broadcom/Kconfig | 23 +- > drivers/net/ethernet/broadcom/Makefile | 2 + > drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c | 266 +++++++++ > drivers/net/ethernet/broadcom/bgmac-bcma.c | 315 ++++++++++ > drivers/net/ethernet/broadcom/bgmac-platform.c | 189 ++++++ > drivers/net/ethernet/broadcom/bgmac.c | 658 +++++---------------- > drivers/net/ethernet/broadcom/bgmac.h | 112 +++- > 9 files changed, 1097 insertions(+), 516 deletions(-) > create mode 100644 Documentation/devicetree/bindings/net/brcm,amac.txt > create mode 100644 Documentation/devicetree/bindings/net/brcm,bgmac-nsp.txt > create mode 100644 drivers/net/ethernet/broadcom/bgmac-bcma-mdio.c > create mode 100644 drivers/net/ethernet/broadcom/bgmac-bcma.c > create mode 100644 drivers/net/ethernet/broadcom/bgmac-platform.c > -- Florian