From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>,
Gregory Hermant <gregory.hermant@calao-systems.com>,
Jiri Prchal <jiri.prchal@aksignal.cz>,
Rodolfo Giometti <giometti@linux.it>,
Gael Portay <g.portay@overkiz.com>,
Joachim Eastwood <manabian@gmail.com>,
linux-kernel@vger.kernel.org,
Douglas Gilbert <dgilbert@interlog.com>,
Fabio Porcedda <fabio.porcedda@gmail.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Tim Schendekehl <tim.schendekehl@egnite.de>
Subject: Re: [PATCH 00/33] ARM: at91: Switch remaining SoCs and boards to CCF
Date: Tue, 01 Jul 2014 18:35:50 +0200 [thread overview]
Message-ID: <5780166.MMf0Vhnnsu@wuerfel> (raw)
In-Reply-To: <1404223962-30471-1-git-send-email-alexandre.belloni@free-electrons.com>
On Tuesday 01 July 2014 16:12:09 Alexandre Belloni wrote:
> This patch set adds support for the common clock framwork to the remaining atml
> SoCs: at91rm9200, at91sam9260, at91sam9263, at91sam9g45.
>
> It also defines the necessary main crystal and slow crystal frequencies.
>
> I couldn't find datasheets for the following boards:
> - mpa1600
> - ge863-pro3
> - animeo_ip
> - tny_a9260
>
> For those, I assumed the 32kHz crystal is present on the board as this is the
> most common implementation (only one board doesn't have it). Please correct me
> if this is wrong.
>
> I could not test at91rm9200 as I don't own any board with that chip.
Looks good overall, but I think this Kconfig snippet should be cleaned
up a little now:
config AT91_USE_OLD_CLK
bool
config AT91_PMC_UNIT
bool
default !ARCH_AT91X40
config COMMON_CLK_AT91
bool
default AT91_PMC_UNIT && USE_OF && !AT91_USE_OLD_CLK
select COMMON_CLK
config OLD_CLK_AT91
bool
default AT91_PMC_UNIT && AT91_USE_OLD_CLK
If I read this right, disabling 'USE_OF' results in still using
the old clock interface. Is that intentional? If you want to always
use COMMON_CLK now, the above can probably be simplified to
config AT91_PMC_UNIT
def_bool !ARCH_AT91X40
select COMMON_CLK
and all references to AT91_USE_OLD_CLK, COMMON_CLK_AT91 and
OLD_CLK_AT91 be removed.
Arnd
next prev parent reply other threads:[~2014-07-01 16:36 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 14:12 [PATCH 00/33] ARM: at91: Switch remaining SoCs and boards to CCF Alexandre Belloni
2014-07-01 14:12 ` [PATCH 01/33] Documentation: dt: document all the atmel pmc compatibles Alexandre Belloni
2014-07-02 8:10 ` Boris BREZILLON
2014-07-01 14:12 ` [PATCH 02/33] ARM: at91/dt: ariag25: define crystals frequencies Alexandre Belloni
2014-07-01 14:12 ` [PATCH 03/33] clk: at91: main: warn when the main crystal frequency is not set Alexandre Belloni
2014-07-02 8:18 ` Boris BREZILLON
2014-07-02 8:23 ` Boris BREZILLON
2014-07-02 16:38 ` Mike Turquette
2014-07-02 16:55 ` Boris BREZILLON
2014-07-01 14:12 ` [PATCH 04/33] ARM: at91: prepare common clk transition for rm9200 Alexandre Belloni
2014-07-02 8:20 ` Boris BREZILLON
2014-07-01 14:12 ` [PATCH 05/33] ARM: at91/dt: rm9200: define clocks Alexandre Belloni
2014-07-02 8:04 ` Boris BREZILLON
2014-07-01 14:12 ` [PATCH 06/33] ARM: at91: move at91rm9200 SoC to the CCF Alexandre Belloni
2014-07-02 8:25 ` Boris BREZILLON
2014-07-01 14:12 ` [PATCH 07/33] ARM: at91/dt: at91rm9200ek: define crystals frequencies Alexandre Belloni
2014-07-01 14:12 ` [PATCH 08/33] ARM: at91: prepare common clk transition for sam9260 Alexandre Belloni
2014-07-01 14:12 ` [PATCH 09/33] ARM: at91/dt: sam9260: define clocks Alexandre Belloni
2014-07-01 14:12 ` [PATCH 10/33] ARM: at91/dt: sam9g20: " Alexandre Belloni
2014-07-01 14:12 ` [PATCH 11/33] ARM: at91: move at91sam9260 SoCs to the CCF Alexandre Belloni
2014-07-01 14:12 ` [PATCH 12/33] ARM: at91/dt: at91sam9g20ek: define crystals frequencies Alexandre Belloni
2014-07-01 14:12 ` [PATCH 13/33] ARM: at91/dt: foxg20: " Alexandre Belloni
2014-07-01 14:12 ` [PATCH 14/33] ARM: at91/dt: usb_a9260: " Alexandre Belloni
2014-07-01 14:12 ` [PATCH 15/33] ARM: at91/dt: tny_a9260: " Alexandre Belloni
2014-07-01 14:12 ` [PATCH 16/33] ARM: at91/dt: qil_a9260: " Alexandre Belloni
2014-07-01 14:12 ` [PATCH 17/33] ARM: at91/dt: mpa1600: define crytals frequencies Alexandre Belloni
2014-07-01 14:12 ` [PATCH 18/33] ARM: at91/dt: ge863-pro3: define crystals frequencies Alexandre Belloni
2014-07-01 14:12 ` [PATCH 19/33] ARM: at91/dt: ethernut5: " Alexandre Belloni
2014-07-01 14:12 ` [PATCH 20/33] ARM: at91/dt: animeo_ip: " Alexandre Belloni
2014-07-01 14:12 ` [PATCH 21/33] ARM: at91/dt: kizbox: define main crystal frequency Alexandre Belloni
2014-07-01 14:12 ` [PATCH 22/33] ARM: at91: prepare common clk transition for sam9g45 Alexandre Belloni
2014-07-01 14:12 ` [PATCH 23/33] ARM: at91/dt: sam9g45: define clocks Alexandre Belloni
2014-07-01 14:12 ` [PATCH 24/33] ARM: at91: move at91sam9g45 SoC to the CCF Alexandre Belloni
2014-07-01 14:12 ` [PATCH 25/33] ARM: at91/dt: sam9m10g45ek: define crystals frequencies Alexandre Belloni
2014-07-01 14:12 ` [PATCH 26/33] ARM: at91/dt: pm9g45: " Alexandre Belloni
2014-07-01 14:12 ` [PATCH 27/33] ARM: at91/dt: cosino define " Alexandre Belloni
2014-07-01 14:12 ` [PATCH 28/33] ARM: at91: prepare common clk transition for sam9263 Alexandre Belloni
2014-07-01 14:12 ` [PATCH 29/33] ARM: at91/dt: sam9263: define clocks Alexandre Belloni
2014-07-01 14:12 ` [PATCH 30/33] ARM: at91: move at91sam9263 SoC to the CCF Alexandre Belloni
2014-07-01 14:12 ` [PATCH 31/33] ARM: at91/dt: sam9263ek: define crystals frequencies Alexandre Belloni
2014-07-01 14:12 ` [PATCH 32/33] ARM: at91/dt: tny_a9263: " Alexandre Belloni
2014-07-01 14:12 ` [PATCH 33/33] ARM: at91/dt: usb_a9263: " Alexandre Belloni
2014-07-01 16:35 ` Arnd Bergmann [this message]
2014-07-01 16:48 ` [PATCH 00/33] ARM: at91: Switch remaining SoCs and boards to CCF Alexandre Belloni
2014-07-01 17:01 ` Arnd Bergmann
2014-07-01 17:56 ` Alexandre Belloni
2014-07-01 20:02 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5780166.MMf0Vhnnsu@wuerfel \
--to=arnd@arndb.de \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=dgilbert@interlog.com \
--cc=fabio.porcedda@gmail.com \
--cc=g.portay@overkiz.com \
--cc=giometti@linux.it \
--cc=gregory.hermant@calao-systems.com \
--cc=jiri.prchal@aksignal.cz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manabian@gmail.com \
--cc=nicolas.ferre@atmel.com \
--cc=plagnioj@jcrosoft.com \
--cc=tim.schendekehl@egnite.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox