From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756506AbcGHXBC (ORCPT ); Fri, 8 Jul 2016 19:01:02 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:33843 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756287AbcGHXA4 (ORCPT ); Fri, 8 Jul 2016 19:00:56 -0400 Subject: Re: [PATCH] Revert "net: ethernet: bcmgenet: use phy_ethtool_{get|set}_link_ksettings" To: Philippe Reynes , davem@davemloft.net References: <1468018487-8102-1-git-send-email-tremyfr@gmail.com> Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org From: Florian Fainelli Message-ID: <578030A5.3060704@gmail.com> Date: Fri, 8 Jul 2016 16:00:53 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1468018487-8102-1-git-send-email-tremyfr@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 07/08/2016 03:54 PM, Philippe Reynes wrote: > This reverts commit 4386f5662e63 ("net: ethernet: bcmgenet: use > phy_ethtool_{get|set}_link_ksettings") > > This patch is wrong, the function phy_ethtool_{get|set}_link_ksettings > don't check if the device is running, but the driver bcmgenet need this > check. > > The function {get|set}_settings need to access the mdio bus, and this > bus may only be used when the device is running. Otherwise, the clock > is disable and a mdio access will fail. > > Signed-off-by: Philippe Reynes Acked-by: Florian Fainelli Thanks! -- Florian