From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757481AbcGKCOU (ORCPT ); Sun, 10 Jul 2016 22:14:20 -0400 Received: from mr213139.mail.yeah.net ([223.252.213.139]:20060 "EHLO mr213139.mail.yeah.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755498AbcGKCOR (ORCPT ); Sun, 10 Jul 2016 22:14:17 -0400 X-Greylist: delayed 66698 seconds by postgrey-1.27 at vger.kernel.org; Sun, 10 Jul 2016 22:14:06 EDT Subject: Re: [PATCH v2 09/10] Documentation: devicetree: Add dts description for nuc900 To: Arnd Bergmann , linux-arm-kernel@lists.infradead.org References: <1468136542-2656-1-git-send-email-vw@iommu.org> <1468136542-2656-2-git-send-email-vw@iommu.org> <1850749.ap1S8Xq0fA@wuerfel> Cc: Russell King , devicetree@vger.kernel.org, linux-clk@vger.kernel.org, jason@lakedaemon.net, Daniel Lezcano , linux-kernel@vger.kernel.org, p.zabel@pengutronix.de, Thomas Gleixner , Wan Zongshun From: Wan Zongshun Message-ID: <578300E2.5000405@iommu.org> Date: Mon, 11 Jul 2016 10:13:54 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <1850749.ap1S8Xq0fA@wuerfel> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-HM-Spam-Status: e1koWUFPN1dZCBgUCR5ZQVZIVU1KSEtLS0pOT09CTklIQkhXWQkOFx4IWU FZKCs9JDU#Li8pOjckMjUkMz46Pz4pQUtVS0A2IyQiPigkMjUkMz46Pz4pQUtVS0ArLykkIj4oJD I1JDM#Oj8#KUFLVUtAODQuNS8pIiQ4NUFLVUtAKT48MjQ1JDooMjpBS1VLQCspNC0yNTg#JCgzOj U8MzoyQUtVS0A*IjU6NjI4JDIrJDU0JDI1JDM#Oj8#KUFLVUtANi43LzIkKTgrLyQ*Mj09Pik#NS 8kMjUkMz46Pz4pQUlVS0AyKyRISyQ2MjUuLz4kODUvJEskTktBS1VLQDIrJEokNjI1Li8#JDg1Ly RLJEpLQUtVS0AyKyQvND86IiQ4NS8kSyRKS0tBS1VLQDIrJE4kNjI1Li8#JDg1LyRLJEpLQUtVS0 AyKyRKJDM0LikkODUvJEskSktLQUtVS0AoLjkxPjgvJC80PzoiJDg1LyRLJEpLS0FLVUtAKC45MT 44LyROJDYyNS4vPiQ4NS8kSyRKS0FLVUtAKC45MT44LyRKJDM0LikkODUvJEskSktLQUtVS0AoOT EkNz41JE9LJCNBS1VLS0pLQC8#Iy8kNz41JEhJSyRKSUNLQUtVS0tKS0A4NS8kMy82NyQ3PjUkSj AkTjBBS1VLS0pLQCk#OD4yLT4pJDg1LyROJCNBS1VLS0pLQCM2OjI3PikkNS43N0FLVUtLSktAPz 43Mi0#KSQ3PjUkS0FLVUtLSktANzo1PCQ4NUFLVUtLSktAPTUkNjoiJE9KQiQzNzEkSiRLQ0tIS0 9BS1VISEA9KyQpPiQ9LCQzNzEkS0NLSEtNQVZMVU5AKC45JD5BSlVOTlkG X-HM-Sender-Digest: e1kSHx4VD1lBWUc6OQw6UTo6QjoiPjIJOlYNM0MjAigKCTNVSlVKT01D SUtISUhNS0NIVTMWGhIXVQ0MOxIUFhYOVRQJHEVZV1kMHhlZQR0aFwgeV1kIAVlBSEtJTTdXWRIL WUFZSUpLVUpIVUJMVUpNQ1kG X-HM-Tid: 0a55d7bb7a7d7d8b3b5fd1c1b42 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2016年07月11日 06:17, Arnd Bergmann wrote: > On Sunday, July 10, 2016 3:42:21 PM CEST Wan Zongshun wrote: >> + >> +Required properties: >> +- compatible : Should be "nuvoton,nuc970-tmr" >> +- reg : Address and length of the register set >> +- clocks : Reference on the timer input clock >> +- interrupts : Reference to the timer interrupt >> + >> +Example: >> + >> +tmr@0xb8001000 { > > The name should be "timer", not "tmr", and the address should > not contain a leading "0x". Ok, so all dts addresses has no need contain a leading "0x"? > >> + compatible = "nuvoton,nuc970-tmr"; >> + reg = <0xb8001000 0x1000>; >> + interrupts = <16>; >> + clocks = <&clks TIMER0_GATE>, >> + <&clks TIMER1_GATE>; >> + clock-names = "timer0", "timer1"; >> +}; > > The clocks/clock-names description does not match the example: > you only define a single clock in the required properties, but > have two separate inputs in the example. Please fix one or the > other. Two clocks are necessary, so I only need modify this description like? Required properties: clocks : Reference on the timer input clock, This list should be 2 clocks, the order is timer0 , timer1. Is it ok? > > Arnd > >